Fix#8925: unable to set back a value to the inherited default value on profile #8926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Eugeny,
As discuss in #8912 and describe in #8925, my previous PR #8726 seems to have bring a new bug regarding the
Disable dynamic tab title
andClear terminal after connection
options (really sorry about that :/). At the time of the PR, I only notice this problem with thegroup
attribute. I think we do not have other choice than deleting profile fields one by one inwriteProfile
method to prevent having ghost attributes in the profile config.Without deleting the field one by one,
Object.assign
call does not deleteundefinied
value from the profile object (Context from #8726):Anyway, as we now provide profile object copy with
getProfileGroups
, profile field suppression can only be done insidewriteProfile
method. (related refactoring in e4169a5)I tried my best to describe what I found, I hope all of this is clear enough ^^'
Feel free to ask if any changes needed
Resolve #8925