Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds #9238

Merged
merged 12 commits into from
Nov 20, 2023
Merged

Fix builds #9238

merged 12 commits into from
Nov 20, 2023

Conversation

Clem-Fern
Copy link
Contributor

@Clem-Fern Clem-Fern commented Nov 15, 2023

Hey @Eugeny,

As describe in #9235, latest linux release is unusable. Sadly, I couldn't identify precisly where the problem was coming from.
I think it was related to node-gyp 10.0.0 dependecy in the root project. 0f6561e

I do not have any mac device with me. Could you try this build ? https://github.com/Eugeny/tabby/actions/runs/6883409733

There is also a weird behavior on the macos-12 runner image. The default python version for macos arm64 is python2 (python 3 on x86_64).
it does not seem to be an issue right now but it has to be kept in mind as this python version is now deprecated. It could bring some difficulty in the future.

Fix #9235
Fix #9242
Fix #9245

@Eugeny
Copy link
Owner

Eugeny commented Nov 16, 2023

The build you linked works on Mac, both x64 and arm64 👍

@Clem-Fern
Copy link
Contributor Author

I've got some graphic glitch with the title bar backgrond on windows 10 and 11 :/

@Eugeny
Copy link
Owner

Eugeny commented Nov 16, 2023

Hmm... it looks fine on my windows 11 x64

@Clem-Fern
Copy link
Contributor Author

Clem-Fern commented Nov 16, 2023

Problem seems to only appear when Settings > Window > Theme is set to Follow the color scheme

I can open a dedicated issue for this if you dont want to block this PR

@Eugeny
Copy link
Owner

Eugeny commented Nov 16, 2023

Sure! You've already tested the linux builds, right?

@Clem-Fern
Copy link
Contributor Author

Sure! You've already tested the linux builds, right?

Yup, starting normally, but didn't get the time to dig in more in detail, sorry

@Clem-Fern Clem-Fern marked this pull request as ready for review November 16, 2023 22:35
@Clem-Fern Clem-Fern changed the title WIP: Fix builds Fix builds Nov 16, 2023
@Upellift99
Copy link

Sure! You've already tested the linux builds, right?

Yup, starting normally, but didn't get the time to dig in more in detail, sorry

I've tested the Linux DEB amd64 build v1.0.205-nightly.0, and it's working again on Ubuntu 22.04 !

I've just noticed these small problems:

  • the background of the drop-down menu in which you can choose the duration for saving the vault passphrase remains transparent;
  • the value of the duration for saving the vault passphrase is not saved when you restart the app;
  • the recent profiles are not saved when you restart the app.

But the rest of the application is completely usable!

Thank you!

@Clem-Fern
Copy link
Contributor Author

Clem-Fern commented Nov 20, 2023

@Upellift99 Thank's a lot for this feedback.

I will try to fix soon.

@Clem-Fern
Copy link
Contributor Author

Clem-Fern commented Nov 20, 2023

@Upellift99 I wasnt able to reproduce any of theses issues :/

  • the background of the drop-down menu in which you can choose the duration for saving the vault passphrase remains transparent;

What theme do you use ?

  • the value of the duration for saving the vault passphrase is not saved when you restart the app;
  • the recent profiles are not saved when you restart the app.

Do you have any error in logs ?

A profile is pushed into recent profiles at tab opening and not on app shutdown. Restarting should not affect the recent profiles list.

Just after opening a profile, do you see it appears in recent list in Profiles & Connections ?

@Upellift99
Copy link

You are right, after rebooting the system, I can't reproduce all the problems, there is just the background of the drop-down menu which remains transparent. Sorry for that!
Capture d’écran du 2023-11-20 09-59-24
For the theme, you mean the color sheme? the name is Expresso

@Clem-Fern
Copy link
Contributor Author

@Upellift99 no worry, thank you for the feedback anyway.

In that case, could you open an dedicated issue about this as it seems only to append with this color scheme.

@Upellift99
Copy link

Done! #9256

@Eugeny Eugeny merged commit aae0147 into Eugeny:master Nov 20, 2023
10 checks passed
@Clem-Fern Clem-Fern deleted the fix-build branch November 20, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to execute from Ubuntu 22.04 Tabby execute failed Issue after update on ubuntu 22.04
3 participants