-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix builds #9238
Fix builds #9238
Conversation
The build you linked works on Mac, both x64 and arm64 👍 |
I've got some graphic glitch with the title bar backgrond on windows 10 and 11 :/ |
Hmm... it looks fine on my windows 11 x64 |
Problem seems to only appear when Settings > Window > Theme is set to I can open a dedicated issue for this if you dont want to block this PR |
Sure! You've already tested the linux builds, right? |
Yup, starting normally, but didn't get the time to dig in more in detail, sorry |
I've tested the Linux DEB amd64 build v1.0.205-nightly.0, and it's working again on Ubuntu 22.04 ! I've just noticed these small problems:
But the rest of the application is completely usable! Thank you! |
@Upellift99 Thank's a lot for this feedback. I will try to fix soon. |
@Upellift99 I wasnt able to reproduce any of theses issues :/
What theme do you use ?
Do you have any error in logs ? A profile is pushed into recent profiles at tab opening and not on app shutdown. Restarting should not affect the recent profiles list. Just after opening a profile, do you see it appears in recent list in Profiles & Connections ? |
@Upellift99 no worry, thank you for the feedback anyway. In that case, could you open an dedicated issue about this as it seems only to append with this color scheme. |
Done! #9256 |
Hey @Eugeny,
As describe in #9235, latest linux release is unusable. Sadly, I couldn't identify precisly where the problem was coming from.
I think it was related to node-gyp 10.0.0 dependecy in the root project. 0f6561e
I do not have any mac device with me. Could you try this build ? https://github.com/Eugeny/tabby/actions/runs/6883409733
There is also a weird behavior on the macos-12 runner image. The default python version for macos arm64 is python2 (python 3 on x86_64).
it does not seem to be an issue right now but it has to be kept in mind as this python version is now deprecated. It could bring some difficulty in the future.
Fix #9235
Fix #9242
Fix #9245