Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force display title-bar when tab-bar on left/right #9249

Merged
merged 19 commits into from
Nov 21, 2023

Conversation

Clem-Fern
Copy link
Contributor

Hey @Eugeny,

This PR changes a bit the title bar behavior when :

  • Window frame = Thin
  • Tabs location = Left or Right

Before:
image

With this PR:
image

It is actually the same behavior as Window frame Full but I find it a lot more user friendly and practical that way.
What do you think ?

@Eugeny
Copy link
Owner

Eugeny commented Nov 18, 2023

Screenshot 2023-11-18 at 21 24 09

Can you enable this only on Linux & Windows? On macOS, tabby has special provisions for window controls on the left side

@Clem-Fern
Copy link
Contributor Author

Arf... definitely failed my merge sorry...
We can wait for #9238 to be ok before merging this. Or I can recreate a proper PR.

Anyway, good to know for macos thank's, the platform should not be impacted now 191807c

@Eugeny Eugeny merged commit 3823efc into Eugeny:master Nov 21, 2023
10 checks passed
@Clem-Fern Clem-Fern deleted the title-bar branch November 21, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants