-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Add tracing for runner #3113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3113 will degrade performances by 53.29%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3113 +/- ##
==========================================
- Coverage 79.13% 77.79% -1.34%
==========================================
Files 637 645 +8
Lines 77982 79915 +1933
==========================================
+ Hits 61712 62171 +459
- Misses 16270 17744 +1474
|
jaychia
commented
Oct 27, 2024
jaychia
commented
Oct 27, 2024
jaychia
force-pushed
the
jay/scheduler-tracing
branch
2 times, most recently
from
October 29, 2024 02:12
a07a517
to
0af74f3
Compare
jaychia
force-pushed
the
jay/scheduler-tracing
branch
2 times, most recently
from
November 1, 2024 23:08
b384352
to
0cbc552
Compare
jaychia
force-pushed
the
jay/scheduler-tracing
branch
from
November 1, 2024 23:10
0cbc552
to
69c2c64
Compare
jaychia
force-pushed
the
jay/scheduler-tracing
branch
from
November 6, 2024 19:18
eb733e8
to
64af511
Compare
samster25
reviewed
Nov 7, 2024
samster25
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tracing for the RayRunner. This is turned off by default, and can be deactivated via
DAFT_ENABLE_RAY_TRACING=1
.Visualize this with https://ui.perfetto.dev/