Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] implement range operation and data streaming #3267

Merged
merged 9 commits into from
Nov 13, 2024

Conversation

andrewgazelka
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Nov 12, 2024
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #3267 will improve performances by 19.73%

Comparing andrew/connect-range (9c26532) with main (e37c6d3)

Summary

⚡ 2 improvements
✅ 15 untouched benchmarks

Benchmarks breakdown

Benchmark main andrew/connect-range Change
test_iter_rows_first_row[100 Small Files] 339.9 ms 287.5 ms +18.2%
test_show[100 Small Files] 40.6 ms 33.9 ms +19.73%

Copy link
Contributor

@universalmind303 universalmind303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me, a few minor suggestions and comments.

src/daft-connect/src/convert.rs Outdated Show resolved Hide resolved
src/daft-connect/src/convert/expression.rs Outdated Show resolved Hide resolved
src/daft-connect/src/convert/plan_conversion.rs Outdated Show resolved Hide resolved
src/daft-connect/src/convert/plan_conversion.rs Outdated Show resolved Hide resolved
src/daft-connect/src/convert/plan_conversion.rs Outdated Show resolved Hide resolved
@@ -92,6 +124,9 @@ impl NativeExecutor {
results_buffer_size,
)
})?;

let out = BlockingStreamIter::new(out);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment on why we need to block here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not completely sure but aren't we not leveraging python async really? → we are just blocking for a task to complete

src/daft-scan/src/hive.rs Outdated Show resolved Hide resolved
src/daft-connect/src/session.rs Outdated Show resolved Hide resolved
src/daft-connect/src/convert.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 49.78723% with 118 lines in your changes missing coverage. Please review.

Project coverage is 77.58%. Comparing base (e37c6d3) to head (9c26532).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/convert/formatting.rs 0.00% 58 Missing ⚠️
src/daft-connect/src/lib.rs 14.06% 55 Missing ⚠️
src/daft-connect/src/convert/data_conversion.rs 83.33% 2 Missing ⚠️
src/daft-connect/src/convert/schema_conversion.rs 0.00% 2 Missing ⚠️
.../daft-connect/src/convert/data_conversion/range.rs 96.77% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3267      +/-   ##
==========================================
+ Coverage   77.54%   77.58%   +0.04%     
==========================================
  Files         659      664       +5     
  Lines       80565    80798     +233     
==========================================
+ Hits        62473    62689     +216     
- Misses      18092    18109      +17     
Files with missing lines Coverage Δ
src/daft-connect/src/command.rs 100.00% <100.00%> (ø)
.../daft-connect/src/convert/data_conversion/range.rs 96.77% <96.77%> (ø)
src/daft-connect/src/convert/data_conversion.rs 83.33% <83.33%> (ø)
src/daft-connect/src/convert/schema_conversion.rs 0.00% <0.00%> (ø)
src/daft-connect/src/lib.rs 47.54% <14.06%> (-11.14%) ⬇️
src/daft-connect/src/convert/formatting.rs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

@universalmind303 universalmind303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly fine to me. I think some function/struct names could be clearer to better express their purpose - but that's just my opinion.

@andrewgazelka andrewgazelka merged commit 1a4d259 into main Nov 13, 2024
43 of 44 checks passed
@andrewgazelka andrewgazelka deleted the andrew/connect-range branch November 13, 2024 00:01
@andrewgazelka
Copy link
Contributor Author

This looks mostly fine to me. I think some function/struct names could be clearer to better express their purpose - but that's just my opinion.

will do in future PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants