Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] implement range operation and data streaming #3267

Merged
merged 9 commits into from
Nov 13, 2024

revert

9c26532
Select commit
Loading
Failed to load commit list.
Merged

[FEAT] implement range operation and data streaming #3267

revert
9c26532
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 12, 2024 in 0s

77.58% (+0.04%) compared to e37c6d3

View this Pull Request on Codecov

77.58% (+0.04%) compared to e37c6d3

Details

Codecov Report

Attention: Patch coverage is 49.78723% with 118 lines in your changes missing coverage. Please review.

Project coverage is 77.58%. Comparing base (e37c6d3) to head (9c26532).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/convert/formatting.rs 0.00% 58 Missing ⚠️
src/daft-connect/src/lib.rs 14.06% 55 Missing ⚠️
src/daft-connect/src/convert/data_conversion.rs 83.33% 2 Missing ⚠️
src/daft-connect/src/convert/schema_conversion.rs 0.00% 2 Missing ⚠️
.../daft-connect/src/convert/data_conversion/range.rs 96.77% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3267      +/-   ##
==========================================
+ Coverage   77.54%   77.58%   +0.04%     
==========================================
  Files         659      664       +5     
  Lines       80565    80798     +233     
==========================================
+ Hits        62473    62689     +216     
- Misses      18092    18109      +17     
Files with missing lines Coverage Δ
src/daft-connect/src/command.rs 100.00% <100.00%> (ø)
.../daft-connect/src/convert/data_conversion/range.rs 96.77% <96.77%> (ø)
src/daft-connect/src/convert/data_conversion.rs 83.33% <83.33%> (ø)
src/daft-connect/src/convert/schema_conversion.rs 0.00% <0.00%> (ø)
src/daft-connect/src/lib.rs 47.54% <14.06%> (-11.14%) ⬇️
src/daft-connect/src/convert/formatting.rs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes