Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA-3] Implement logic for passing through schema in JSON and Parquet #924

Closed
wants to merge 11 commits into from

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented May 12, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #924 (e8d57d3) into main (9128b06) will increase coverage by 1.21%.
The diff coverage is 94.31%.

❗ Current head e8d57d3 differs from pull request most recent head 59c7606. Consider uploading reports for the commit 59c7606 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
+ Coverage   84.87%   86.08%   +1.21%     
==========================================
  Files         184      178       -6     
  Lines       15922    14176    -1746     
==========================================
- Hits        13514    12204    -1310     
+ Misses       2408     1972     -436     
Impacted Files Coverage Δ
daft/io/common.py 85.00% <70.00%> (-15.00%) ⬇️
src/table/mod.rs 82.40% <92.30%> (+0.06%) ⬆️
daft/table/table_io.py 97.39% <97.29%> (-0.42%) ⬇️
daft/execution/logical_op_runners.py 97.36% <100.00%> (+0.07%) ⬆️
daft/io/_csv.py 100.00% <100.00%> (ø)
daft/io/_json.py 100.00% <100.00%> (ø)
daft/io/parquet.py 100.00% <100.00%> (ø)
daft/logical/schema.py 93.90% <100.00%> (+0.31%) ⬆️
daft/runners/partitioning.py 82.85% <100.00%> (-1.08%) ⬇️
daft/runners/runner_io.py 90.62% <100.00%> (-1.27%) ⬇️
... and 3 more

... and 95 files with indirect coverage changes

@jaychia jaychia changed the base branch from main to jay/read-with-schema-2 May 12, 2023 03:22
@jaychia jaychia force-pushed the jay/read-with-schemas-3 branch from e374c88 to 59c7606 Compare June 5, 2023 21:58
@jaychia jaychia changed the base branch from jay/read-with-schema-2 to main June 5, 2023 21:59
@jaychia
Copy link
Contributor Author

jaychia commented Jun 7, 2023

Closing in favor of #1010

@jaychia jaychia closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant