[$500] The account number is masked and you can't move forward with VBA flow - Reported by @Puneet-here

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to bank account > add info > company step > personal information
2. Dismiss the modal by pressing cross
3. Now go to workspace > "connect bank account" > continue with the setup
4. Now keep going back until you reach page with routing number & account number
5. Now try pressing save and continue

Expected Result:

The account number shouldn't be masked or if we mask it we should let user save & continue

Actual Result:

The account number is masked and you can't save & continue

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.3-0
Reproducible in staging?: Y
Reproducible in production?: need repro PROD creds
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-09-09.at.11.56.29.PM.mov

Upwork job URL: https://www.upwork.com/jobs/~01eb5ae98c2c497e8f
Issue reported by: @Puneet-here

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1662750530375309

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Christinadobrzyn]

Ooh, that looks like a good one to fix

[aldo-expensify]

I'm not being able to reproduce this, instructions feel a bit incomplete too:

• This is while adding a bank account in a workspace (business bank account), right? If that is the case, please add it in the steps
• I tested adding a business bank account (in the workspace) using plaid and manual, reaching the Personal information step and then going back with the arrow. In neither case I saw the numbers masked

@mvtglobally Can you help me with clarifying the reproduction steps? thanks :)

[Puneet-here]

This is while adding a bank account in a workspace (business bank account), right? If that is the case, please add it in the steps

Yes, you have to add the bank account at workspace and after reaching the personal details page you have dismiss the modal as suggested in the step 2.
Now go at workspace > connect bank account > continue with setup > go back till routing page

[aldo-expensify]

I'm still not able to reproduce this, not in dev and neither in staging. I don't get the account numbers masked. I tried again using plaid and manual input of the account numbers. I close the modal when I get the verification thing from Onfido (after entering the personal details: name, last name, etc).

Any idea of what I may be missing?

[melvin-bot]

@aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[aldo-expensify]

@Puneet-here 👋 can you confirm if this is still happening and if you reproduce it, give me the exact steps to reproduce it? Thanks

[Puneet-here]

@Puneet-here 👋 can you confirm if this is still happening and if you reproduce it, give me the exact steps to reproduce it? Thanks

I was able to see the masked account number but couldn't find the exact step, I will let you know after testing again.

[Puneet-here]

@Puneet-here 👋 can you confirm if this is still happening and if you reproduce it, give me the exact steps to reproduce it? Thanks

I found that when you log out and login again then this is reproducible every time.

1. Go to workspace > connect bank account > chose an option > add info > company step > personal information
2. Dismiss the modal by pressing cross
3. Sign out and sign in again
4. Go to workspace > connect bank account > continue with the setup
5. Start going back

Earlier it was happening without signing out, we just had to dismiss the modal.

I think after logging out it seeing masked account number could be intentional.

[aldo-expensify]

cool, thanks for getting new reproduction steps. I'll try them later ❤️

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[aldo-expensify]

Changing priority of this since this is only open to handle payment now.

[melvin-bot]

Triggered auto assignment to @maddylewis (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Current assignees @luacmartins and @aldo-expensify are eligible for the External assigner, not assigning anyone new.

[aldo-expensify]

Removed @Santhosh-Sellavel because we only need to handle payment now. @maddylewis can you help us with the payment for @Puneet-here for reporting this issue? thanks!

[michaelhaxhiu]

hmm, it seems like it #11318 (comment) to assign someone because everyone is out of office.. hehe

PS, not quite true 😄 -- I think GH webhooks were just failing yesterday for a period of time.

@aldo-expensify just to clarify, only a bug reporting bonus is due to @Puneet-here ?

[michaelhaxhiu]

Ah I see now... this was reported by @Puneet-here and then we fixed it internally via #11616.

Ok yes, only a bug reporting bonus is due in this case to @Puneet-here ($250). cc @maddylewis

[maddylewis]

thanks for confirming @michaelhaxhiu! i will complete this today.

[Puneet-here]

Ok yes, only a bug reporting bonus is due in this case to @Puneet-here ($250). cc @maddylewis

I think the compensation should be $500. I had reported this issue (here) and a deploy blocker yesterday (here) both were unrelated and valid bugs and were fixed in #11616

[maddylewis]

@aldo-expensify @michaelhaxhiu - will you confirm those details for me ^^^

[luacmartins]

@aldo-expensify @michaelhaxhiu - will you confirm those details for me ^^^

@maddylewis that is correct. The compensation should be $500 for the two issues reported as @Puneet-here mentioned!

[aldo-expensify]

hmm, but as far as I know, we never got to triage / reproduce the issue reported in slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1664994310748019. If it had been triaged, there could have been a chance of it getting closed because of being the same as this one.

[michaelhaxhiu]

Spoke more with @aldo-expensify 1:1 and while this feels like both bugs were similarly related, I think there's a case to be made for treating them separately. Let's pay out $500 total for both this time under 1 job in upwork.

[maddylewis]

i do not have access to Upwork yet. it looks like we're working on getting access here - https://expensify.slack.com/archives/C01SKUP7QR0/p1665037871877899

I'll reach out to another Contributor Mgmt Team member about processing this payment today.

[michaelhaxhiu]

Job link - https://www.upwork.com/jobs/~01eb5ae98c2c497e8f

I invited you to the job @Puneet-here

[Puneet-here]

Job link - https://www.upwork.com/jobs/~01eb5ae98c2c497e8f

I invited you to the job @Puneet-here

I have applied.

[michaelhaxhiu]

Done deal, closing.