Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-11-17 #12812

Closed
35 tasks done
OSBotify opened this issue Nov 17, 2022 · 16 comments
Closed
35 tasks done

Deploy Checklist: New Expensify 2022-11-17 #12812

OSBotify opened this issue Nov 17, 2022 · 16 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Nov 17, 2022

Release Version: 1.2.29-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Nov 17, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.29-3 🚀

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.29-4 🚀

@roryabraham
Copy link
Contributor

#12829 was CP'd to fix #12822, please retest

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.29-4 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.29-5 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.29-5 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.29-6 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.29-6 has been deployed to staging 🎉

@mvtglobally
Copy link

@roryabraham

Regression is completed.
PR #12632 is failing #12854. This is not repro in PROD as the feature is being intro by this PR, so we didnt add the Blocker label. Pls double check
PR #12718 is works with plain text but not with quoted text as in the PR. #12718 (comment). Seems expected, but wanted to double check
PR #12728 is failing #11262. checking off as its known issue
PR #12737 is failing on mWeb #12852. Its repro in PROD, so checking off

@roryabraham
Copy link
Contributor

PR #12632 is failing #12854. This is not repro in PROD as the feature is being intro by this PR, so we didnt add the Blocker label. Pls double check

Checked off

PR #12718 is works with plain text but not with quoted text as in the PR. #12718 (comment). Seems expected, but wanted to double check

@puneetlath confirmed in the PR that this is the expected behavior, checking off

@melvin-bot melvin-bot bot added the Monthly KSv2 label Nov 21, 2022
@mvtglobally
Copy link

@AndrewGable just 2 outstanding blockers. Hopefully we can get a new Deploy today
#12865
#12889

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.29-7 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.29-7 has been deployed to staging 🎉

@mvtglobally
Copy link

We are missing 1.2.29-7 on IOS. Rest of the platforms pass for PR #12897

@mountiny
Copy link
Contributor

Checking #12865 off as it seems to not be reproducible anymore

@AndrewGable
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants