fix: blue outline appears for a moment on buttons #12090

MarkCSmith · 2022-10-24T15:28:36Z

Remove focus from the chat action button, emoji picker, and the video chat button immediately after the buttons are clicked/tapped.

Details

A blue focus ring is displayed when a button has focus, but this is undesirable. By immediately calling blur() on the element we can suppress the focus ring.

Fixed Issues

$ #11433
$ PROPOSAL #11433 (comment)

Tests

For MacOS Chrome and MacOS Desktop:

Navigate to a chat.
Click on the Actions button.
Press up or down arrow to select Send money.
Press enter.
Verify visually that no blue ring exists on the Actions button.
Close the Send money panel.
Click on the Call button.
Press arrow key.
Press escape.
Verify visually that no blue ring exists on the Call button.
Click on the Emoji button.
Use the arrow keys to choose an emoji.
Press enter.
Verify visually that no blue ring exists on the Emoji button.
Close the chat and click on the FAB.
Use the arrow keys to select Send money.
Verify visually that no blue ring briefly appears on the FAB button.

For iOS/native, Android/native, iOS/Safari, and Android/Chrome:

Navigate to a chat.
Tap on the Actions button.
Tap above the actions menu to dismiss it.
Verify visually that no blue ring exists on the Actions button.
Tap on the Call button.
Tap above the call menu to dismiss it.
Verify visually that no blue ring exists on the Actions button.
Tap on the Emoji button.
Tap an emoji.
Verify visually that no blue ring briefly appears on the Emoji button.
Close the chat and tap on the FAB.
Tap outside the menu to dismiss it.
Verify visually that no blue ring exists on the FAB button.

Note: on Android/Chrome in the device we used for testing, the focus ring
was orange instead of blue.

Verify that no errors appear in the JS console

QA Steps

For MacOS Chrome and MacOS Desktop:

Navigate to a chat.
Click on the Actions button.
Press up or down arrow to select Send money.
Press enter.
Verify visually that no blue ring exists on the Actions button.
Close the Send money panel.
Click on the Call button.
Press arrow key.
Press escape.
Verify visually that no blue ring exists on the Call button.
Click on the Emoji button.
Use the arrow keys to choose an emoji.
Press enter.
Verify visually that no blue ring exists on the Emoji button.
Close the chat and click on the FAB.
Use the arrow keys to select Send money.
Verify visually that no blue ring briefly appears on the FAB button.

For iOS/native, Android/native, iOS/Safari, and Android/Chrome:

Navigate to a chat.
Tap on the Actions button.
Tap above the actions menu to dismiss it.
Verify visually that no blue ring exists on the Actions button.
Tap on the Call button.
Tap above the call menu to dismiss it.
Verify visually that no blue ring exists on the Actions button.
Tap on the Emoji button.
Tap an emoji.
Verify visually that no blue ring briefly appears on the Emoji button.
Close the chat and tap on the FAB.
Tap outside the menu to dismiss it.
Verify visually that no blue ring exists on the FAB button.

Note: on Android/Chrome in the device we used for testing, the focus ring
was orange instead of blue.

Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

issue11433-MacOS-Chrome.mp4

Mobile Web - Chrome

issue11433-Android-Chrome.mp4

Mobile Web - Safari

issue11433-iOS-Safari.mp4

Desktop

issue11433-MacOS-Desktop.mp4

iOS

Android

Remove focus from the chat action button, emoji picker, and the video chat button immediately after the buttons are clicked/tapped.

github-actions · 2022-10-24T15:28:54Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

MarkCSmith · 2022-10-24T18:48:13Z

I have read the CLA Document and I hereby sign the CLA

thesahindia · 2022-10-25T15:16:54Z

Hey @MarkCSmith thanks for the changes but can you also include fab menu? Because it's also reproducible there.

MarkCSmith · 2022-10-26T15:15:24Z

Hey @MarkCSmith thanks for the changes but can you also include fab menu? Because it's also reproducible there.

Done (via a second commit).

src/pages/home/report/ReportActionCompose.js

src/components/VideoChatButtonAndMenu/BaseVideoChatButtonAndMenu.js

src/components/FAB/FAB.js

src/components/EmojiPicker/EmojiPicker.js

thesahindia · 2022-10-27T20:52:03Z

@MarkCSmith, please address this as well -

The proposal link should be prefixed with PROPOSAL (at "Fixed Issues" section)
Please attach videos for desktop and web, we don't have this issue at other platforms so screenshots are fine for them.

MarkCSmith · 2022-10-28T15:55:22Z

@MarkCSmith, please address this as well -

1. The proposal link should be prefixed with PROPOSAL (at "Fixed Issues" section)
2. Please attach videos for desktop and web, we don't have this issue at other platforms so screenshots are fine for them.

@thesahindia Thanks for your feedback. Done!

thesahindia · 2022-10-28T17:58:52Z

Thanks for the changes! Everything looks good but we got some conflicts. Please pull the latest changes and resolve them and we will be good to go 🚀.

MarkCSmith · 2022-10-28T18:24:09Z

Thanks for the changes! Everything looks good but we got some conflicts. Please pull the latest changes and resolve them and we will be good to go 🚀.

@thesahindia Should I create a new PR, or what is the best way to publish a rebased branch?

thesahindia · 2022-10-28T19:12:14Z

@thesahindia Should I create a new PR, or what is the best way to publish a rebased branch?

You can pull the changes using git pull origin main, then resolve the conflicts and just commit and push it. Just make sure you fetch the latest changes at main branch of your forked repo

MarkCSmith · 2022-10-31T15:20:48Z

@thesahindia Should I create a new PR, or what is the best way to publish a rebased branch?

You can pull the changes using git pull origin main, then resolve the conflicts and just commit and push it. Just make sure you fetch the latest changes at main branch of your forked repo

Thanks! Hopefully I did things correctly.

roryabraham · 2022-10-31T16:55:15Z

@MarkCSmith this PR is unmergable as-is because it contains one unsigned commit. Please try this command to retroactively sign the commits on this PR:

git -c core-editor=true rebase -i --exec 'git commit --amend --no-edit -n -S' a93beb77befef329810af5068caef370f5eb0784

Then force-push to this branch with git push --force origin issue11433-blue-outline

thesahindia · 2022-10-31T17:15:02Z

Changes looks good. @MarkCSmith, please address #12090 (comment) (sorry for not catching this earlier)

Screenshots

Web

Screen.Recording.2022-10-28.at.1.40.30.AM.mov

Mobile Web - Chrome

Screen.Recording.2022-10-28.at.1.52.33.AM.mov

Mobile Web - Safari

Screen.Recording.2022-10-28.at.1.49.10.AM.mov

Desktop

Screen.Recording.2022-10-28.at.1.38.53.AM.mov

iOS

Screen.Recording.2022-10-28.at.1.47.33.AM.mov

Android

Screen.Recording.2022-10-28.at.2.06.22.AM.mov

Also fix this problem for the FAB.

Avoid inline comments.

…1433-blue-outline

MarkCSmith · 2022-10-31T19:59:51Z

@MarkCSmith this PR is unmergable as-is because it contains one unsigned commit. Please try this command to retroactively sign the commits on this PR:
git -c core-editor=true rebase -i --exec 'git commit --amend --no-edit -n -S' a93beb77befef329810af5068caef370f5eb0784

Thanks. The above command is asking me to manually resolve dozens of conflicts (a painful and potentially error-prone process). But I was able to undo the merge to current main, run the above command to add the missing signature, and then re-do the merge to main. I will force push the revised branch.

roryabraham

Sorry for the review delay

roryabraham · 2022-11-12T20:47:14Z

Unfortunately this PR now has conflicts that need to be resolved. I apologize for the inconvenience @MarkCSmith

…1433-blue-outline

thesahindia · 2022-11-15T21:32:43Z

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

thesahindia · 2022-11-15T21:34:23Z

Not sure, why the PR Reviewer Checklist test is failing.

roryabraham · 2022-11-15T21:35:30Z

@thesahindia it's probably related to #12429

roryabraham · 2022-11-15T21:39:14Z

@thesahindia try following the instructions in this comment in this PR

thesahindia · 2022-11-15T21:52:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2022-10-28.at.1.40.30.AM.mov

Mobile Web - Chrome

Screen.Recording.2022-10-28.at.1.52.33.AM.mov

Mobile Web - Safari

Screen.Recording.2022-10-28.at.1.49.10.AM.mov

Desktop

Screen.Recording.2022-10-28.at.1.38.53.AM.mov

iOS

Screen.Recording.2022-10-28.at.1.47.33.AM.mov

Android

Screen.Recording.2022-10-28.at.2.06.22.AM.mov

melvin-bot · 2022-11-15T21:53:41Z

@roryabraham looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2022-11-15T21:57:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-11-17T08:25:21Z

🚀 Deployed to staging by @roryabraham in version: 1.2.29-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-11-22T17:05:39Z

🚀 Deployed to production by @AndrewGable in version: 1.2.29-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: blue outline appears for a moment on buttons

a93beb7

Remove focus from the chat action button, emoji picker, and the video chat button immediately after the buttons are clicked/tapped.

MarkCSmith requested a review from a team as a code owner October 24, 2022 15:28

melvin-bot bot requested review from roryabraham and thesahindia and removed request for a team October 24, 2022 15:28

thesahindia suggested changes Oct 27, 2022

View reviewed changes

roryabraham requested a review from thesahindia October 31, 2022 16:50

roryabraham mentioned this pull request Oct 31, 2022

[HOLD for payment 2022-11-29] [$250] Chat - Blue outline appears for a moment on + icon, selecting an option from popover menu and hit enter using keyboard Reported by @Puneet-here #11433

Closed

MarkCSmith added 3 commits October 31, 2022 15:42

fix: blue outline appears for a moment on buttons

d79e643

Also fix this problem for the FAB.

fix: blue outline appears for a moment on buttons

2b7cda4

Avoid inline comments.

Merge branch 'main' of github.com:MarkCSmith/ExpensifyApp into issue1…

ce1aefe

…1433-blue-outline

MarkCSmith force-pushed the issue11433-blue-outline branch from 47b649b to ce1aefe Compare October 31, 2022 20:02

This comment was marked as outdated.

Sign in to view

thesahindia previously approved these changes Oct 31, 2022

View reviewed changes

roryabraham previously approved these changes Nov 12, 2022

View reviewed changes

Merge branch 'main' of github.com:MarkCSmith/ExpensifyApp into issue1…

b798307

…1433-blue-outline

MarkCSmith dismissed stale reviews from roryabraham and thesahindia via b798307 November 15, 2022 16:29

thesahindia approved these changes Nov 15, 2022

View reviewed changes

roryabraham approved these changes Nov 15, 2022

View reviewed changes

thesahindia approved these changes Nov 15, 2022

View reviewed changes

roryabraham merged commit 210903a into Expensify:main Nov 15, 2022

melvin-bot bot added the Emergency label Nov 15, 2022

OSBotify mentioned this pull request Nov 17, 2022

Deploy Checklist: New Expensify 2022-11-17 #12812

Closed

35 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: blue outline appears for a moment on buttons #12090

fix: blue outline appears for a moment on buttons #12090

MarkCSmith commented Oct 24, 2022 •

edited

Loading

github-actions bot commented Oct 24, 2022 •

edited

Loading

MarkCSmith commented Oct 24, 2022

thesahindia commented Oct 25, 2022

MarkCSmith commented Oct 26, 2022

thesahindia commented Oct 27, 2022

MarkCSmith commented Oct 28, 2022 •

edited

Loading

thesahindia commented Oct 28, 2022

MarkCSmith commented Oct 28, 2022

thesahindia commented Oct 28, 2022

MarkCSmith commented Oct 31, 2022

roryabraham commented Oct 31, 2022

thesahindia commented Oct 31, 2022

MarkCSmith commented Oct 31, 2022

This comment was marked as outdated.

roryabraham left a comment

roryabraham commented Nov 12, 2022

thesahindia commented Nov 15, 2022

thesahindia commented Nov 15, 2022

roryabraham commented Nov 15, 2022

roryabraham commented Nov 15, 2022

thesahindia commented Nov 15, 2022

melvin-bot bot commented Nov 15, 2022

OSBotify commented Nov 15, 2022

OSBotify commented Nov 17, 2022

OSBotify commented Nov 22, 2022

fix: blue outline appears for a moment on buttons #12090

fix: blue outline appears for a moment on buttons #12090

Conversation

MarkCSmith commented Oct 24, 2022 • edited Loading

Details

Fixed Issues

Tests

QA Steps

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

github-actions bot commented Oct 24, 2022 • edited Loading

MarkCSmith commented Oct 24, 2022

thesahindia commented Oct 25, 2022

MarkCSmith commented Oct 26, 2022

thesahindia commented Oct 27, 2022

MarkCSmith commented Oct 28, 2022 • edited Loading

thesahindia commented Oct 28, 2022

MarkCSmith commented Oct 28, 2022

thesahindia commented Oct 28, 2022

MarkCSmith commented Oct 31, 2022

roryabraham commented Oct 31, 2022

thesahindia commented Oct 31, 2022

MarkCSmith commented Oct 31, 2022

This comment was marked as outdated.

roryabraham left a comment

Choose a reason for hiding this comment

roryabraham commented Nov 12, 2022

thesahindia commented Nov 15, 2022

thesahindia commented Nov 15, 2022

roryabraham commented Nov 15, 2022

roryabraham commented Nov 15, 2022

thesahindia commented Nov 15, 2022

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Nov 15, 2022

OSBotify commented Nov 15, 2022

OSBotify commented Nov 17, 2022

OSBotify commented Nov 22, 2022

MarkCSmith commented Oct 24, 2022 •

edited

Loading

github-actions bot commented Oct 24, 2022 •

edited

Loading

MarkCSmith commented Oct 28, 2022 •

edited

Loading