[HOLD for payment 2023-03-28] Make sure attachments are fetched from appropriate servers

[mountiny]

Coming from here

Problem

Chat attachments are loaded from API not matching the client environment. So you can be on Staging app but the chat attachment is loaded from production

Why is it important

Environment inconsistency can make it harder to find regressions and can introduce some unexpected ones in one deployment cycle

Solution

Make sure the production App loads the chat attachments from production api and staging from appropriate api server. cc @kidroca

[MelvinBot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

@kidroca Do you want to get assigned to this and work hourly for this issue?

[kidroca]

@kidroca Do you want to get assigned to this and work hourly for this issue?

Yes!

[zanyrenney]

Chatted to @mountiny in DM - I can unassign as kidroca has their own contract with expensify for bug fixes!

[kidroca]

Found another discrepancy here:

Right now on DEV the staging toggle defaults to ON

on DEV this toggle does not have any effect - we're always using the PROD server

The Use Staging Server toggle only works on staging, where you can use it to toggle between the prod and the staging server

I think if the toggle does not work to change the underlying api (on DEV) we should not render it at all, or at least render it disabled

[mountiny]

I think if the toggle does not work to change the underlying api (on DEV) we should not render it at all, or at least render it disabled

This is correct and it is expected although I agree it is misleading.

On dev you change contents of .env file to change the API. I think we should hide the toggle on dev personally

[kidroca]

PR is ready for review:

• Refactor: Create libs/ApiUtils #15178

[MelvinBot]

@kidroca Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kidroca]

PR ready for review

• Refactor: Create libs/ApiUtils #15178

But we found that it has overlapping with another PR so we started a discussion there

• Use app environment to determine olddot URL and update staging env #14944

[MelvinBot]

@kidroca Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@kidroca Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kidroca]

The PR was on hold, but is unblocked now:

• Refactor: Create libs/ApiUtils #15178

I have to address some minor items from the latest review

[MelvinBot]

@kidroca Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kidroca]

PR is ready and reviewed

• Refactor: Create libs/ApiUtils #15178

@mountiny I think some minor changes dismissed your approval

[s77rt]

• The PR that introduced the bug has been identified: I think this was implemented this way from the start
• The offending PR has been commented on: n/a ^
• A discussion in #expensify-bugs has been started: Given this is not a regression, should we open a discussion? @mountiny @kidroca

---

Regression Test Proposal

1. Login using https://staging.new.expensify.com/
2. Open any chat and send an attachment
3. Verify that the attachment url starts with https://staging.new.expensify.com/chat-attachments/
4. Login using https://new.expensify.com/
5. Open same chat
6. Verify that the attachment url starts with https://new.expensify.com/chat-attachments/

[mountiny]

Looking good, thanks! @zanyrenney would you be able to pay $1000 to @s77rt please?

[mountiny]

Bumping this one @zanyrenney

[mountiny]

Zany is ooo so asking internally for someone to help complete the payment here.

[dylanexpensify]

On it - @s77rt here's job to apply to! https://www.upwork.com/jobs/~014a7129dead94e399

[s77rt]

@dylanexpensify Applied.

[dylanexpensify]

offer sent!!

[s77rt]

Accepted

[dylanexpensify]

Paid and contract ended! RT issue here! Thanks for playing y'all!

[lanitochka17]

Issue reproducible with Windows10/Chrome

Recording.2884.mp4

[zanyrenney]

hmm @kidroca could you review please and check why this is still happening? cc. @mountiny @s77rt

Thanks!

[zanyrenney]

didn't mean to close the issue.

[s77rt]

@lanitochka17 @zanyrenney I think this is working as expected, the url is pointing to the staging server. Please note that the url can either be www.expensify.com or staging.exepnsify.com depending on the environment but never staging.new.expensify.com nor new.expensify.com.

[kidroca]

@zanyrenney

hmm @kidroca could you review please and check why this is still happening? cc. @mountiny @s77rt

What @s77rt said in their reply is correct (thank you ❤️):

@lanitochka17 @zanyrenney I think this is working as expected, the url is pointing to the staging server. Please note that the url can either be www.expensify.com or staging.exepnsify.com depending on the environment

@lanitochka17 when you are on staging.new.expensify.com attachments should be served from staging.expensify.com exactly how it happens in the video you shared: #15087 (comment)

The actual bug we fixed here was that staging attachments were served from www.expensify.com and not from staging.expensify.com and vice versa

@zanyrenney I think we can close this one

[zanyrenney]

Awesome. Thank you @kidroca for the detailed explanation here. Closing this out.