[HOLD for payment 2023-03-16] Web - Login screen - Language drop down options are too much to the left and cut by rounded corners

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Click Language drop down to expand options

Expected Result:

Language options should be well displayed
Repro in 24 inch monitor, not repro on 15 inch laptop

Actual Result:

Language drop down options are too much shifted to the left and cut by rounded corners

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.78.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5962742_video_11__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ad6951ff75c45479
• Upwork Job ID: 1632700872910655488
• Last Price Increase: 2023-03-06

[MelvinBot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01ad6951ff75c45479

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

[s77rt]

@grgia Am I supposed to review the linked PRs? If so please assign me there. Thanks!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.80-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Local Picker Background for Windows  #15675

If no regressions arise, payment will be issued on 2023-03-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt / @grgia] The PR that introduced the bug has been identified. Link to the PR:
  being cut by rounded corners: 3770 multi language improvements #4134
  being too much to the left: Text & Dropdown Input Styles #12447

• [@s77rt / @grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

• [@s77rt / @grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

• [@tjferriss] Determine if we should create a regression test for the bug.

• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again.

• [@tjferriss] Review the proposed regression test steps and location.

• [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/268363

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[s77rt]

• The PR that introduced the bug has been identified:
  • being cut by rounded corners: 3770 multi language improvements #4134
  • being too much to the left: Text & Dropdown Input Styles #12447
• The offending PR has been commented on: I'm not sure if we can blame any of those PR, the first seems intentional and the second did the right thing and the bug could not have been caught since it's only reproducible on Windows. cc @grgia
• A discussion in #expensify-bugs has been started: cc @grgia Can you work on this as I'm not sure if it's worth it

---

@tjferriss Please tag me if a regression test is required.

[tjferriss]

@s77rt, In general, it's always best to assume test steps are needed. As there are PRs that introduced a bug, it sounds like we'll want to ensure this doesn't happen again. Please propose the steps, you don't need to recommend where in TestRail the test case should be included or updated though (per a post earlier today in #contributor-plus)

Also, can you please apply to the job in Upworks for payment? #15653

[s77rt]

Regression Test Proposal

1. Open App (without logging in)
2. Scroll down to language picker and open it
3. Verify that the options are displayed correctly and not being cut by rounded corners

---

@tjferriss Sure, no problem. regression steps ^
I have applied on Upwrok as well 👍

[tjferriss]

I just hired @s77rt and created the regression test issue. Once we hit 3/16 I'll process the payment.

[grgia]

@tjferriss has payment been processed?

[situchan]

I think payment is handled in #15676 since it's same PR

[joekaufmanexpensify]

@tjferriss actually hired @s77rt for the PR that fixed the bug in this issue, and the one I was assigned to above. So I held off on hiring them in mine. We chatted 1:1 and TJ was going to pay them here, but I don't think payment has been issued yet.

Re-opening for now, so we can pay $s77rt for their PR review!

[tjferriss]

My mistake, payment has now been made to @s77rt