[HOLD for payment 2023-03-16] Locale Picker Background is incorrect on windows (DEV)

[grgia]

The Locale Picker Background should match app background on windows. This is occurring on DEV only awaiting staging release.

https://expensify.slack.com/archives/C049HHMV9SM/p1678032527107149

Reported by @situchan

This is ONLY on windows web.
Not MacOS/Android/IOS

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01806153de5b609fd1
• Upwork Job ID: 1632693916961329152
• Last Price Increase: 2023-03-06

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01806153de5b609fd1

[MelvinBot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

[situchan]

In this issue, I also suggest to remove border radius in order to fix #15653, which was added very long time ago. cc: @tjferriss

App/src/styles/styles.js

Line 571 in 228a29b

borderRadius: variables.componentBorderRadius,

App/src/styles/styles.js

Line 596 in 228a29b

borderRadius: variables.componentBorderRadius,

App/src/styles/styles.js

Line 612 in 228a29b

borderRadius: variables.componentBorderRadius,

[joekaufmanexpensify]

Looks like the PR for this one is already merged. I'll stay assigned for now as we'll need to pay out the reporting bonus and C+ review payment after the PR is deployed.

[grgia]

@joekaufmanexpensify could you handle payment tracking for this issue as well?
#15653

@s77rt did one C+ review for the PR where we fixed both bugs

[joekaufmanexpensify]

Sure! Just to make sure my understanding is correct though, this one PR was used to fix two different bugs, right? If so, I think it'd just be one payment for C+ reviewing the one PR.

[situchan]

@grgia am I also eligible for compensation for providing solutions on both GHs and they were used in PR?

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.80-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Local Picker Background for Windows  #15675

If no regressions arise, payment will be issued on 2023-03-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@grgia] The PR that introduced the bug has been identified. Link to the PR: Add SEO Footer to New Dot (All Platforms) #15022
• [@grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A - We don't test for windows.
• [@grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - We don't test for windows.
• [@joekaufmanexpensify] Determine if we should create a regression test for the bug.
• [@grgia] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Review the proposed regression test steps and location.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[joekaufmanexpensify]

Almost ready to issue payment here. 7 day period is up tomorrow. @grgia mind handling the BZ steps related to the PR that introduced the bug when you have a chance?

[joekaufmanexpensify]

We need to issue the following payments:

• @s77rt - $1,000 for C+ review.
• @situchan - $250 for reporting the bug.

[joekaufmanexpensify]

@s77rt offer sent for $1000!

[joekaufmanexpensify]

@situchan offer sent for $250!

[situchan]

@grgia am I also eligible for compensation for providing solutions on both GHs and they were used in PR?

@grgia any chance to review this? I also helped with testing on Windows on behalf of C+ in PR review, which is the main platform having this issue.

[joekaufmanexpensify]

Actually @s77rt, I see @tjferriss already hired you for this PR review in #15653 (comment) , as the PR in that issue also fixed the bug here. So went ahead and withdrew the offer for this issue.

[joekaufmanexpensify]

@situchan , generally we only provide compensation for proposals when the issue in question is marked as external. For those issues, a proposal will be formally reviewed, and then you'll be hired for a job. LMK if you have any other questions!

[situchan]

I have no questions according to contributing guideline. But there are some edge cases.
This is not the first time for me. Similar cases in the past:
#13508 (comment)
#13509 (comment)

The reason why I ask here:

• helped 2 issues at the same time
• helped PR test on target platform with this issue

[joekaufmanexpensify]

We definitely appreciate your help on the issue! I reviewed the Slack thread you linked, and I agree with Ionatan's sentiment here. We may have gone outside of our normal process to provide compensation for assistance on an internal issue in the past, but that isn't part of the standard process, which we generally try to adhere to.

[joekaufmanexpensify]

We discussed this internally, and we're going to stick with $250 for this one. LMK once you've accepted the job, and I'll work on issuing payment!

[situchan]

Thanks for confirmation. I am following team's decision as always.
Hope that rule would be applied to all similar cases for all contributors to be consistent, so no one has doubt.

[joekaufmanexpensify]

Thanks! Okay, all that's left here before we can issue payment and close this out is for @grgia to complete the BZ steps related to the PR that introduced the regression.

[joekaufmanexpensify]

Not overdue.

[joekaufmanexpensify]

@grgia bump for whenever you have a chance to complete the engineering BZ steps here! That's the last step before we can pay the reporting bonus here and close this out.

[grgia]

@joekaufmanexpensify thanks for the bump, I'll get this closed today

[joekaufmanexpensify]

Of course, and great, ty!

[grgia]

@joekaufmanexpensify done!

[joekaufmanexpensify]

Great, thanks Georgia!

[joekaufmanexpensify]

@situchan $250 sent and job closed!

[joekaufmanexpensify]

Closed upwork job.

[joekaufmanexpensify]

Okay, bug is fixed, BZ checklist is complete, and payment is issued. Closing as this is all set. Thanks everyone!