[HOLD for payment 2023-04-26] Login - "You appear to be offline" is duplicated on password page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open NewDot Android app (or go to https://staging.new.expensify.com/)
2. Input new email
3. Click password link from email
4. Password page is displayed
5. Go offline

Expected Result:

"You appear to be offline" should be displayed once

Actual Result:

"You appear to be offline" is duplicated on password page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.81.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5970827_video_2023-03-09_23-38-44.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ad53adcee6f4f460
• Upwork Job ID: 1636364726395617280
• Last Price Increase: 2023-03-16

[MelvinBot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@bfitzexpensify Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01ad53adcee6f4f460

[MelvinBot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[MelvinBot]

Triggered auto assignment to @thienlnam (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[PrashantMangukiya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On set password page "You appear to be offline" shows two times.

What is the root cause of that problem?

Within SetPasswordPage.js page, OfflineIndicator component used at line 124 So offline indicator shows next to set password button. Also on this page SignInPageLayout component used at line 99

App/src/pages/SetPasswordPage.js

Lines 98 to 126 in 657b439

	<SafeAreaView style={[styles.signInPage]}>
	<SignInPageLayout
	shouldShowWelcomeText
	welcomeText={this.props.translate('setPasswordPage.passwordFormTitle')}
	>
	<FormSubmit onSubmit={this.validateAndSubmitForm}>
	<View style={[styles.mb4]}>
	<NewPasswordForm
	password={this.state.password}
	updatePassword={password => this.setState({password})}
	updateIsFormValid={isValid => this.setState({isFormValid: isValid})}
	/>
	</View>
	<View>
	<FormAlertWithSubmitButton
	buttonText={buttonText}
	isLoading={this.props.account.isLoading}
	onSubmit={this.validateAndSubmitForm}
	containerStyles={[styles.mb2, styles.mh0]}
	message={error}
	isAlertVisible={!_.isEmpty(error)}
	isDisabled={!this.state.isFormValid}
	disablePressOnEnter
	/>
	</View>
	</FormSubmit>
	<OfflineIndicator containerStyles={[styles.mv1]} />
	</SignInPageLayout>
	</SafeAreaView>

Eventually SignInPageLayout component uses SignInPageContent as shown below:

App/src/pages/signin/SignInPageLayout/index.js

Lines 45 to 50 in 09a79bc

	<SignInPageContent
	welcomeText={props.welcomeText}
	shouldShowWelcomeText={props.shouldShowWelcomeText}
	>
	{props.children}
	</SignInPageContent>

App/src/pages/signin/SignInPageLayout/index.js

Lines 65 to 70 in 09a79bc

	<SignInPageContent
	welcomeText={props.welcomeText}
	shouldShowWelcomeText={props.shouldShowWelcomeText}
	>
	{props.children}
	</SignInPageContent>

Eventually SignInPageContent.js also uses OfflineIndicator at line 71

App/src/pages/signin/SignInPageLayout/SignInPageContent.js

Lines 70 to 72 in 09a79bc

	<View style={[styles.mb5, styles.signInPageWelcomeTextContainer, styles.alignSelfCenter]}>
	<OfflineIndicator style={[styles.m0, styles.pl0, styles.alignItemsStart]} />
	</View>

So offline indicator is displayed two times i.e. from SetPasswordPage.js and from SignInPageContent.js So this is the root cause of the problem.

What changes do you think we should make in order to solve the problem?

We have to remove Offline indicator from SetPasswordPage.js component at line 124, so offline indicator display only once via SignInPageContent.js component.

App/src/pages/SetPasswordPage.js

Line 124 in 657b439

<OfflineIndicator containerStyles={[styles.mv1]} />

What alternative solutions did you explore? (Optional)

None

[thienlnam]

This must have been a regression, let's try to find the PR that caused it in the recent deploy

[Pujan92]

@thienlnam seems this PR causes a regression where @grgia might forgot to remove OfflineIndicator from SetPassword page.

[kaushiktd]

Please re-state the problem that we are trying to solve in this issue.
Login - "You appear to be offline" is duplicated on password page

What is the root cause of that problem?
OfflineIndicator component used at line 124 in SetPasswordPage.js page and also on this page SignInPageLayout component used at line 99. this is the root cause for this problem.

What changes do you think we should make in order to solve the problem?
You need to remove Offline indicator from SetPasswordPage.js component at line 124

[thienlnam]

@grgia Do you want to take this regression / or would you like to just let it go through the regular process

[PrashantMangukiya]

@thienlnam I can take this as priority and submit PR asap. Please let me know if need anything from my side. Here is my proposal #15807 (comment)

[MelvinBot]

@thienlnam @grgia @bfitzexpensify @thesahindia this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[grgia]

PR up, just need to do screenshots tomorrow

[MelvinBot]

@thienlnam, @grgia, @bfitzexpensify, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@thienlnam, @grgia, @bfitzexpensify, @thesahindia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[MelvinBot]

@thienlnam, @grgia, @bfitzexpensify, @thesahindia 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[MelvinBot]

@thienlnam, @grgia, @bfitzexpensify, @thesahindia 12 days overdue. Walking. Toward. The. Light...

[MelvinBot]

@thienlnam, @grgia, @bfitzexpensify, @thesahindia 12 days overdue. Walking. Toward. The. Light...

[thienlnam]

Looks like PR is still in progress

[grgia]

Fixed emulators, taking screenshots today

[MelvinBot]

@thienlnam, @grgia, @bfitzexpensify, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.1-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove duplicate offline indicator from set password page #16457

If no regressions arise, payment will be issued on 2023-04-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@bfitzexpensify] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[thesahindia]

Hey @bfitzexpensify, this was a regression from #15022, which was reviewed by me (so no compensation on this) Also I think we should skip the regression test on this since the page will be removed soon and we don't need a specific test case for such bugs.

P.S. Can you handle payment for #15022 instead? There wasn't an E/App ticket so I forgot about the payment on it.

[bfitzexpensify]

Yup! Offer sent on Upwork

[thesahindia]

Ok so there were multiple small regressions. Let me summarize.

1. [HOLD for payment 2023-04-14] Footer link "About Expensify" opening jobs page #16430

I couldn't catch the wrong url, so there will be 50% penalty

2. [HOLD for payment 2023-03-16] Locale Picker Background is incorrect on windows (DEV) #15676

This was a window issue that couldn't have been caught by following the checklist. So according to the C+ guidelines there should be no penalty for this.

3. [HOLD for payment 2023-04-26] Login - "You appear to be offline" is duplicated on password page #15807 (current issue)

I couldn't catch two offline indicators on set password page, so there will be 50% penalty

So I think the compensation should be $250

[thesahindia]

@bfitzexpensify, I have accepted the offer. The current job price is $1000 but because of regression penalty it needs to be $250. ( Please see the above comment)

[bfitzexpensify]

Sure thing. Contract paid out and ended. Think we're all done here now