[$1000] [HOLD for payment 2023-04-03] [HOLD for payment 2023-03-31] The display name of the user with long name is shown in a weird way and the text comes down the top menu

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open chrome web and go to any chat with a user that has long name or email / group chat
2. Notice that the display name comes down the top menu and is shown in a weird way

Expected Result:

The display name should not come down from the top menu

Actual Result:

The display name comes down from the top menu and looks weird

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.88-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679413417224689

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019466d38a4555a17e
• Upwork Job ID: 1641845822557196288
• Last Price Increase: 2023-03-31

[MelvinBot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[alex-mechler]

@tienifr can you comment here so I can assign you?

[tienifr]

Yes. I'm here

[joekaufmanexpensify]

Seems like we're already on our way to fixing this, but LMK if there's anything I can help with!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix/15438: regression test #16397

If no regressions arise, payment will be issued on 2023-03-31. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alex-mechler] The PR that introduced the bug has been identified. Link to the PR:
• [@alex-mechler] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@alex-mechler] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@joekaufmanexpensify] Determine if we should create a regression test for this bug.
• [@tienifr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[tienifr]

Regression Test Proposal

Bug: The display name of the user with long name is shown in a weird way and the text comes down the top menu

Proposed Test Steps:

1. Open mWeb or mobile app
2. Go to any chat with a user that has long name or email / group chat
3. Verify that the display name display correctly and don't come down from the top menu

Do we 👍 or 👎

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.89-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix/15438: regression test #16397

If no regressions arise, payment will be issued on 2023-04-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alex-mechler] The PR that introduced the bug has been identified. Link to the PR: fix 15438 maintain white space in display name #15646
• [@alex-mechler] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix 15438 maintain white space in display name #15646 (comment)
• [@alex-mechler] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a was a regression caught in the regression tests
• [@joekaufmanexpensify] Determine if we should create a regression test for this bug.
• [@tienifr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/272669

[joekaufmanexpensify]

Not overdue.

[joekaufmanexpensify]

This is a pretty niche bug, so don't think we need a regression test here. Curious if you agree @alex-mechler @tienifr ?

[alex-mechler]

Its fairly niche, but at the same time there is a lot of places in product where this could happen. I think a regression test here would be a good call, to ensure consistency of the display name across the product.

[joekaufmanexpensify]

That's fair! I'm good to proceed with making one.

[joekaufmanexpensify]

@tienifr mind proposing the steps when you get a chance?

[tienifr]

@joekaufmanexpensify I just posted the regression test, could you help to check?

[joekaufmanexpensify]

Ah, sorry I missed that above. Yep, that looks good to me! Will go ahead and make the issue for that test now.

[joekaufmanexpensify]

Linked test issue above.

[joekaufmanexpensify]

@tienifr as an FYI, since the bug fixed in this issue was fixing a regression introduced in one of your other PRs, we won't issue new payment in this issue. LMK if you have any questions!

[joekaufmanexpensify]

No C+ review here, so we just need to pay @priya-zha $250 for reporting this.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~019466d38a4555a17e

[MelvinBot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[MelvinBot]

Current assignee @alex-mechler is eligible for the External assigner, not assigning anyone new.

[joekaufmanexpensify]

@s77rt un-assigning as this one's all set. Just added external to create upwork job for paying reporting bonus.

[joekaufmanexpensify]

@priya-zha sent offer for $250!

[priya-zha]

@joekaufmanexpensify I've accepted the offer and submitted the work. Thank you

[joekaufmanexpensify]

@priya-zha $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!