Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 15438 maintain white space in display name #15646

Merged
merged 15 commits into from
Mar 20, 2023
Merged

fix 15438 maintain white space in display name #15646

merged 15 commits into from
Mar 20, 2023

Conversation

tienifr
Copy link
Contributor

@tienifr tienifr commented Mar 3, 2023 •
edited
Loading

Details

Maintain whitespace when showing display name

Fixed Issues

$ #15438
PROPOSAL: #15438 (comment)

Tests

  1. Open the app
  2. Navigate to Settings > Profile
  3. Click on Display Name
  4. In the First Name field enter a string separated by a bunch of spaces (eg : Daraksha Test.)
  5. Save
  6. Verify the display name is correct within white spaces on setting page, profile page, LHN, report header, report item header, participant local time, IOU message, new chat page, new group page, send money page, request money page, detail page
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Open the app
  2. Navigate to Settings > Profile
  3. Click on Display Name
  4. In the First Name field enter a string separated by a bunch of spaces (eg : Daraksha Test.)
  5. Save
  6. Verify the display name is correct within white spaces on setting page, profile page, LHN, report header, report item header, participant local time, IOU message, new chat page, new group page, send money page, request money page, detail page
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web 1. setting page Screen Shot 2023-03-04 at 00 39 42
  1. profile page
Screen Shot 2023-03-04 at 00 40 14
  1. LHN
Screen Shot 2023-03-04 at 00 40 42
  1. report header
Screen Shot 2023-03-04 at 00 40 54
  1. report item header
Screen Shot 2023-03-04 at 00 41 10
  1. participant local time
Screen Shot 2023-03-04 at 00 41 24
  1. IOU message
Screen Shot 2023-03-04 at 00 42 13
  1. new chat page
Screen Shot 2023-03-04 at 00 42 36
  1. new group page
Screen Shot 2023-03-04 at 00 42 58
  1. send money page
Screen Shot 2023-03-04 at 00 43 30
  1. request money page
Screen Shot 2023-03-04 at 00 43 51
  1. detail page
Screen Shot 2023-03-04 at 00 44 06
  1. Last Mesage in LHN
Screen Shot 2023-03-06 at 17 20 53
  1. Subtitle in header of workspace pages
Screen Shot 2023-03-07 at 09 44 59
  1. Workspace name in LHN
Screen Shot 2023-03-07 at 10 30 12 Screen Shot 2023-03-09 at 10 36 50
  1. Workspace name in detail workspace chat
Screen Shot 2023-03-07 at 10 30 25
  1. Workspace name in settings of workspace chat detail
Screen Shot 2023-03-07 at 10 30 43
Mobile Web - Chrome

  1. setting page
    image

  2. profile page
    image

  3. LHN
    image

  4. report header
    image

  5. report item header
    image

  6. participant local time
    image

  7. IOU message
    image

  8. new chat page
    image

  9. new group page
    image

  10. send money page
    image

  11. request money page
    image

  12. detail page
    image

  13. Last Mesag

Screen Shot 2023-03-06 at 17 24 37 e in LHN
  1. Subtitle in header of workspace pages
Screen Shot 2023-03-07 at 09 45 06
  1. Workspace name in LHN
Screen Shot 2023-03-07 at 10 37 36 Screen Shot 2023-03-09 at 10 37 07
  1. Workspace name in the subtitle of report
Screen Shot 2023-03-07 at 10 37 44 Screen Shot 2023-03-09 at 10 37 16
  1. Workspace name in detail workspace chat
Screen Shot 2023-03-07 at 10 37 51
  1. Workspace name in settings of workspace chat detail
Screen Shot 2023-03-07 at 10 37 58
Mobile Web - Safari

  1. setting page
    image

  2. profile page
    image

  3. LHN
    image

  4. report header
    image

  5. report item header
    image

  6. participant local time
    image

  7. IOU message
    image

  8. new chat page
    image

  9. new group page
    image

  10. send money page
    image

  11. request money page
    image

  12. detail page
    image

  13. Last Mesage in LHN

Screen Shot 2023-03-06 at 17 24 37
  1. Subtitle in header of workspace pages
Screen Shot 2023-03-07 at 09 45 30
  1. Subtitle in header of workspace pages
Screen Shot 2023-03-07 at 09 44 59
  1. Workspace name in LHN
Screen Shot 2023-03-07 at 10 37 36 Screen Shot 2023-03-09 at 10 37 07
  1. Workspace name in the subtitle of report
Screen Shot 2023-03-07 at 10 37 44 Screen Shot 2023-03-09 at 10 37 16
  1. Workspace name in detail workspace chat
Screen Shot 2023-03-07 at 10 37 51
  1. Workspace name in settings of workspace chat detail
Screen Shot 2023-03-07 at 10 37 58
Desktop 1. setting page Screen Shot 2023-03-04 at 00 39 42
  1. profile page
Screen Shot 2023-03-04 at 00 40 14
  1. LHN
Screen Shot 2023-03-04 at 00 40 42
  1. report header
Screen Shot 2023-03-04 at 00 40 54
  1. report item header
Screen Shot 2023-03-04 at 00 41 10
  1. participant local time
Screen Shot 2023-03-04 at 00 41 24
  1. IOU message
Screen Shot 2023-03-04 at 00 42 13
  1. new chat page
Screen Shot 2023-03-04 at 00 42 36
  1. new group page
Screen Shot 2023-03-04 at 00 42 58
  1. send money page
Screen Shot 2023-03-04 at 00 43 30
  1. request money page
Screen Shot 2023-03-04 at 00 43 51
  1. detail page
Screen Shot 2023-03-04 at 00 44 06
  1. Last Mesage in LHN
Screen Shot 2023-03-06 at 17 20 53
  1. Subtitle in header of workspace pages
Screen Shot 2023-03-07 at 09 44 59
  1. Workspace name in LHN
Screen Shot 2023-03-07 at 10 30 12 Screen Shot 2023-03-09 at 10 36 50
  1. Workspace name in detail workspace chat
Screen Shot 2023-03-07 at 10 30 25
  1. Workspace name in settings of workspace chat detail
Screen Shot 2023-03-07 at 10 30 43
iOS
  1. setting page
Screen Shot 2023-03-04 at 01 08 50
  1. profile page
Screen Shot 2023-03-04 at 01 09 56
  1. LHN
Screen Shot 2023-03-04 at 01 10 13
  1. report header
Screen Shot 2023-03-04 at 01 10 26
  1. report item header
Screen Shot 2023-03-04 at 01 10 26
  1. participant local time
Screen Shot 2023-03-04 at 01 10 26
  1. IOU message
Screen Shot 2023-03-04 at 01 10 26
  1. new chat page
Screen Shot 2023-03-04 at 01 10 52
  1. new group page
Screen Shot 2023-03-04 at 01 11 07
  1. send money page
Screen Shot 2023-03-04 at 01 11 27
  1. request money page
Screen Shot 2023-03-04 at 01 11 49
  1. detail page
Screen Shot 2023-03-04 at 01 12 01
  1. Last Mesage in LHN
Screen Shot 2023-03-06 at 17 26 28
  1. Subtitle in header of workspace pages
Screen Shot 2023-03-07 at 09 45 06
  1. Workspace name in LHN
Screen Shot 2023-03-07 at 10 37 36 Screen Shot 2023-03-09 at 10 37 07
  1. Workspace name in the subtitle of report
Screen Shot 2023-03-07 at 10 37 44 Screen Shot 2023-03-09 at 10 37 16
  1. Workspace name in detail workspace chat
Screen Shot 2023-03-07 at 10 37 51
  1. Workspace name in settings of workspace chat detail
Screen Shot 2023-03-07 at 10 37 58
Android
  1. setting page
Screen Shot 2023-03-04 at 01 23 59
  1. profile page
Screen Shot 2023-03-04 at 01 24 11
  1. LHN
Screen Shot 2023-03-04 at 01 24 25
  1. report header
Screen Shot 2023-03-04 at 01 24 39
  1. report item header
Screen Shot 2023-03-04 at 01 24 39
  1. participant local time
Screen Shot 2023-03-04 at 01 24 39
  1. IOU message
Screen Shot 2023-03-04 at 01 24 39
  1. new chat page
Screen Shot 2023-03-04 at 01 25 42
  1. new group page
Screen Shot 2023-03-04 at 01 26 05
  1. send money page
Screen Shot 2023-03-04 at 01 26 27
  1. request money page
Screen Shot 2023-03-04 at 01 26 52
  1. detail page
Screen Shot 2023-03-04 at 01 25 11
  1. Last Mesage in LHN
Screen Shot 2023-03-06 at 17 24 37
  1. Subtitle in header of workspace pages
Screen Shot 2023-03-07 at 09 45 30
  1. Workspace name in LHN
Screen Shot 2023-03-07 at 10 37 36 Screen Shot 2023-03-09 at 10 37 07
  1. Workspace name in the subtitle of report
Screen Shot 2023-03-07 at 10 37 44 Screen Shot 2023-03-09 at 10 37 16
  1. Workspace name in detail workspace chat
Screen Shot 2023-03-07 at 10 37 51
  1. Workspace name in settings of workspace chat detail
Screen Shot 2023-03-07 at 10 37 58

@tienifr tienifr marked this pull request as ready for review March 3, 2023 18:29
@tienifr tienifr requested a review from a team as a code owner March 3, 2023 18:29
@melvin-bot melvin-bot bot requested review from alex-mechler and Santhosh-Sellavel and removed request for a team March 3, 2023 18:29
@MelvinBot
Copy link

@alex-mechler @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@tienifr tienifr mentioned this pull request Mar 3, 2023
Closed
2 tasks
@alex-mechler
Copy link
Contributor

@tienifr Can you make sure to include the fix for the LHN bug that was mentioned here as well? It was a duplicate that was not added to the original issue body on accident

@tienifr
Copy link
Contributor Author

tienifr commented Mar 6, 2023 •
edited
Loading

@alex-mechler I just fixed that and also updated the screenshot. Please help to check

Screen Shot 2023-03-06 at 17 20 53

@Santhosh-Sellavel
Copy link
Collaborator

In Workspace Name space is missing in Header
Screenshot 2023-03-07 at 1 12 23 AM

Santhosh-Sellavel
Santhosh-Sellavel reviewed Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug :#15646 (comment)

@tienifr

This comment was marked as outdated.

Sign in to view
@tienifr
Copy link
Contributor Author

tienifr commented Mar 7, 2023

@Santhosh-Sellavel I just updated the workspace name in all pages, please help to check again

  1. Workspace Setting

Screen Shot 2023-03-07 at 09 44 59

2. LHN

Screen Shot 2023-03-07 at 10 30 12

  1. Detail workspace chat

Screen Shot 2023-03-07 at 10 30 25

  1. Settings in workspace chat detail

Screen Shot 2023-03-07 at 10 30 43

@alex-mechler
Copy link
Contributor

Workspace names are now appearing on two lines if they are extremely long
image

It truncates on main
image

@tienifr
Copy link
Contributor Author

tienifr commented Mar 8, 2023

Hi @alex-mechler Thanks for pointing this out. We have to use white-space: pre on TextInput with numberOfLines prop is 1. I just updated it in all places, please help to check again

Screen Shot 2023-03-08 at 15 59 50

@alex-mechler
Copy link
Contributor

The workspace name is missing extra spaces in the LHN and header
image

@Santhosh-Sellavel
Copy link
Collaborator

This issue really crazy one, we could easily miss a few places if we are not careful. Will continue testing this tomorrow meanwhile please look into the above issue @tienifr, thanks!

cc: @alex-mechler

@tienifr

This comment was marked as outdated.

Sign in to view
@tienifr
Copy link
Contributor Author

tienifr commented Mar 9, 2023 •
edited
Loading

@alex-mechler I just fixed it, please check again
Also updated in the screenshot
In Web

Screen Shot 2023-03-09 at 10 36 50

In Mobile

Screen Shot 2023-03-09 at 10 37 07

Screen Shot 2023-03-09 at 10 37 16

cc @Santhosh-Sellavel

@Santhosh-Sellavel
Copy link
Collaborator

Conflicts @tienifr

@Santhosh-Sellavel
Copy link
Collaborator

Bug: Missed on New room flow

Screenshot 2023-03-10 at 3 38 11 AM

@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented Mar 16, 2023 •
edited
Loading

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screen.Recording.2023-03-20.at.10.53.03.PM.mov
Mobile Web - Chrome
device-2023-03-20-230727.mp4
Mobile Web - Safari
Simulator.Screen.Recording.-.iPhone.14.-.2023-03-20.at.23.02.39.mp4
Desktop
Screen.Recording.2023-03-20.at.10.14.29.PM.mov
iOS
Simulator.Screen.Recording.-.iPhone.14.-.2023-03-20.at.23.00.24.mp4
Android
device-2023-03-20-230405.mp4

@tienifr
Copy link
Contributor Author

tienifr commented Mar 17, 2023

@Santhosh-Sellavel I just fixed that

Screen Shot 2023-03-17 at 09 13 03

@alex-mechler
Copy link
Contributor

Spent some time poking around, didn't see any spots that were immediately missed. @Santhosh-Sellavel Please ping me when this is ready for my review!

@Santhosh-Sellavel
Copy link
Collaborator

Weird I still don't see the space
Screenshot 2023-03-20 at 12 16 41 AM

@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented Mar 19, 2023 •
edited
Loading

Also, issue still not addressed in chat search results

Screen.Recording.2023-03-20.at.12.18.19.AM.mov

@tienifr
Copy link
Contributor Author

tienifr commented Mar 20, 2023 •
edited
Loading

@Santhosh-Sellavel
I just fixed the workspace name in the search result

Screen Shot 2023-03-20 at 13 14 30

We are rendering the workspace name in the Archived room banner as HTML. So I suggest adding white-space: pre to the strong tag. like the lastest commit

If we don't want to apply the white-space attribute to all strong tags, we also can create a new tag with white-space: pre and fontWeight: bold and use it in the Archived room banner. Both solutions work well
Screen Shot 2023-03-20 at 13 14 21

Santhosh-Sellavel
Santhosh-Sellavel suggested changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, just few queries

src/components/HTMLEngineProvider/BaseHTMLEngineProvider.js Show resolved Hide resolved
src/components/ArchivedReportFooter.js Outdated Show resolved Hide resolved
Santhosh-Sellavel
Santhosh-Sellavel approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Tests well!

@Santhosh-Sellavel
Copy link
Collaborator

Over to you @alex-mechler!

alex-mechler
alex-mechler approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@alex-mechler alex-mechler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping with this!

@alex-mechler alex-mechler merged commit 5a0c876 into Expensify:main Mar 20, 2023
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@alex-mechler alex-mechler mentioned this pull request Mar 20, 2023
Closed
6 tasks
@OSBotify OSBotify mentioned this pull request Mar 21, 2023
Closed
28 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/alex-mechler in version: 1.2.88-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/alex-mechler in version: 1.2.88-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@marcaaron
Copy link
Contributor

This PR is causing a regression please see -> #16376

alex-mechler pushed a commit that referenced this pull request Mar 22, 2023
Revert "Merge pull request #15646 from tienifr/fix/15438-maintain-whi…
337309e 
…te-space-in-display-name"

This reverts commit 5a0c876, reversing
changes made to 80ad413.
@alex-mechler alex-mechler mentioned this pull request Mar 22, 2023
Closed
55 tasks
@alex-mechler
Copy link
Contributor

Revert PR #16395

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.2.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.2.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@alex-mechler alex-mechler mentioned this pull request Mar 27, 2023
Closed
6 tasks
@PrashantMangukiya PrashantMangukiya mentioned this pull request Mar 27, 2023
Closed
1 task
@tienifr tienifr mentioned this pull request Mar 29, 2023
Merged
55 tasks
@alex-mechler alex-mechler mentioned this pull request Apr 6, 2023
Closed
6 tasks
@mananjadhav mananjadhav mentioned this pull request Jul 11, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-mechler alex-mechler alex-mechler approved these changes

@Santhosh-Sellavel Santhosh-Sellavel Santhosh-Sellavel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tienifr @MelvinBot @alex-mechler @Santhosh-Sellavel @OSBotify @marcaaron