[HOLD for payment 2023-06-29] [$1000] Find and remove all instances where we show "You appear to be offline" twice in the UI, such that we only show it once.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Sometimes our UI displays "You appear to be offline" two times (e.g. once on the page itself, and once at the footer of the page). Here's an example that we recently fixed - #19187

Here's an example of another that's still not fixed:

1. Switch to offline
2. Create new workspace(if not created)
3. Go to any workspace > bank account
4. Select Connect online with Plaid option

Expected Result:

We should show only one "You appear to be offline" message to the end user.

Actual Result:

We show two "You appear to be offline" messages in the UI, which is redundant.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Yes you can easily ignore.

Platforms:

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.22-0
Reproducible in staging?: y
Reproducible in production?: y

Screen_Recording_20230530_193834_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685455943267169

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c5da0515d1d2e88e
• Upwork Job ID: 1666461948293591040
• Last Price Increase: 2023-06-07

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• two offline message shows in connect bank account page 

What is the root cause of that problem?

• The root cause is when we use <ScreenWrapper> component at parent level we are showing bottom left you appears to be offline on all smallScreenDevice and it will even show if we already have the <FullPageOfflineBlockingView> as we don’t have any logic to hide/show

What changes do you think we should make in order to solve the problem?

• In order to solve this we can define new props shouldShowOfflineIndicator to <ScreenWrapper> by default we should add true to always show and if we use <FullPageOfflineBlockingView> then simply we can pass shouldShowOfflineIndicator={false}

• We can see this behaviour of displaying couple of offline indicators on multiple pages, we need to identify all affected screen once the above solution approves we can find all affected pages on PR and then apply shouldShowOfflineIndicator props

• As per updated scope we can change this all below Instances where we are using <FullPageOfflineBlockingView> with <ScreenWrapper>

  • RequestorOnfidoStep.js
  • ReimbursementAccountLoadingIndicator.js
  • CodesPage.js
  • DisablePage.js
  • SuccessPage.js
  • VerifyPage.js
  • WalletStatementPage.js
  • AddPersonalBankAccountPage.js
  • BankAccountPlaidStep.js

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

two offline message are shown in connect bank account page when users are in offline mode

What is the root cause of that problem?

In

App/src/components/AddPlaidBankAccount.js

Line 168 in af6fb07

<FullPageOfflineBlockingView>

We're using FullPageOfflineBlockingView that shows the you appears to be offline text when users are in offline mode
Beside, we also show you appears to be offline on the bottom-left of the screen in small device

What changes do you think we should make in order to solve the problem?

In FullPageOfflineBlockingView, we should show title = props.translate('common.youAppearToBeOffline') only in large screen by using isSmallScreenWidth props from withWindowDimensions HOC

What alternative solutions did you explore? (Optional)

We can remove title={props.translate('common.youAppearToBeOffline')} in FullPageOfflineBlockingView because we always show you appears to be offline when user's in offline mode

[melvin-bot]

@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[michaelhaxhiu]

Hmm. I am torn on this

[michaelhaxhiu]

I want more input in #expensify-bugs before we proceed further. Please hold!

https://expensify.slack.com/archives/C049HHMV9SM/p1686149657454899?thread_ts=1685455943.267169&cid=C049HHMV9SM

[michaelhaxhiu]

@dhairyasenjaliya and @tienifr - how would you feel about us expanding the scope of this bug to be more holistic, and figure out the root cause for this offline page showing (and fix it across the board)?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c5da0515d1d2e88e

[melvin-bot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Triggered auto assignment to @flodnv (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[michaelhaxhiu]

cc'in @MonilBhavsar since you had your ✋s on #19187 and it's similar.

[dhairyasenjaliya]

@michaelhaxhiu updated pages whereby we can fix with global props if we are using <ScreenWrapper> inside that <FullPageOfflineBlockingView> we can pass to disable bottom indicator

[MonilBhavsar]

Since this was a widespread issue, we descoped it from that issue. We can fix it here for all pages 👍

[thesahindia]

@dhairyasenjaliya's proposal looks good to me!

C+ reviewed 🎀👀🎀

cc: @flodnv

[flodnv]

Cool, go for it @dhairyasenjaliya

[melvin-bot]

@flodnv, @michaelhaxhiu, @dhairyasenjaliya, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[thesahindia]

Not overdue!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Added shouldShowOfflineIndicator default props #20467

If no regressions arise, payment will be issued on 2023-06-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dhairyasenjaliya]

hey @flodnv @michaelhaxhiu does this issue eligible for an urgency bonus since we have scoped the actual bug on this GH in less than 3 days, along with that we also fix a couple of bugs that were not within the scope of PR that took some time to communicate back and forth that makes dealy on merge.

[dhairyasenjaliya]

hey, @michaelhaxhiu can you check this conversation once you get a chance #19187 (comment) We are handling an offline indicator issue here which was first reported by me here prior to this issue, but it turns out this should be handled here and we close that bug on that list and fix here, am I eligible for compensation!

[melvin-bot]

@flodnv, @michaelhaxhiu, @dhairyasenjaliya, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[michaelhaxhiu]

Sure we can add $500 (like an urgency bonus i suppose) to compensate you for the additional scope & work.

And you are asking to claim 1 bug bounty bonus for identifying https://expensify.slack.com/archives/C049HHMV9SM/p1684408727072029 which was fixed via your PR here, right? Seems fair too

[michaelhaxhiu]

Since we are gonna do that, let's apply the increase of pay for the C+ too.

• @dhairyasenjaliya Contributor work - $1500 + $250 bug report bonus
• @thesahindia C+ work - $1500 (requesting payment via newDot)
• @gadhiyamanan bug reporter - $250

Invited you all 3 to job, please comment here when you accept.

[melvin-bot]

@flodnv, @michaelhaxhiu, @dhairyasenjaliya, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[thesahindia]

@michaelhaxhiu, I will try the new method for this. I will use new dot to request money.

[flodnv]

bump @michaelhaxhiu ?

[michaelhaxhiu]

@thesahindia did you get paid via newDot? Next can you please address the checklist above 👆

[michaelhaxhiu]

Others are paid ✅

[thesahindia]

@thesahindia did you get paid via newDot?

No, I haven't requested the money yet. I still haven't added my bank account. You can close this issue I will add it to my list for tracking.

Next can you please address the checklist above 👆

We can skip the checklist on this there wasn't one specific PR which caused this. And I don't think we need to add a test case because it doesn't need any specific steps. It's pretty easy to catch.

[JmillsExpensify]

Reviewed the details for @thesahindia. $1,500 approved for payment via BZ summary above.