Added shouldShowOfflineIndicator default props #20467

dhairyasenjaliya · 2023-06-08T16:27:34Z

Details

Fixed Issues

$ #20004
PROPOSAL: #20004 (comment)

Tests

Switch to offline
Create new workspace(if not created)
Go to any workspace > bank account
Select Connect online with Plaid option
Notice on native mobile / mWeb should show only one OfflineIndicator

Test 2 (Add personal bank account)

Log in to the account without the beta wallet
Go to Settings > Preferences > enable Use Staging Server
Add a new bank account:
- Wells Fargo
- Username: user_good
- password: pass_good
- Mobile verification code: credential_good
Turn off the internet notice you should get You appears to be offline since here we can’t perform any step on offline mode

Test 3 (Bank account plaid step)

Login to ND (Switch to offline)
Go to Settings > Go to any workspace
Go to bank account
Notice on native mobile / mWeb should show only one OfflineIndicator

Test 4 (Code page )

Login to ND (Switch to offline)
Go to Settings > Go to security
Go to Two-factor authentication
Notice on native mobile / mWeb should show only one OfflineIndicator

Test 5 (Verify page )

Login to ND (Switch to offline)
Go to Settings > Go to security
Go to Two-factor authentication
Perform step-1 by clicking/downloading code -> Press Next
Notice on native mobile / mWeb should show only one OfflineIndicator

Test 6 (Success page )

Login to ND Go to Settings > Go to security
Go to Two-factor authentication
Perform step-1 by clicking/downloading code -> Press Next
Add auth code -> Press next -> On success page -> (Switch to offline)
Notice on native mobile / mWeb should show only one OfflineIndicator

Test 7 (bank account)

Login to ND with phone number
Go to setting -> Go to any workspace
Go to bank account
Notice you appears to be offline should show at bottom same as other page

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above steps
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Test 2-6

https://github-production-user-asset-6210df.s3.amazonaws.com/47522946/246508396-e808af18-1858-49cd-8307-d921fbf4fab5.png

melvin-bot · 2023-06-08T18:51:28Z

@flodnv @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thesahindia · 2023-06-09T16:36:25Z

src/pages/AddPersonalBankAccountPage.js

@@ -88,6 +88,7 @@ class AddPersonalBankAccountPage extends React.Component {
            <ScreenWrapper
                includeSafeAreaPaddingBottom={shouldShowSuccess}
                shouldEnablePickerAvoiding={false}
+                shouldShowOfflineIndicator={false}


Looks like we will need the offline indicator here

Screen.Recording.2023-06-09.at.10.00.34.PM.mov

@thesahindia Even if I remove the props still there is no offline indicator, this bug exists on the main as well un-related to PR

@thesahindia I agree we should add <FullPageOfflineBlockingView> to plaid and I found that initially this might be missed to add <FullPageOfflineBlockingView> here AddPlaidBankAccount.js but I believe this should be treated as a separate bug and treated into another PR since this PR is just about to remove the duplicate indicator
let me know if this sounds fine

Changes to add OfflineBlockingView to AddPlaidBankAccount when we have account's

App/src/components/AddPlaidBankAccount.js

Line 200 in d91fe14

<View>

+ <FullPageOfflineBlockingView>

Later this was found to be regression here Payments - Error message is missing after setting the only bank account as default #20565 but the above suggestion is to add <FullPageOfflineBlockingView> which I think we need to rectify first whether this is removed or any other issue on regression

I am not sure about it. I think we should handle it here. It's a simple change.

cc: @flodnv for thoughts.

Yes please let's just make this change here @dhairyasenjaliya

Later this was found to be regression here Payments - Error message is missing after setting the only bank account as default #20565 but the above suggestion is to add <FullPageOfflineBlockingView> which I think we need to rectify first whether this is removed or any other issue on regression

Please always add a new comment instead of editing an existing comment, as it can often go unnoticed.

@dhairyasenjaliya, can you please add some more details? I am not sure I understand how this is related to FullPageOfflineBlockingView.

…into offlineIndicator

dhairyasenjaliya · 2023-06-15T12:45:16Z

@thesahindia I have added FullPageOfflineBlockingView to AddPlaidBankAccount

thesahindia · 2023-06-15T21:33:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

thesahindia

Looks good!

cc: @flodnv

flodnv

Thanks! @dhairyasenjaliya Can you please update your tests and screenshots to test all the pages you have modified in this PR? 🙏

…into offlineIndicator

dhairyasenjaliya · 2023-06-16T17:26:31Z

@flodnv @thesahindia the position of the message is expected or not since the rest all have at the bottom this one is not ?

flodnv · 2023-06-16T17:49:49Z

I am not sure, maybe not? Maybe ask in Slack? What is causing this different behavior? 😕

dhairyasenjaliya · 2023-06-16T17:54:54Z

@flodnv we have just missed to add <Scrollview> and i checked this was 2 year back code when we logged in using phone number and try to add account we show warning at that time offline indicatore has different position & this is minor change

flodnv · 2023-06-16T17:58:16Z

Oh, if it's easy to fix it then let's also fix it here please

dhairyasenjaliya · 2023-06-16T18:00:27Z

yeah just came in while testing all the steps again :)

dhairyasenjaliya · 2023-06-16T19:07:06Z

@flodnv @thesahindia
7 additional steps were added with a screenshot of mobile since this PR affects only mobile and also additional fixes of offline indicator added (test 7) ready to merge :)

thesahindia

The changes looks good to me!

cc: @flodnv

flodnv · 2023-06-19T15:57:41Z

You have conflicts 😬

dhairyasenjaliya · 2023-06-19T16:19:43Z

looks like position of indicator is being fixed somewhere else but conflict solved @flodnv

flodnv · 2023-06-19T17:03:43Z

Your last commit is still not verified 😬

dhairyasenjaliya · 2023-06-19T17:07:45Z

yeah something is off im looking into

dhairyasenjaliya · 2023-06-19T21:16:04Z

@flodnv conflict resolved ready to merge pr:)

OSBotify · 2023-06-20T16:12:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-21T02:26:37Z

🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.30-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-22T16:54:15Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.30-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dhairyasenjaliya added 11 commits June 8, 2023 21:56

Added shouldShowOfflineIndicator default props

1504a3e

added props to component to display or not

e586701

added on plaid step

8f6e336

added on personal bank account

2b9185a

added on OnfidoStep

6936582

added on Reimbursement

b872b57

added on WalletStatmentPage:

12fc924

added on CodesPage

89b6568

added on VerifyPage

6b5e7eb

added on SuccesPage

072bbf1

added on DisablePage

4cd8d9c

dhairyasenjaliya marked this pull request as ready for review June 8, 2023 18:51

dhairyasenjaliya requested a review from a team as a code owner June 8, 2023 18:51

melvin-bot bot requested review from flodnv and thesahindia and removed request for a team June 8, 2023 18:51

thesahindia suggested changes Jun 9, 2023

View reviewed changes

dhairyasenjaliya requested a review from thesahindia June 15, 2023 03:47

dhairyasenjaliya added 2 commits June 15, 2023 09:21

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

73af0c2

…into offlineIndicator

Added FullPageOfflineBlockingView to plaid

819ab5a

thesahindia approved these changes Jun 15, 2023

View reviewed changes

flodnv reviewed Jun 16, 2023

View reviewed changes

Merge branch 'main' of https://github.com/dhairyasenjaliya/Expensify …

b5fc55a

…into offlineIndicator

OfflineIndicator position fix

07c7103

OfflineIndicator position bottom with scrollview

ef63157

thesahindia approved these changes Jun 19, 2023

View reviewed changes

melvin-bot bot requested a review from flodnv June 19, 2023 09:40

dhairyasenjaliya force-pushed the offlineIndicator branch from b10d746 to 142b835 Compare June 19, 2023 16:57

dhairyasenjaliya force-pushed the offlineIndicator branch from 0fdf2cc to 92a82e5 Compare June 19, 2023 17:07

dhairyasenjaliya force-pushed the offlineIndicator branch 3 times, most recently from b995581 to ef63157 Compare June 19, 2023 21:05

Merge branch 'main' into offlineIndicator

ede530b

flodnv approved these changes Jun 20, 2023

View reviewed changes

flodnv merged commit 6d53998 into Expensify:main Jun 20, 2023

OSBotify mentioned this pull request Jun 21, 2023

Deploy Checklist: New Expensify 2023-06-21 #21172

Closed

67 tasks

melvin-bot bot mentioned this pull request Jun 22, 2023

[HOLD for payment 2023-06-29] [$1000] Find and remove all instances where we show "You appear to be offline" twice in the UI, such that we only show it once. #20004

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added shouldShowOfflineIndicator default props #20467

Added shouldShowOfflineIndicator default props #20467

dhairyasenjaliya commented Jun 8, 2023 •

edited

Loading

melvin-bot bot commented Jun 8, 2023

thesahindia Jun 9, 2023

dhairyasenjaliya Jun 9, 2023

dhairyasenjaliya Jun 9, 2023 •

edited

Loading

thesahindia Jun 12, 2023

thesahindia Jun 12, 2023

flodnv Jun 12, 2023

thesahindia Jun 15, 2023

dhairyasenjaliya commented Jun 15, 2023

thesahindia commented Jun 15, 2023

thesahindia left a comment

flodnv left a comment

dhairyasenjaliya commented Jun 16, 2023

flodnv commented Jun 16, 2023

dhairyasenjaliya commented Jun 16, 2023 •

edited

Loading

flodnv commented Jun 16, 2023

dhairyasenjaliya commented Jun 16, 2023

dhairyasenjaliya commented Jun 16, 2023

thesahindia left a comment

flodnv commented Jun 19, 2023

dhairyasenjaliya commented Jun 19, 2023

flodnv commented Jun 19, 2023

dhairyasenjaliya commented Jun 19, 2023

dhairyasenjaliya commented Jun 19, 2023

OSBotify commented Jun 20, 2023

OSBotify commented Jun 21, 2023

OSBotify commented Jun 22, 2023

Added shouldShowOfflineIndicator default props #20467

Added shouldShowOfflineIndicator default props #20467

Conversation

dhairyasenjaliya commented Jun 8, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 8, 2023

thesahindia Jun 9, 2023

Choose a reason for hiding this comment

dhairyasenjaliya Jun 9, 2023

Choose a reason for hiding this comment

dhairyasenjaliya Jun 9, 2023 • edited Loading

Choose a reason for hiding this comment

Changes to add OfflineBlockingView to AddPlaidBankAccount when we have account's

thesahindia Jun 12, 2023

Choose a reason for hiding this comment

thesahindia Jun 12, 2023

Choose a reason for hiding this comment

flodnv Jun 12, 2023

Choose a reason for hiding this comment

thesahindia Jun 15, 2023

Choose a reason for hiding this comment

dhairyasenjaliya commented Jun 15, 2023

thesahindia commented Jun 15, 2023

Reviewer Checklist

Screenshots/Videos

thesahindia left a comment

Choose a reason for hiding this comment

flodnv left a comment

Choose a reason for hiding this comment

dhairyasenjaliya commented Jun 16, 2023

flodnv commented Jun 16, 2023

dhairyasenjaliya commented Jun 16, 2023 • edited Loading

flodnv commented Jun 16, 2023

dhairyasenjaliya commented Jun 16, 2023

dhairyasenjaliya commented Jun 16, 2023

thesahindia left a comment

Choose a reason for hiding this comment

flodnv commented Jun 19, 2023

dhairyasenjaliya commented Jun 19, 2023

flodnv commented Jun 19, 2023

dhairyasenjaliya commented Jun 19, 2023

dhairyasenjaliya commented Jun 19, 2023

OSBotify commented Jun 20, 2023

OSBotify commented Jun 21, 2023

OSBotify commented Jun 22, 2023

dhairyasenjaliya commented Jun 8, 2023 •

edited

Loading

dhairyasenjaliya Jun 9, 2023 •

edited

Loading

dhairyasenjaliya commented Jun 16, 2023 •

edited

Loading