[HOLD for payment 2023-07-24] [$1000] Deep link to Profile Page is not opening in the installed app

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to Settings > Share Code > Copy URL
2. Paste the link in another app. ( Slack, Notes or Messages)
3. Try to open the link by tapping on it

Expected Result:

Profile page should get opened in the installed app (iOS & Android)

Actual Result:

The link gets opened in mobile browser (Safari / Chrome)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

deeplink.mp4

Expensify/Expensify Issue URL:
Issue reported by: @aswin-s
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687876003386849

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0143c4c287988aa719
• Upwork Job ID: 1676019935665750016
• Last Price Increase: 2023-07-04

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[aswin-s]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deep link to profile page is not working on iOS & Android

What is the root cause of that problem?

Profile page URL is of the format ‘/a/:accountID’. This URL prefix is not added to apple-app-site-association file and AndroidManifest. That’s the reason this URL is not recognized as a universal link by the app.

What changes do you think we should make in order to solve the problem?

Add ‘/a’ URL prefix to both apple-app-site-association file and AndroidManifest.xml

iOS
https://github.com/Expensify/App/blob/main/.well-known/apple-app-site-association#L10

 { "/": "/a/*", "comment": "Profile Page" }, 

Android

Add below lines to AndroidManifest.xml https://github.com/Expensify/App/blob/main/android/app/src/main/AndroidManifest.xml#L57

 <data android:scheme="https" android:host="new.expensify.com" android:pathPrefix="/a"/> 

https://github.com/Expensify/App/blob/main/android/app/src/main/AndroidManifest.xml#L68

 <data android:scheme="https" android:host="staging.new.expensify.com" android:pathPrefix="/a"/> 

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0143c4c287988aa719

[melvin-bot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[michaelhaxhiu]

Agree with expected result 👍

[eVoloshchak]

@aswin-s's proposal looks good to me, looks like this was simply missed during the initial implementation of share profile link flow

🎀👀🎀 C+ reviewed!

[aswin-s]

@michaelhaxhiu @eVoloshchak This issue is not yet assigned to me. Is there another review pending?

[melvin-bot]

@eVoloshchak, @michaelhaxhiu Huh... This is 4 days overdue. Who can take care of this?

[eVoloshchak]

@michaelhaxhiu, @aswin-s's proposal looks good to me, could you take a look and assign @aswin-s to this issue if you agree?

[melvin-bot]

📣 @eVoloshchak Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @eVoloshchak 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[melvin-bot]

📣 @aswin-s You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @aswin! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

The BZ member will need to manually hire aswin for the Reporter role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[michaelhaxhiu]

Sorry for blocking this, it's a new process for BZ to assign the contributor and I am a little behind.

[aswin-s]

Contributor details
Your Expensify account email: mr.aswin@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~010b194c3e145d5456

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

🎯 ⚡️ Woah @eVoloshchak / @aswin-s, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @aswin-s got assigned: 2023-07-10 23:20:42 Z
• when the PR got merged: 2023-07-13 11:03:08 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.41-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: deep link for profile URLs #22616

If no regressions arise, payment will be issued on 2023-07-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[michaelhaxhiu]

Nice, this will be due for payment in about 1 week. Next is the checklist above 🤙

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: Add new Profile page #20144
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/20144/files#r1275320393
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1690395182200269
• Determine if we should create a regression test for this bug.
  Is it easy to test for this bug? Yes
  Is the bug related to an important user flow? Yes
  Is it an impactful bug? Yes

[eVoloshchak]

Regression Test Proposal

1. Have an IOS or Android device with the native app installed
2. Navigate to Settings > Share Code > Copy URL
3. Paste the link in another app. ( Slack, Notes or Messages)
4. Try to open the link by tapping on it
5. Verify that profile page is opened in the installed app

Do we agree 👍 or 👎

[eVoloshchak]

Requested the payment for this via NewDot

[michaelhaxhiu]

Payouts:

• @aswin-s External issue reporter - $250
• @aswin-s Contributor that fixed the issue - $1500
• @eVoloshchak Contributor+ that helped on the issue and/or PR - $1500 via New Dot (requested earlier today 👍 )

[michaelhaxhiu]

@aswin-s drop me a comment here when you've accepted the upwork job invite

[michaelhaxhiu]

QA test is added here - https://github.com/Expensify/Expensify/issues/303310

[aswin-s]

@michaelhaxhiu Accepted the offer

[JmillsExpensify]

Reviewed details for @eVoloshchak. This is accurate and approved for payment in NewDot.