Add new Profile page #20144

puneetlath · 2023-06-04T17:16:58Z

Details

This PR adds a new ProfilePage which is based on accountID to replace the current DetailsPage. However, we aren't removing the DetailsPage yet since it is still needed for mentions.

Fixed Issues

#20070

Tests

Click on someone's avatar in the chat
Verify that you are taken to their profile (you will know because it will say "profile" at the top instead of "details"
Make sure it shows the correct avatar/display name/etc
Go directly to the profile if someone you don't know using their accountID (e.g. https://new.expensify.com/a/64708047)
You should see a loading spinner and then eventually the profile will populate
Make sure the only info that you see is avatar and display name (no email or other contact info) (the display name will show as "hidden" if that user doesn't have one set)
Make sure that everywhere in the app where you click on something to see a profile, it works as expected

Verify that no errors appear in the JS console

Offline tests

The profile should be accessible when online of someone you know. Going to the profile via URL of someone you don't know while offline should just show a loading spinner.

QA Steps

Same as test steps.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-06-04T17:17:30Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Beamanator

A few small requested changes, overall looking good! i haven't tested yet though, waiting for C+ for that :D

src/libs/actions/PersonalDetails.js

src/pages/ProfilePage.js

allroundexperts · 2023-06-05T19:14:00Z

@puneetlath If the request fails (like its failing right now because of the missing endpoint), I see an endless spinner. Should we show some sort of error message?

allroundexperts · 2023-06-05T19:20:32Z

Opening someone's profile from group members page (eg admin) still opens previous profile version. Same for thread participant page and workspace participant page.

src/pages/ProfilePage.js

allroundexperts · 2023-06-05T19:32:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-08.at.4.22.44.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-06-08.at.4.27.50.PM.mov

Mobile Web - Safari

Screen.Recording.2023-06-08.at.4.28.28.PM.mov

Desktop

Screen.Recording.2023-06-08.at.4.25.48.PM.mov

iOS

Screen.Recording.2023-06-08.at.4.32.51.PM.mov

Android

Screen.Recording.2023-06-08.at.4.31.41.PM.mov

Beamanator

LGTM

puneetlath · 2023-06-08T01:50:33Z

@allroundexperts please test again when you get a chance. If you don't find any issues other than the group chat thing, then I think we're ok. Thanks!

allroundexperts · 2023-06-08T11:18:04Z

@allroundexperts please test again when you get a chance. If you don't find any issues other than the group chat thing, then I think we're ok. Thanks!

On it now!

src/pages/ProfilePage.js

allroundexperts · 2023-06-08T11:42:19Z

src/pages/ProfilePage.js

+                                    </CommunicationsLink>
+                                </View>
+                            ) : null}
+                            {pronouns ? (


NAB: {Boolean(pronouns) &&

ESLint is saying it's redundant for this one.

allroundexperts

Looks good!

allroundexperts · 2023-06-08T11:48:39Z

Following warnings are generated which are un-related to this PR. The first one is already posted in Slack here. I wasn't able to find second one posted anywhere so I've posted about it in Slack here.

puneetlath · 2023-06-08T13:48:05Z

Thanks for filing those bugs @allroundexperts!

Beamanator · 2023-06-08T13:50:23Z

Nice work team! 💪

OSBotify · 2023-06-08T13:56:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-08T17:01:36Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.26-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-13T00:22:19Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.26-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aimane-chnaif · 2023-06-26T14:13:03Z

src/components/ReportWelcomeText.js

@@ -97,7 +98,7 @@ const ReportWelcomeText = (props) => {
                                <Tooltip text={tooltip}>
                                    <Text
                                        style={[styles.textStrong]}
-                                        onPress={() => Navigation.navigate(ROUTES.getDetailsRoute(participants[index]))}
+                                        onPress={() => Navigation.navigate(ROUTES.getProfileRoute(participantAccountIDs[index]))}


This was overlooked. participantAccountIDs order was different from participants and it caused regression - Web - New Group - Wrong user details page opens on clicking at display names

#20583 (comment) for more details about the root cause.

Oh wow, that makes total sense. Should've considered that. Thanks for the feedback!

sobitneupane · 2023-07-10T08:10:47Z

While adding NewProfilePage, this issue was overlooked. When user opens a profile page with some undefined accountID (like letters), profile page loads forever.

puneetlath · 2023-07-10T17:35:38Z

Good catch. Thanks for linking!

eVoloshchak · 2023-07-26T18:05:42Z

src/ROUTES.js

@@ -114,10 +114,12 @@ export default {
    SET_PASSWORD_WITH_VALIDATE_CODE: 'setpassword/:accountID/:validateCode',
    DETAILS: 'details',
    getDetailsRoute: (login) => `details?login=${encodeURIComponent(login)}`,
+    PROFILE: 'a/:accountID',


👋 Just a heads-up that this has caused a regression in #21969
Deep linking wasn't working for the new PROFILE route.

When adding a new route we should also add it to App/well-known
/apple-app-site-association for iOS

{ "/": "/a/*", "comment": "Profile Page" }

And to AndroidManifest.xml for Android

<data android:scheme="https" android:host="new.expensify.com" android:pathPrefix="/a"/>

Oh wow. I had no idea. Can we make that obvious somehow? Like with a checklist item or lint rule or something.

@puneetlath, I proposed to add a checklist item in https://expensify.slack.com/archives/C049HHMV9SM/p1690395182200269
Looks like we should add it, I'll do that tomorrow (not sure what the process is just yet, will find it)

s77rt · 2023-10-16T21:35:34Z

src/pages/ProfilePage.js

+    const phoneNumber = getPhoneNumber(details);
+    const phoneOrEmail = isSMSLogin ? getPhoneNumber(details) : login;
+
+    const isCurrentUser = _.keys(props.loginList).includes(login);


We should have used the account ID to check if is current user because:

Users are now identified by account ids

The account ID is available from the route where the login is from onyx. Using data from onyx results in a delay where the first render will always evaluate isCurrentUser as false and causing this bug

Ah good catch, thanks for letting me know!

c3024 · 2024-04-11T05:47:11Z

src/libs/actions/PersonalDetails.js

+    const optimisticData = [
+        {
+            onyxMethod: Onyx.METHOD.MERGE,
+            key: ONYXKEYS.PERSONAL_DETAILS_LIST,


Adding isLoading to PERSONAL_DETAILS_LIST changes personalDetailsList. Lots of components subscribe to this and rerender causing a performance issue. #37986

puneetlath added 8 commits June 2, 2023 22:04

Add route and links for new profile page

e1ab57e

Add ProfilePage

558b23c

Use lodashGet for various details

540087d

Show loading indicator when details arent available

09e6b1f

Use "hidden" as fallback displayName

e138aee

Replace getDetailsRoute usage with getProfileRoute

249369e

Fetch the personal details from the API when opening profile page

2d9e221

Dont show timezone if we dont have it

7f5f165

puneetlath requested a review from a team as a code owner June 4, 2023 17:16

puneetlath self-assigned this Jun 4, 2023

melvin-bot bot requested review from arosiclair and removed request for a team June 4, 2023 17:17

puneetlath removed the request for review from arosiclair June 4, 2023 17:20

puneetlath marked this pull request as draft June 4, 2023 17:21

Dont show message option if you dont have their login info

f5832a3

puneetlath mentioned this pull request Jun 4, 2023

[Secure Logins] Make it so that users can’t see each others email addresses via profile unless they “know” each other #20070

Closed

puneetlath added 3 commits June 4, 2023 14:05

Use avatar that we have

b1f7118

Use accountID for default avatar if no login

05d5979

Merge main into branch

282d9e3

puneetlath marked this pull request as ready for review June 5, 2023 17:35

puneetlath requested review from Beamanator, mananjadhav and allroundexperts and removed request for mananjadhav June 5, 2023 17:35

Beamanator requested changes Jun 5, 2023

View reviewed changes

allroundexperts reviewed Jun 5, 2023

View reviewed changes

src/pages/ProfilePage.js Outdated Show resolved Hide resolved

Prettier fix

57beb1d

Beamanator approved these changes Jun 8, 2023

View reviewed changes

allroundexperts reviewed Jun 8, 2023

View reviewed changes

src/pages/ProfilePage.js Show resolved Hide resolved

allroundexperts reviewed Jun 8, 2023

View reviewed changes

allroundexperts approved these changes Jun 8, 2023

View reviewed changes

Beamanator merged commit fd0c6a9 into main Jun 8, 2023

Beamanator deleted the profile-by-accountID branch June 8, 2023 13:50

OSBotify mentioned this pull request Jun 8, 2023

Deploy Checklist: New Expensify 2023-06-08 #20466

Closed

74 tasks

AndrewGable mentioned this pull request Jun 8, 2023

[HOLD for payment 2023-06-21] [HOLD for payment 2023-06-19] Previewing Concierge shows different image in compared to group chat and search #20478

Closed

6 tasks

PauloGasparSv mentioned this pull request Jun 12, 2023

[$1000] [HOLD for payment 2023-06-21] [HOLD for payment 2023-06-19] Web - New Group - Wrong user details page opens on clicking at display names #20583

Closed

6 tasks

sobitneupane mentioned this pull request Jun 21, 2023

[HOLD for payment 2023-07-03] [$1000] Profile page loads infinitely with accountID is undefined #20854

Closed

6 tasks

aimane-chnaif reviewed Jun 26, 2023

View reviewed changes

eVoloshchak reviewed Jul 26, 2023

View reviewed changes

eVoloshchak mentioned this pull request Jul 26, 2023

[HOLD for payment 2023-07-24] [$1000] Deep link to Profile Page is not opening in the installed app #21969

Closed

6 tasks

eVoloshchak mentioned this pull request Oct 2, 2023

[HOLD for payment 2023-10-02] [$500] Split bill - Here is no smooth animation for Paid by and Split with users on Split bill page #26376

Closed

6 tasks

s77rt reviewed Oct 16, 2023

View reviewed changes

s77rt mentioned this pull request Oct 16, 2023

[HOLD for payment 2023-10-23] [$500] Share code - App displays message menu on self profile #28591

Closed

6 tasks

bernhardoj mentioned this pull request Dec 14, 2023

[$500] Chat-Email id is not shown as link and directed to profile page. #33044

Closed

6 tasks

c3024 reviewed Apr 11, 2024

View reviewed changes

c3024 mentioned this pull request Apr 11, 2024

[HOLD for payment 2024-04-09] [$500] Profile page opens with a lag when clicking from a chat #37986

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new Profile page #20144

Add new Profile page #20144

puneetlath commented Jun 4, 2023 •

edited

Loading

melvin-bot bot commented Jun 4, 2023

Beamanator left a comment

allroundexperts commented Jun 5, 2023

allroundexperts commented Jun 5, 2023 •

edited

Loading

allroundexperts commented Jun 5, 2023 •

edited

Loading

Beamanator left a comment

puneetlath commented Jun 8, 2023

allroundexperts commented Jun 8, 2023

allroundexperts Jun 8, 2023

puneetlath Jun 8, 2023

allroundexperts left a comment

allroundexperts commented Jun 8, 2023 •

edited

Loading

puneetlath commented Jun 8, 2023

Beamanator commented Jun 8, 2023

OSBotify commented Jun 8, 2023

OSBotify commented Jun 8, 2023

OSBotify commented Jun 13, 2023

aimane-chnaif Jun 26, 2023

aimane-chnaif Jun 26, 2023

puneetlath Jun 26, 2023

sobitneupane commented Jul 10, 2023

puneetlath commented Jul 10, 2023

eVoloshchak Jul 26, 2023

puneetlath Jul 26, 2023

eVoloshchak Jul 26, 2023

s77rt Oct 16, 2023 •

edited

Loading

puneetlath Oct 17, 2023

c3024 Apr 11, 2024

Add new Profile page #20144

Add new Profile page #20144

Conversation

puneetlath commented Jun 4, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 4, 2023

Beamanator left a comment

Choose a reason for hiding this comment

allroundexperts commented Jun 5, 2023

allroundexperts commented Jun 5, 2023 • edited Loading

allroundexperts commented Jun 5, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Beamanator left a comment

Choose a reason for hiding this comment

puneetlath commented Jun 8, 2023

allroundexperts commented Jun 8, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

allroundexperts left a comment

Choose a reason for hiding this comment

allroundexperts commented Jun 8, 2023 • edited Loading

puneetlath commented Jun 8, 2023

Beamanator commented Jun 8, 2023

OSBotify commented Jun 8, 2023

OSBotify commented Jun 8, 2023

OSBotify commented Jun 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sobitneupane commented Jul 10, 2023

puneetlath commented Jul 10, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

s77rt Oct 16, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

puneetlath commented Jun 4, 2023 •

edited

Loading

allroundexperts commented Jun 5, 2023 •

edited

Loading

allroundexperts commented Jun 5, 2023 •

edited

Loading

allroundexperts commented Jun 8, 2023 •

edited

Loading

s77rt Oct 16, 2023 •

edited

Loading