[HOLD for payment 2023-07-12] [HOLD for payment 2023-07-10] Copilot - Copilot and regular account actions are displayed the same in #admins room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #21246

Action Performed:

OldDot:

1. Create Control policy
2. Make changes in policy setting both under regular account and then co-pilot (or copilot and then regular account)
   NewDot:
3. Verify there is visual difference between actions taken under regular account and copilot

Expected Result:

Regular account and copilot should be displayed differently.

Actual Result:

All actions taken by both accounts are displayed under the name who did first actions

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35.4

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6112227_issue-1.mp4

Bug6112227_issue_2-1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tylerkaraszewski]

@hayata-suenaga - Since you reviewed the original PR I'm handing this to you, I unfortunately can't look into it as I'm about to leave on my sabbatical.

[hayata-suenaga]

I was able to reproduce

The last message should be sent from a copilot account (not Hayata Suenaga)

[hayata-suenaga]

When there are time gap between when the actual user and when the copilot edit the policies, the policy log message is sent from a correct person.

However, when the time is short, the the account of first person who make changes to the policy (actual user or copilot user) is used for subsequent messages.

[hayata-suenaga]

I think these lines should not exists will test on my dev

App/src/pages/home/report/ReportActionItemSingle.js

Lines 85 to 93 in 50c16ac

	} else if (props.action.delegateAccountID) {
	// We replace the actor's email, name, and avatar with the Copilot manually for now. This will be improved upon when
	// the Copilot feature is implemented.
	const delegateDetails = props.personalDetailsList[props.action.delegateAccountID];
	const delegateDisplayName = delegateDetails.displayName;
	actorHint = `${delegateDisplayName} (${props.translate('reportAction.asCopilot')} ${displayName})`;
	displayName = actorHint;
	avatarSource = UserUtils.getAvatar(delegateDetails.avatar, props.action.delegateAccountID);
	}

[hayata-suenaga]

the above method didn't work.

I'm still investigating I gonna ask help on slack

[hayata-suenaga]

still not working. When the copilot takes action, the policy change log message is shown as taken by the real user, not the copilot.

[hayata-suenaga]

@yuwenmemon please disregard the screenshot above #21970 (comment)

that is the effect from the code change I made in #21970 (comment)

[Julesssss]

The fix for this was merged and Cp'd . Marking it off the checklist 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.35-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Do not group actions if their delegate accountID does not match #22006

If no regressions arise, payment will be issued on 2023-07-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.36-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Do not group actions if their delegate accountID does not match #22006

If no regressions arise, payment will be issued on 2023-07-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[yuwenmemon]

This does not need payment it was all internal