-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the Copilot details if a delegate is set in a report action #21246
Conversation
…in a report action""
Reviewer Checklist
Screenshots/Videos |
@yuwenmemon How can I do that? Is there an account I can use? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM! I haven't tested this
I gonna rely on @allroundexperts for testing 🙇
You can create a co-pilot for a user in www.expensify.com by following these instructions: https://community.expensify.com/discussion/4783/how-to-add-or-remove-a-copilot |
@yuwenmemon Can you please resolve the conflicts? |
Also, @yuwenmemon, I'm getting this when trying to go to the categories page: Screen.Recording.2023-06-24.at.4.37.15.AM.mov |
@allroundexperts You'll need to test with a Control or Collect (paid) policy, not a workspace |
Updated and retested! |
import * as UserUtils from '../../libs/UserUtils'; | ||
|
||
function UserDetailsTooltip(props) { | ||
const userDetails = lodashGet(props.personalDetailsList, props.accountID, props.fallbackUserDetails); | ||
let userDisplayName = userDetails.displayName ? userDetails.displayName.trim() : ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`(userDetails.displayName || '').trim()
import * as UserUtils from '../../libs/UserUtils'; | ||
|
||
function UserDetailsTooltip(props) { | ||
const userDetails = lodashGet(props.personalDetailsList, props.accountID, props.fallbackUserDetails); | ||
let userDisplayName = userDetails.displayName ? userDetails.displayName.trim() : ''; | ||
let userLogin = (userDetails.login || '').trim() && !_.isEqual(userDetails.login, userDetails.displayName) ? Str.removeSMSDomain(userDetails.login) : ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_.isEqual
for string comparison is an overkill. No?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tests well.
🎯 @allroundexperts, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #21823. |
will wait for fixes suggested by @allroundexperts before merge |
…ert-20738-yuwen-copilot
Updated! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.35-0 🚀
|
Seems like you're already on it, but for historical records, this blocker was raised during testing: #21970 |
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀
|
1 similar comment
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀
|
@thienlnam plz review
cc @hayata-suenaga
Details
If an action was taken by a copilot, record that and show it in the display name of the user making the action.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/288976
Tests/QA
as copilot for XXXX)
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android