Deploy Checklist: New Expensify 2023-07-03

[OSBotify]

Release Version: 1.3.36-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Report Attachments Modal Route #20167
• Refactor IOUCurrencySelection class to use hooks #20579
• Fix navigate wrong route when submiting in new task title page #21174
• fix: add outline to checkbox when focused via button #21399
• [Snyk] Security upgrade electron from 22.3.7 to 22.3.14 #21524
• [FIX 20759] Remove the *New* notifiers just as the deletion starts. #21557
• fix OfflineWithFeedback errorRowStyles is misaligned #21662
• fix style copy button #21698
• Update selectedOptions when personalDetails or policyMembers changes #21700
• Fix - modified magic code link redirects to welcome screen with first place of magic code green #21724
• Fix mobile home background SVG opacity #21745
• fix two same emails display for user without display name #21779
• Report actions personal details cleanup #21822
• Make sure we call OpenProfile action/API call even if we're accessing the page directly #21834
• Fix/issue 20810 #21836
• Fix: Set validateCodeSent null on success of validateSecondaryLogin #21841
• Fixed 21280 textinput autogrow height #21850
• fix : keyboard shortcuts modal rendering on window resize #21863
• Fix: Update to USD popup is not dismissed dynamically if currency is updated #21873
• fix regex for debit card name #21880
• Reuse logic for policy name and workspace avatar #21895
• Fix: Date is not being displayed correctly when single digit day is entered (only fix on dob page) #21936
• feat: Migrate LHNTestUtils.js to function component #21939
• Fix: Web - Send money - The tab with Bank account and Debit card is in the middle Cash page #21980
• Remove extra spacing from content & header on task create flow #21981
• [CP Staging] Do not group actions if their delegate accountID does not match #22006
• Close the report screen when deleted before going to Concierge chat #22009
• Revert "fix: add outline to checkbox when focused via button" #22124
• Fix invited user disappearing when searching for another user #22132
• Fix broken back button on currency select #22135

Deploy Blockers:

• [HOLD for payment 2023-07-14] [HOLD for payment 2023-07-12] Blue box is seen if you click on the line above the members #22119
• [HOLD for payment 2023-07-14] [HOLD for payment 2023-07-12] Already selected members disappears after you search for new members #22123
• [$1000] [HOLD for payment 2023-07-14] Back button is not working on select a currency page #22130
• [HOLD for payment 2023-07-17] [$1000] Web - User is unable to download attachment #22133
• [HOLD for payment 2023-09-04] [$1000] Not allowed sign does not show when an attachment is drag and dropped #22218
• [HOLD for payment 2023-07-24] [$1000] Unable to Upload PDF & JPEG files that contains a space in the file title #22219
• [HOLD for payment 2023-07-14] Web - First cell of magic input field is not focused on clicking 'Didn't receive a magic code' link #22258

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[Julesssss]

Hey @mvtglobally, there was one small issue with the iOS build and checklist generation. It seems okay now, but let me know if you see anything odd!

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.36-1 🚀

[Li357]

Fix for #22123 is here: #22132

[dangrous]

Fix for #22130 is in review - #22135

EDIT: It pleases me how close together these numbers are

[Julesssss]

Blockers:

• Checked off [HOLD for payment 2023-07-14] [HOLD for payment 2023-07-12] Blue box is seen if you click on the line above the members #22119 after verifying the fix
• Marked off [HOLD for payment 2023-07-17] [$1000] Web - User is unable to download attachment #22133 as not a blocker (likely requires backend fix)
• [HOLD for payment 2023-07-14] [HOLD for payment 2023-07-12] Already selected members disappears after you search for new members #22123 fixed by this PR which is in review
• [$1000] [HOLD for payment 2023-07-14] Back button is not working on select a currency page #22130 fixed by this PR which is in review

[Julesssss]

I'm not sure why the description wasn't updated, but a fix Cp has bumped the current version to 1.3.36-2

[Julesssss]

I cherry-picked the fixes for the remaining blockers.

Were now on 1.3.36-4 -- I'll manually update it now

[Julesssss]

I have to sign off, and plan to deploy early tomorrow morning to give Applause plenty of time to work on the follow-up release checklist

[mvtglobally]

PR #21557 is failing #21952
PR #21700 is failing #22175. Repro in prod

[mvtglobally]

@Julesssss can you pls confirm what CPs were added for us to validate? I am not seeing the checklist updated with new PRs

[Julesssss]

Yep @mvtglobally:

• Fix broken back button on currency select #22135
• Fix invited user disappearing when searching for another user #22132

[mvtglobally]

@Julesssss Regression is completed

#22135 - Pass
#22132 - Pass

PR #21557 is failing #21952
PR #21662 is failing #21662. repro in PROD, checking off
PR #21834 (comment). Can you check it internally?
PR #21895 is failing #22234. Repro in PROD

[Julesssss]

Checked off the above items, and verified #21834 manually

[Julesssss]

• [HOLD for payment 2023-07-24] [$1000] Unable to Upload PDF & JPEG files that contains a space in the file title #22219: Not reproducible, so I downgraded from a blocker
• [HOLD for payment 2023-07-14] Web - First cell of magic input field is not focused on clicking 'Didn't receive a magic code' link #22258: Testing the fix PR with @MariaHCD currently
• [HOLD for payment 2023-09-04] [$1000] Not allowed sign does not show when an attachment is drag and dropped #22218: likely not revertable as we've followed up the original PR with additional fixes... It's also not bad enough to be a blocker IMO so I'm going to move forward

[mvtglobally]

@Julesssss We have to re-test one of the TCs on Android. Will update in a few min once the retest is completed

[Julesssss]

No problem. I'll be back online in about 45 mins

[mvtglobally]

@Julesssss We are done, no new blockers, so we are good to proceed

[Julesssss]

Perfect. Thanks!

[Julesssss]

Checked off #22258 after deploying the fix. @mvtglobally in order to release I'm going to verify myself, FYI

[Julesssss]

• The final blocker is merged and has been tested against an AdHoc build (arguable it's not even worth blocking over)
• timing looking good
• raised an unrelated OldDot crash here
• Single instance of a new ANR
• One non-fatal iOS issue here
• Github is up

[Julesssss]

iOS build finally succeeded: https://github.com/Expensify/App/actions/runs/5466586625/jobs/9951730698

[Julesssss]