-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - modified magic code link redirects to welcome screen with first place of magic code green #21724
Conversation
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosiOSScreen.Recording.2023-06-30.at.12.17.59.movAndroidScreen.Recording.2023-06-30.at.12.00.52.mov |
@rushatgabhane Friendly bump for review 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Beamanator @Beamanator LGTM
@Beamanator Friendly bump ^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the bump @HezekielT 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the bump @HezekielT 👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.36-0 🚀
|
@Beamanator @rushatgabhane @HezekielT I've got a deploy blocker that looks to be related with the changes in this PR: #22258 Specifically, when the user clicks |
Not a bug. Explained here - #22258 (comment) |
update: it's a bug and @HezekielT is working on a fix for it |
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.36-5 🚀
|
Details
Fixed Issues
$ #20169
PROPOSAL: #20169 (comment)
Tests
Request a new code
is shown instead ofDidn't receive magic code
after the timer to request a code has finished.Offline tests
Not applicable since connection is required to login.
QA Steps
Same as Tests Seciton.'
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
ScreencastWebMagicCode.mov
Mobile Web - Chrome
magicCodeMWeb.mov
Mobile Web - Safari
Desktop
ScreencastDesktopMagicCode.mov
iOS
iosmagic.mov
Android
ScreencastAndroidNativeMagicCode.mov