[HOLD for payment 2023-07-17] [$1000] Web - User is unable to download attachment

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open an existing chat
2. Upload a picture attachment
3. Open the picture
4. Click on 'download' icon

Expected Result:

Image should be downloaded

Actual Result:

A new URL is opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.36-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-07-03.22-12-30.mp4

Recording.3386.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688411675617159

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0168bae7edd97168e9
• Upwork Job ID: 1676239642199293952
• Last Price Increase: 2023-07-04

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kashn11]

this issue is due to cors error. On staging need to configure urls properly

[melvin-bot]

📣 @kashn11! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[kashn11]

Contributor details
Your Expensify account email: kashanilyas098@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01a6a250468eeb61d8

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Julesssss]

Not a blocker, also likely already existed on staging

[kidroca]

I have identified the root cause of this issue in a specific change from this pull request, where I've also left a note for reference.

In the AttachmentModal component, two types of views are conditionally rendered: a single image view and a carousel view. When the carousel view is active, we depend on the onNavigate callback to update the attachment data, including source, file, and isAuthTokenRequired. This callback is triggered both initially and upon any change, ensuring that the modal's state is always correctly updated.

The transition to a function-based component unfortunately overlooked the need to update the isAuthTokenRequired state. This state is crucial for the carousel logic to function as expected. Hence, the absence of its update is causing the issue we're seeing.

[kidroca]

@Julesssss
I've included the suggested fix in my PR as it also changes the onNavigate logic
It's a small PR and I hope it's not a problem to combine 2 fixes

• Improve Attachment Carousel State Management in AttachmentModal and ReportAttachments #22179

I'll provide test steps to verify the download issue is resolved

[Julesssss]

Excellent find, thank you. I'm going to assign you to this issue and generate an Upwork job for it.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0168bae7edd97168e9

[melvin-bot]

Triggered auto assignment to @muttmuure (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

The BZ member will need to manually hire Natnael for the Reporter role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[Julesssss]

Hey @laurenreidexpensify, when we get to the payout stage please can we use NewDot instead of UpWork? Thanks

[laurenreidexpensify]

Assigning @anmurali for the payout

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Improve Attachment Carousel State Management in AttachmentModal and ReportAttachments #22179

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali / @laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Santhosh-Sellavel]

@kidroca I believe you might have the idea on which PR this issue was introduced, please let me know thanks!

[laurenreidexpensify]

@Santhosh-Sellavel your payment will be issued in newdot on the C+ payment pilot cc @JmillsExpensify @anmurali

@Natnael-Guchima @kidroca apols for late offers, but your offers are now ready in upwork for job thanks

[Natnael-Guchima]

No worries. Accepted the offer. Thanks @laurenreidexpensify

[kidroca]

@Santhosh-Sellavel

@kidroca I believe you might have the idea on which PR this issue was introduced, please let me know thanks!

Check this comment out, it links the PR and explains the issue: #22133 (comment)

[kidroca]

@laurenreidexpensify

@Natnael-Guchima @kidroca my apologies for any late responses, but please note that your offers are now available on Upwork for review. Thank you for your patience.

Just a quick note, I have recently joined the beta program, and as per our agreement, it is understood that any future assignments, including the current task, will be compensated through the New Dot.

[laurenreidexpensify]

Okay, outstanding steps here:

@Santhosh-Sellavel can you please complete the checklist
@Santhosh-Sellavel @kidroca can you please close out your payments in newdot on the pilot if you have not requested them already

payment has been issued to @Natnael-Guchima

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: Refactor AttachmentModal to function component #20365
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/20365/files#r1252049731
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: IMO should have caught it while reviewing.
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. Yes
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. [HOLD for payment 2023-07-17] [$1000] Web - User is unable to download attachment #22133 (comment)
• [@anmurali / @laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@Julesssss Let me know if you differ on any of the above.

[Santhosh-Sellavel]

Bug:
Web - User is unable to download attachments

Regression Steps

Common to all

1. Navigate to a conversation where multiple images & pdfs are shared
2. Scroll through the chat to see all attachments
3. Now click on any attachment
4. Verify Attachment Carousel view is opened

On web and mobile web

1. Repeat the common steps to reach Attachment Carousel
2. Verify the URL in the address bar of the browser changes as we change attachments in the attachment carousel
3. Download a variety of attachments and check that the downloading functionality remains intact.
4. Change attachments using the arrow and verify downloading works

Other platforms

1. Repeat the common steps to reach Attachment Carousel
2. Download a variety of attachments and check that the downloading functionality remains intact.
3. Change attachments using the arrow and verify downloading works

👍 or 👎
cc: @Julesssss

[Santhosh-Sellavel]

Requested Payment on ND

[laurenreidexpensify]

Steps looked good @Santhosh-Sellavel - we're done with this one. Thanks!

[anmurali]

Approved 1k to Santhosh based on #22133 (comment)

[kidroca]

@laurenreidexpensify

@kidroca can you please close out your payments in newdot on the pilot if you have not requested them already

It would be a first time for me and I've requested more information on how to do that via Slack. I'll post back when I'm ready

[JmillsExpensify]

Reviewed details for @kidroca. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.