[HOLD for payment 2023-12-26] [$500] [Custom Status] Add the ability to automatically clear Custom User Status

[stitesExpensify]

Part of the Custom Status project

Main issue: #16350
Doc: https://docs.google.com/document/d/1uPS24aoRWE45piaTvr0XvrgV1lK3lSjieG3sD5ZPfQg/edit#bookmark=id.dm0yu67h9vq8
Project: https://github.com/orgs/Expensify/projects/59/views/1

Add the ability to automatically clear Custom User Status

This will involve many new pages to set relative times, time, and date.

1. Add "Clear After" button to the status page. This will also show the clear after time after one has been set.
   <img width="219" alt="2023-07-18_16-09-48" src="https://github.com/Expensify/App/assets/42391420/bf69bee6-dc40-4dac-be2c-b6af1b

0f24f3">

2. The "Clear After" page. This will expand when the user selects "custom" as you can see in the second screenshot

3. The Date picker page

4. The Time picker page

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b67967a538696fdd
• Upwork Job ID: 1724123658546638848
• Last Price Increase: 2023-11-13

[stitesExpensify]

No update here, but work has started on the base PR!

[stitesExpensify]

Base PR is in review!

[stitesExpensify]

Almost here!

[melvin-bot]

This issue has not been updated in over 15 days. @stitesExpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[stitesExpensify]

This has been on hold with @perunt being pulled to some other projects

[melvin-bot]

@conorpendergrast, @jamesdeanexpensify, @allroundexperts, @stitesExpensify Still overdue 6 days?! Let's take care of this!

[stitesExpensify]

Doing the final review now!

[melvin-bot]

@conorpendergrast, @jamesdeanexpensify, @allroundexperts, @stitesExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[stitesExpensify]

This has been merged!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[iwiznia]

Context https://expensify.slack.com/archives/C01GTK53T8Q/p1702577037928319
I closed this issue #33093 since it should not block, but we should add a better error message there

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[conorpendergrast]

@stitesExpensify @jamesdeanexpensify Do we have an external resource update for this change? We will need to update this help page

[jamesdeanexpensify]

I am unaware of one, maybe @stitesExpensify knows. Who usually handles that? I can make a PR if needed.

[stitesExpensify]

External resource update is here https://github.com/Expensify/Expensify/issues/296265 we closed it after the previous release because we were unsure how long this would take. I'll re-open it so that the help page can be updated

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.13-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Status clear after #24620

If no regressions arise, payment will be issued on 2023-12-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jjcoffee]

Just noting that I also reviewed the PR for this. Also, the base price should be $1000 as the issue was created before the change (not to mention the PR was massive 😅).

[allroundexperts]

Can we have a payment summary here? Thanks!

[conorpendergrast]

Yep, I can write that up! I'll check some details via an internal Slack channel then come back

[conorpendergrast]

Payouts due:

Contributor: $1000 @perunt (Contractor)

• First Contributor+: $1000 @jjcoffee - Contract
• Second Contributor+: $1000 @allroundexperts (NewDot Manual Requests)

After an internal discussion, we're arriving at $1000 as a balance between the scale of the work involved, and the two regressions.

Upwork job is here.

[jjcoffee]

@conorpendergrast Accepted, thanks!

[conorpendergrast]

@jjcoffee paid!

This was a new feature so doesn't require the checklist, so I'm closing it out. Thanks!

[JmillsExpensify]

$1,000 payment to @allroundexperts based on summary above.