[HOLD for payment 2023-10-24] [$1000] Chat - Edit code block inside strike-through moves edited label down

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Paste this in composer ->
   
3. Click send -> Edit that message and add space in between Test
4. Save
5. Again edit same message and put Backticks (`) and tild (~) together and Hit save

Expected Result:

Edited label should maintain position

Actual Result:

Edited label goes down on editing code block inside strike-through

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.51.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Image.from.iOS.1.MP4

2023.08.07.11.23.Img.0253.mp4

Expensify/Expensify Issue URL:

Issue reported by: @DinalJivani

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690918812009579

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e64b87477a7b36f2
• Upwork Job ID: 1698540341553090560
• Last Price Increase: 2023-10-10
• Automatic offers:
• Krishna2323 | Contributor | 27140365
• DinalJivani | Reporter | 27140369

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Edit code block inside strike-through moves edited label down

What is the root cause of that problem?

Because of Style issue of <del> tag in react-native-render-html package on iOS.

What changes do you think we should make in order to solve the problem?

We need to update react-native-render-html package.

What alternative solutions did you explore? (Optional)

We can use other way simply.

<del><pre>Test<br /></pre></del><edited ></edited>

This is case of issue.
We can update this like this.

<del><pre>Test<br /></pre><edited ></edited></del>

We can add this function to applyStrikethrough function.

App/src/pages/home/report/ReportActionItemFragment.js

Line 125 in 8639fb6

const htmlContent = applyStrikethrough(html + editedTag, isPendingDelete);

[melvin-bot]

@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@mallenexpensify 12 days overdue. Walking. Toward. The. Light...

[mallenexpensify]

@DinalJivani how do you type ` on the keypad on the iOS keyboard in the app?

[mallenexpensify]

Come on GH... remove that Overdue label....

[DinalJivani]

@mallenexpensify
On iOS Keyboard, find Single quote or Apostrophe (‘) Tap and hold that key.

IMG_8342.MOV

[melvin-bot]

@mallenexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

@mallenexpensify Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

Checking on here https://expensify.slack.com/archives/C049HHMV9SM/p1693349126104419?thread_ts=1690918812.009579&cid=C049HHMV9SM

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Krishna2323]

@eVoloshchak, PR ready for review.

[trjExpensify]

@trjExpensify
I have received offer of 50 instead of 250.
Please check and update.

@mallenexpensify will likely take care of it when we're ready for payments.

[Krishna2323]

PR is merged🎉.

[eVoloshchak]

@Krishna2323, there should be a second PR with updated expensify-common hash (this line)
Unless another PR has already included the last version of expensify-common

[Krishna2323]

@eVoloshchak, PR for hash update, pls review, IOS native and Android Native demo will be updated in few minutes.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @Krishna2323 got assigned: 2023-10-11 12:56:13 Z
• when the PR got merged: 2023-10-16 15:31:28 UTC
• days elapsed: 3

On to the next one 🚀

[Krishna2323]

Just noting that the PR in expensify-common repo was merged within 2 days and PR in this repo was approved and reviewed by @eVoloshchak within 3 working days of assignment.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• update: expensify-common #29575

If no regressions arise, payment will be issued on 2023-10-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligible for Manual Requests)
• @Krishna2323 requires payment offer (Contributor)
• @DinalJivani requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Krishna2323]

@mallenexpensify, bump for payments here.

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: there isn't a PR that caused this, this is the behavior that was implemented initially and we've decided to change it
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: we already have the following item in the reviewer checklist: If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.

[eVoloshchak]

Regression Test Proposal

1. Open any report
2. Paste ~```Code```~ into the composer and send the message
3. Verify that the code block text doesn't get strike-through line
4. Verify that there's a ~ symbol above and below the code block

Do we agree 👍 or 👎

[mallenexpensify]

Issue reporter: @DinalJivani paid $250 via Upwork
Contributor: @Krishna2323 paid $1500 via Upwork, inc. urgency bonus (deets here)
Contributor+: @eVoloshchak due $1500 via NewDot, inc. urgency bonus

Regression Test - https://github.com/Expensify/Expensify/issues/330261

Thanks y'all!

[DinalJivani]

@trjExpensify I have received offer of 50 instead of 250. Please check and update.

@mallenexpensify

[mallenexpensify]

d'oh, sorry about that @DinalJivani , I was following the auto-amount and should have checked the date the bug was reported. I bonused you $200 and updated the comment above so that it's correct.

[JmillsExpensify]

$1,500 payment approved for @eVoloshchak based on this summary.