-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Prevent nesting code blocks in markdown #27208
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01f8d855ec7167b7ca |
Triggered auto assignment to @stephanieelliott ( |
Current assignee @parasharrajat is eligible for the External assigner, not assigning anyone new. |
Just to clarify is Hello world also nested markdown? Or is it only for cases with code-fence? |
Good question, I think code fence situations only |
@thienlnam This issue is mistitled, you are talking about fenced code blocks nested in markdown (inlines), not the other way around. |
Yeah, it should be |
Another example of such nested rules #26941 |
@parasharrajat Do you suggest extending the scope of this issue and closing the other one? |
@parasharrajat, @stephanieelliott Eep! 4 days overdue now. Issues have feelings too... |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
I will pick this up tomorrow as a new project as it seems there is more to it than just being an issue. |
@parasharrajat, @stephanieelliott Huh... This is 4 days overdue. Who can take care of this? |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@parasharrajat, @stephanieelliott 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
@parasharrajat, @stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@parasharrajat, @stephanieelliott 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
Wasn't able to test this yet. |
@parasharrajat, @stephanieelliott Eep! 4 days overdue now. Issues have feelings too... |
Hey @parasharrajat any update on this? Seeing as this we're treating this as more of a project and it doesn't have any impact on functionality, I'm going to move this to |
Bump @parasharrajat, any update? |
Hey @parasharrajat it's been a while -- can you give an update please? |
Bumped @parasharrajat for an update in Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1701217378545439 |
@alitoshmatov's proposal makes sense. Let's go with it. 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @parasharrajat Please request via NewDot manual requests for the Reviewer role ($500) |
📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Looks like this issue was resolved in #24281 which applied the same solution as I proposed. |
Oh... Sorry for the delay in picking up your proposal early. I closed 3 issues in favor of this one but someone must have reported a duplicate issue again. I will take note of this. So for now, there is nothing to do here. I guess. |
This was closed without fixing the other linked issue #26941 |
@s77rt you can continue on that issue to find a solution. There is nothing done on this issue, it was solved indirectly from other duplicate issue. |
We've been running into all sorts of issues by allowing nested markdown rules.
Ex: #23034
Ex: #26941
Context: https://expensify.slack.com/archives/C01GTK53T8Q/p1694011229493309
As one of the new rules, let's prevent nested markdown
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: