[HOLD for payment 2023-10-09] [$1000] Sign in- Language preference doesn't persist when user Signs in with google

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to sign in page
2. Change the browsers language preference to Spanish
3. Refresh Sign up page
4. Click on 'Sign in with Google icon'
5. Select your account & proceed to sign in

Expected Result:

Language preference should persist to the app

Actual Result:

Language preference reverts back to English

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.57-5

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-08-22.07-38-27.mp4

bandicam.2023-08-29.00-20-27-406.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Natnael-Guchima

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692679468017399

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d5f71b81bcb185b1
• Upwork Job ID: 1696624990261616640
• Last Price Increase: 2023-08-29
• Automatic offers:
• aimane-chnaif | Reviewer | 26496302
• hoangzinh | Contributor | 26496303
• Natnael-guchima | Reporter | 26496305

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Sign in- Language preference doesn't persist when user Signs in with google

What is the root cause of that problem?

In the action method called to Sign in with Google, we haven't passed the current preferredLocale when call API yet

App/src/libs/actions/Session/index.js

Lines 256 to 259 in d84006f

	function beginGoogleSignIn(token) {
	const {optimisticData, successData, failureData} = signInAttemptState();
	API.write('SignInWithGoogle', {token}, {optimisticData, successData, failureData});
	}

That's reason the preferred locale is reset to default locale on BE side.

What changes do you think we should make in order to solve the problem?

1. FE: In the action method called to Sign in with Google above, we need to pass current preferredLocale when call API, same as login with email method

   App/src/libs/actions/Session/index.js

   Line 441 in d84006f

   preferredLocale,

2. BE: need to update so that it will pick preferredLocale param in API request, then process it like login with email method.

We can fix for Sign in with Apple as well.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d5f71b81bcb185b1

[melvin-bot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

@isabelastisser, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[aimane-chnaif]

@hoangzinh's proposal looks good to me.
Agree this also requires backend update.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @Natnael-Guchima 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bondydaa]

Coolio yep nice work though yikes following this code on the back end was a headache 😂 .

I think we can make these changes in new dot now so that we're passing these things along to the API but until we update the back end it won't be fully fixed but I think that is okay.

I'm going to spin up an internal issue to get the back end changes done.

Though note since we're in a slight feature freeze we probably won't merge your PR until next week.

[bondydaa]

okay internal issue here https://github.com/Expensify/Expensify/issues/313959 to get this updated on the back end. Going to see if any other engineers want to pick it up who don't have much experience with our API but if the front end changes are done and no on has picked it up I can probably get it done as well.

[hoangzinh]

@bondydaa the PR is ready but I'm unsure should we make this issue as On-Hold and wait BE work done to be able to test the FE or we can get FE done first. #26948

[hoangzinh]

Sorry for late response, yup, the PR is ready #26948

[bondydaa]

oh actually @lakchote has taken on the backend issue for this ❤️

1 PR is up right now and we'll review it today. We'll need 1 more PR for the API after that is finished.

@lakchote you should be able to test the full flow once #26948 is merged (or check it out locally if you are in a big hurry).

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @hoangzinh got assigned: 2023-09-04 22:08:22 Z
• when the PR got merged: 2023-09-26 02:57:41 UTC
• days elapsed: 15

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Sign in- Language preference doesn't persist when user Signs in with google #26948

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment offer (Contributor)
• @aimane-chnaif requires payment offer (Reviewer)
• @Natnael-Guchima requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh / @aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh / @aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh / @aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh / @aimane-chnaif] Determine if we should create a regression test for this bug.
• [@hoangzinh / @aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[aimane-chnaif]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh / @aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@hoangzinh / @aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@hoangzinh / @aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@hoangzinh / @aimane-chnaif] Determine if we should create a regression test for this bug.
• [@hoangzinh / @aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Logout if already logged in
2. Scroll down to bottom and select language to Spanish
3. Login with Google or Apple
4. Verify that user language is Spanish

[aimane-chnaif]

I think this is eligible for efficiency bonus as the PR was on hold for backend work.
We quickly tested and merged app PR after backend PR deployed to staging/production.

[melvin-bot]

@bondydaa, @hoangzinh, @isabelastisser, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@bondydaa, @hoangzinh, @isabelastisser, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hoangzinh]

cc @isabelastisser on the payout.

[isabelastisser]

Sorry for the delay, I was OOO. I will take care of this soon!

[isabelastisser]

The payments were made in Upwork now.

[isabelastisser]

[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

https://github.com/Expensify/Expensify/issues/327872

All set!