Fix Sign in- Language preference doesn't persist when user Signs in with google #26948

hoangzinh · 2023-09-07T11:49:48Z

Details

Fixed Issues

$ #26133
PROPOSAL: #26133 (comment)

Tests

Test case 1: User language preference is English

Change the browsers language preference to English
Navigate to sign in page
Click on 'Sign in with Google icon'
Select your account & proceed to sign in
Verify that after sign in, the App should display in English

Test case 2: User language preference is Spanish

Change the browsers language preference to Spanish
Navigate to sign in page
Click on 'Sign in with Google icon'
Select your account & proceed to sign in
Verify that after sign in, the App should display in Spanish

Verify that no errors appear in the JS console

Offline tests

Could not test when network is offline

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-25.at.20.28.22.-.web.mp4

Mobile Web - Chrome

Mobile Web - Safari

Screen.Recording.2023-09-25.at.23.24.34.-.ios.safari.mp4

Desktop

Screen.Recording.2023-09-25.at.20.33.40.-.desktop.mp4

iOS

Screen.Recording.2023-09-25.at.23.14.40.-.ios.mp4

Android

melvin-bot · 2023-09-14T08:05:52Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2023-09-15T14:43:10Z

src/libs/actions/Session/index.js

@@ -244,7 +250,7 @@ function beginSignIn(login) {
 */
 function beginAppleSignIn(idToken) {
    const {optimisticData, successData, failureData} = signInAttemptState();
-    API.write('SignInWithApple', {idToken}, {optimisticData, successData, failureData});
+    API.write('SignInWithApple', {idToken, preferredLocale: nvpPreferredLocale}, {optimisticData, successData, failureData});


Let's make getting preferredLocale logic consistent with normal sign in.
So for all 3 functions, either pass as param or use static value connected with Onyx.

I prefer "use static value connected with Onyx" for all of them. Because I don't think the preferredLocale is a part of login form. What do you think? @aimane-chnaif

Updated PR and tested in local. Could you preview the PR again? Thanks

aimane-chnaif · 2023-09-18T19:00:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

ios.mov

Android

aimane-chnaif

Confirmed preferredLocale param is passed correctly to SignInWithApple, SignInWithGoogle api commands.

Also verified this doesn't break current normal login flow with preferred language selected.

@bondydaa all yours!

bondydaa

👍 thank you! I just merged the backend changes to the API layer for this, the db layer was already updated and deployed. I'm going to add to the test steps to test the things outlined the original GH and wait to merge until the API changes have been deployed so that we can then confirm everything is still working, sorry for the back and forth!

bondydaa · 2023-09-19T17:47:03Z

oh test steps are already correct 👍

hoangzinh · 2023-09-19T23:07:37Z

no worry @bondydaa. Just in case you're busy with something higher priority, I can help to test.

aimane-chnaif · 2023-09-22T01:47:42Z

@hoangzinh please fix conflict

hoangzinh · 2023-09-22T07:44:06Z

Fixed conflict with the main branch + also tested current Sign-in forms as well

hoangzinh · 2023-09-22T07:44:17Z

cc @aimane-chnaif ^

aimane-chnaif · 2023-09-22T07:49:05Z

@bondydaa please let us know when both internal PRs reached staging or production so we can test

bondydaa · 2023-09-25T07:25:22Z

sorry for the delay here! Looks like https://github.com/Expensify/Web-Expensify/pull/38866 was deployed to both staging and production so we should be good to test this then against both/either and confirm it works as well!

hoangzinh · 2023-09-25T11:11:48Z

Hi @bondydaa could we only test Sign in with Google? I read the guide to test Sign in with Apple in Dev env here https://github.com/Expensify/App/blob/main/contributingGuides/APPLE_GOOGLE_SIGNIN.md#apple. It seems a bunk of complicated steps to set up it.

aimane-chnaif · 2023-09-25T11:19:41Z

Hi @bondydaa could we only test Sign in with Google? I read the guide to test Sign in with Apple in Dev env here https://github.com/Expensify/App/blob/main/contributingGuides/APPLE_GOOGLE_SIGNIN.md#apple. It seems a bunk of complicated steps to set up it.

yes, it's quite complicated. We can test apple after deploy to staging

hoangzinh · 2023-09-25T16:47:59Z

I updated recordings for testing Sign in with Google. All platforms have been uploaded, except the mweb Android. It shows a blank page after clicking Sign in with Google icon. Do you have a same experience as me? Thanks @aimane-chnaif

Screen.Recording.2023-09-25.at.23.47.07.mov

aimane-chnaif · 2023-09-25T17:09:01Z

Same happens to me. Seems like mWeb requires staging test too.

aimane-chnaif · 2023-09-25T17:10:00Z

@bondydaa I think we're good to merge as we verified working on some platforms.
The fix is just api update and doesn't depend on platforms.

bondydaa · 2023-09-26T02:57:28Z

awesome thank you both so much!

OSBotify · 2023-09-26T03:03:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-28T19:20:06Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:24:02Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:52:40Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:53:37Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Pass preferredLocale when sign in with google or apple id

28532e7

hoangzinh mentioned this pull request Sep 7, 2023

[HOLD for payment 2023-10-09] [$1000] Sign in- Language preference doesn't persist when user Signs in with google #26133

Closed

6 tasks

Fix linter

5ad1310

hoangzinh marked this pull request as ready for review September 14, 2023 08:05

hoangzinh requested a review from a team as a code owner September 14, 2023 08:05

melvin-bot bot requested review from aimane-chnaif and removed request for a team September 14, 2023 08:05

aimane-chnaif reviewed Sep 15, 2023

View reviewed changes

hoangzinh added 2 commits September 15, 2023 22:45

Merge branch 'main' into df/26133

eba0d9f

Use preferredLocale from Onyx because it's not part of sign in form

3c9fbf7

aimane-chnaif approved these changes Sep 18, 2023

View reviewed changes

melvin-bot bot requested a review from bondydaa September 18, 2023 19:01

bondydaa previously approved these changes Sep 19, 2023

View reviewed changes

Merge branch 'main' into df/26133

2f667fe

hoangzinh dismissed bondydaa’s stale review via 2f667fe September 22, 2023 05:11

bondydaa approved these changes Sep 26, 2023

View reviewed changes

bondydaa merged commit 3e9fdf6 into Expensify:main Sep 26, 2023
18 checks passed

OSBotify mentioned this pull request Sep 28, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Sign in- Language preference doesn't persist when user Signs in with google #26948

Fix Sign in- Language preference doesn't persist when user Signs in with google #26948

hoangzinh commented Sep 7, 2023 •

edited

Loading

melvin-bot bot commented Sep 14, 2023

aimane-chnaif Sep 15, 2023

hoangzinh Sep 15, 2023

aimane-chnaif Sep 15, 2023

hoangzinh Sep 15, 2023

aimane-chnaif commented Sep 18, 2023

aimane-chnaif left a comment

bondydaa left a comment

bondydaa commented Sep 19, 2023

hoangzinh commented Sep 19, 2023

aimane-chnaif commented Sep 22, 2023

hoangzinh commented Sep 22, 2023

hoangzinh commented Sep 22, 2023

aimane-chnaif commented Sep 22, 2023

bondydaa commented Sep 25, 2023

hoangzinh commented Sep 25, 2023

aimane-chnaif commented Sep 25, 2023

hoangzinh commented Sep 25, 2023

aimane-chnaif commented Sep 25, 2023

aimane-chnaif commented Sep 25, 2023

bondydaa commented Sep 26, 2023

OSBotify commented Sep 26, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

Fix Sign in- Language preference doesn't persist when user Signs in with google #26948

Fix Sign in- Language preference doesn't persist when user Signs in with google #26948

Conversation

hoangzinh commented Sep 7, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 14, 2023

aimane-chnaif Sep 15, 2023

Choose a reason for hiding this comment

hoangzinh Sep 15, 2023

Choose a reason for hiding this comment

aimane-chnaif Sep 15, 2023

Choose a reason for hiding this comment

hoangzinh Sep 15, 2023

Choose a reason for hiding this comment

aimane-chnaif commented Sep 18, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

bondydaa left a comment

Choose a reason for hiding this comment

bondydaa commented Sep 19, 2023

hoangzinh commented Sep 19, 2023

aimane-chnaif commented Sep 22, 2023

hoangzinh commented Sep 22, 2023

hoangzinh commented Sep 22, 2023

aimane-chnaif commented Sep 22, 2023

bondydaa commented Sep 25, 2023

hoangzinh commented Sep 25, 2023

aimane-chnaif commented Sep 25, 2023

hoangzinh commented Sep 25, 2023

aimane-chnaif commented Sep 25, 2023

aimane-chnaif commented Sep 25, 2023

bondydaa commented Sep 26, 2023

OSBotify commented Sep 26, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

hoangzinh commented Sep 7, 2023 •

edited

Loading