Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log in - User is taken to a empty conversation without a participant #2659

Closed
isagoico opened this issue Apr 30, 2021 · 18 comments · Fixed by #3170
Closed

Log in - User is taken to a empty conversation without a participant #2659

isagoico opened this issue Apr 30, 2021 · 18 comments · Fixed by #3170
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

User is taken to one of the existing conversations or if a new account user is taken to the concierge chat.

Actual Result:

User is shown a empty conversation with no participant.

Action Performed:

  1. Open a incognito tab or clear cache
  2. Log in with a existing expensifail account that has conversation with other users.

Workaround:

Navigate to another conversation

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.35-0

Logs:* https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@isagoico isagoico added the DeployBlockerCash This issue or pull request should block deployment label Apr 30, 2021
@isagoico isagoico added the Daily KSv2 label Apr 30, 2021
@isagoico
Copy link
Author

This is only afftecting expensifail accounts, so I think this might be related to this PR #2612 CC @marcaaron @Julesssss @francoisl

@roryabraham
Copy link
Contributor

Since this is only occurring for accounts on the IOU beta, does it need to be a deploy blocker?

@isagoico isagoico added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Apr 30, 2021
@MelvinBot
Copy link

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Apr 30, 2021
@Julesssss
Copy link
Contributor

Since this is only occurring for accounts on the IOU beta, does it need to be a deploy blocker?

Probably not, but that does include all @expensify/@expensifail users -- which is probably a large proportion of current users.

@MelvinBot
Copy link

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Julesssss Julesssss added Improvement Item broken or needs improvement. and removed DeployBlockerCash This issue or pull request should block deployment labels May 6, 2021
@Julesssss
Copy link
Contributor

FYI @trjExpensify

I've added this issue to the IOU parent tracker.

@trjExpensify
Copy link
Contributor

Cool, sounds good. Agree this is a N5 blocker 👍

@alex-mechler
Copy link
Contributor

Been a minute since I've been in the e.cash code, but I've been itching to get back in so I'll keep this one myself

@trjExpensify
Copy link
Contributor

Baller. That'll be a huge help for N5 bud!

@alex-mechler
Copy link
Contributor

@isagoico are you still able to reproduce this? I just tested following the steps and I was not able to. This was in a fresh incognito window

Mg2S5ONgwP.mp4

@isagoico
Copy link
Author

isagoico commented May 6, 2021

I'm unable to reproduce anymore too 🤯 I tried on the same I account I was able to reproduce before and in a new one and nothing. Maybe some change fixed it?

@alex-mechler
Copy link
Contributor

Ahahahah, it happens. Probably something fixed it unintentionally. If you see this popping back up feel free to reopen it!

@trjExpensify
Copy link
Contributor

Happy days!

@isagoico
Copy link
Author

Reopening this issue since I was able to reproduce on this account (isagoicotest@gmail.com / 123456Isa)

So apparently when login out and then back in with a different account the user is taken to the previous chat (from the other account) So what I did to repro this issue again without the need to log out and in on my test account was.

  1. Log in as isagoicotest@gmail.com / 123456Isa
  2. Change the URL to https://staging.expensify.cash/r/73550298

image

@isagoico isagoico reopened this May 21, 2021
@marcaaron
Copy link
Contributor

I think this might be related -> #2642

It can be hard to reproduce but happens most often when we are quickly logging out soon after logging in while network requests are in transit.

@alex-mechler
Copy link
Contributor

That would make sense. If we are signing out while writing the last viewed report to Onyx, it might not get cleared.

@alex-mechler
Copy link
Contributor

Digging into this, it seems unrelated. I was watching my localstorage the whole time, and report 254 was out of my local storage when signing into an account without access to it, yet it still was the report I was brought to.

@alex-mechler
Copy link
Contributor

Figured out what was happening, posted in slack to see if we can just remove the _.once wrapper
https://expensify.slack.com/archives/C01GTK53T8Q/p1622059995292000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants