Deploy Checklist: Expensify.cash 2021-04-29

[OSBotify]

Release Version: 1.0.41-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Introduce "Mark as unread" functionality in Expensify.cash #2433
• fix Modal animations #2505
• fix inline code blocks #2527
• Emoji Picker Menu Navigation #2532
• Refocus search input every time a person is selected/unselected #2564
• [No QA] Fix scroll issue #2607
• Add IOU Menu Options #2612
• [No QA] Make BootSplash have better parity on web/desktop #2623
• [No QA] Fix broken production deploy #2641
• Font-family difference between platforms #2648
• fix: Incomplete reports would cause the app to crash on startup #2649
• Revert "fix Modal animations" #2663
• Move Sign Out button into Settings menu #2678
• Use the normal pin icon for the LHN #2686
• Don't allow users to create chats with domain accounts #2687
• Mark all actions as read immediately after the chat becomes active/visible #2699
• Manually handle keyboard to prevent Android crash #2707
• feature: Include polyfill.io for web builds #2722

Deploy Blockers:

• Log in - User is taken to a empty conversation without a participant  #2659
• iOS - Unable to select emoji  #2660
• [Pay 5/10] Android / iOS - Conversation - Email addresses are displayed on header instead of the name  #2668
• Android - App crashes when tapping back arrow on request money screen #2694
• Unable to create new group  #2704

cc @Expensify/applauseleads

[isagoico]

Adding the lock label! CC @roryabraham

[isagoico]

Regression is finished!
2 issues found

1. Log in - User is taken to a empty conversation without a participant  #2659
2. iOS - Unable to select emoji  #2660

PRs are finished too
No comments added.

Thanks!

[isagoico]

Starting QA

[isagoico]

Regression is finished!
1 issue found today.

1. Log in - Continue button isn't responding after switching gmail with expensifail accounts #2679

PRs are finished too!
1 comment added.

1. Emoji Picker Menu Navigation #2532 (comment)

Thanks!

[isagoico]

Starting QA!

[isagoico]

Regression is finished!
Android QA was on hold because the latest build was not available for download. https://github.com/Expensify/Expensify.cash/runs/2504796985?check_suite_focus=true

Issues found:

1. Android - App crashes when tapping back arrow on request money screen #2694 - Possible DB
2. iOS - Chat - Messages flicker once after message is sent #2693
3. iOS - Request money - Request button is hidden under keyboard #2691

PRs are finished too:

1. Move Sign Out button into Settings menu #2678 is missing Android QA. It was a pass in all the other platforms.
2. Emoji Picker Menu Navigation #2532 (comment)

Thanks!

[Julesssss]

Removed #2694 from deploy blockers as this isn't yet a common flow.

[isagoico]

Starting QA!

[isagoico]

Regression is finished!
3 issues found

• Unable to create new group  #2704
• mWeb -Chat - Weird behavior with 3D Touch on chat screen #2705
• [HOLD] New chat / New group animation gets stuck  #2710

PRs are finished too!
2 comments added

• Use the normal pin icon for the LHN #2686 (comment) (looks like expected behaviour but waiting on confirmation)
• Emoji Picker Menu Navigation #2532 (comment) (still not sure if this should be a DB or not)

Thanks!

[isagoico]

Starting QA!

[isagoico]

Regression is finished!
1 issue found today.

1. iOS - Log in - Email input is not scrollable #2726

PRs are finished too.
No comments added 🎉

Thanks!

[isagoico]

Starting QA

[isagoico]

Regression is finished!
No issues or PR comments were added today 🎉

---

This is still reproducible #2704 will wait for the changes to be merged to retest

[roryabraham]

Since we only have one deploy blocker with a fix already merged, and given that our last successful prod deploy was more than 3 weeks ago, we are going to bend the rules a bit here. I'm going to lock this StagingDeployCash, and then we'll wait and see the full list of PRs that were merged while this was locked. If it is just the one that fixes the known deploy blocker, then we'll verify the fix and run the prod deploy. If there were several PRs, we will wait to go through another round of regression testing.

[roryabraham]

Okay, so I just discovered a minor bug here in that the NEW_PULL_REQUESTS input is missing so the new pull requests weren't added to the list. Nonetheless, I did some sleuthing and was able to discover that there were two PRs merged while this checklist was locked today:

1. Add SDK token endpoints for Wallet KYC  #2692 // No QA
2. Fix crash on new chat creation due to undefined sequenceNumber #2721 (comment) // Fixes our deploy blocker

So our plan is a go, assuming that the deploy blocker is resolved

[roryabraham]

Okay, so we verified that the deploy blocker is resolved on all platforms cc @isagoico

Soooo let's do this thang

[roryabraham]