Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow users to create chats with domain accounts #2687

Merged
merged 2 commits into from
May 7, 2021
Merged

Don't allow users to create chats with domain accounts #2687

merged 2 commits into from
May 7, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented May 4, 2021 •
edited
Loading

cc @Beamanator @roryabraham

Details

This PR prevents a user from creating a chat with a domain account email (email that starts with +@).

Fixed Issues

Fixes #2441

Tests/QA Steps

  1. Login to e.cash, click the green + to create a new chat
  2. Type out a valid email that starts with +@, confirm you can't click the row to create a new chat

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Before After
image image

@Jag96 Jag96 self-assigned this May 4, 2021
@Jag96 Jag96 changed the title Don't allow users to create chats with domain accounts [HOLD expensify-common 364] Don't allow users to create chats with domain accounts May 4, 2021
@Jag96 Jag96 changed the title [HOLD expensify-common 364] Don't allow users to create chats with domain accounts Don't allow users to create chats with domain accounts May 7, 2021
@Jag96 Jag96 marked this pull request as ready for review May 7, 2021 00:30
@Jag96 Jag96 requested a review from a team as a code owner May 7, 2021 00:30
@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team May 7, 2021 00:30
johnmlee101
johnmlee101 approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@johnmlee101 johnmlee101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@johnmlee101 johnmlee101 merged commit 3971b96 into main May 7, 2021
@johnmlee101 johnmlee101 deleted the joe-exclude-domain-emails branch May 7, 2021 16:56
@OSBotify OSBotify mentioned this pull request May 7, 2021
Closed
23 tasks
@OSBotify
Copy link
Contributor

OSBotify commented May 7, 2021

🚀 Deployed to staging in version: 1.0.39-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmlee101 johnmlee101 johnmlee101 approved these changes

Assignees

@Jag96 Jag96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New chats where email starts with '+@...' should fail gracefully, with visual feedback
3 participants
@Jag96 @OSBotify @johnmlee101