Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pay 5/10] Android / iOS - Conversation - Email addresses are displayed on header instead of the name #2668

Closed
isagoico opened this issue May 3, 2021 · 8 comments · Fixed by #2676
Assignees
Labels

Comments

@isagoico
Copy link

isagoico commented May 3, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Name of the user is displayed in the header of the conversation

Actual Result:

Email addresses are displayed on header instead of the name

Action Performed:

Break down in numbered steps

Workaround:

No need, visual issue.

Platform:

Where is this issue occurring?

Web
iOS ✔️
Android ✔️
Desktop App
Mobile Web

Version Number: 1.0.35-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

email.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @puneetlath https://expensify.slack.com/archives/C01GTK53T8Q/p1619886233278500

top of the chat is showing the email address instead of name (on iOS)

@isagoico isagoico added DeployBlockerCash This issue or pull request should block deployment AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels May 3, 2021
@MelvinBot
Copy link

Triggered auto assignment to @lschurr (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 3, 2021
@parasharrajat
Copy link
Member

Seems it was missed while refactoring the OptionRowTitle to DisplayNames #2215.

  1. Just Correct the fullTitle to lodashGet(props.report, 'reportName', '') instead of getReportParticipantsTitle(participants) at
    https://github.com/Expensify/Expensify.cash/blob/8a9dcbc1cbcc4200032d5e792394a2c8f74acd27/src/pages/home/HeaderView.js#L96-L102

@roryabraham
Copy link
Contributor

Thanks for helping with this @parasharrajat! Looks like you're right 🙂

@isagoico
Copy link
Author

isagoico commented May 3, 2021

Issue is reproducible in the Android prod app. Removing the blocker label.

@isagoico isagoico removed the DeployBlockerCash This issue or pull request should block deployment label May 3, 2021
@roryabraham
Copy link
Contributor

Thanks @parasharrajat, feel free to submit a PR and I can quickly review

@roryabraham
Copy link
Contributor

@parasharrajat Upwork job is created for this here

@roryabraham
Copy link
Contributor

Solution merged. Assuming no regressions, we will pay out the Upwork contract on May 10th.

@roryabraham roryabraham reopened this May 3, 2021
@roryabraham roryabraham assigned roryabraham and unassigned lschurr May 3, 2021
@roryabraham roryabraham added Weekly KSv2 and removed Daily KSv2 labels May 3, 2021
@roryabraham roryabraham changed the title Android / iOS - Conversation - Email addresses are displayed on header instead of the name [Pay 5/10] Android / iOS - Conversation - Email addresses are displayed on header instead of the name May 3, 2021
@roryabraham
Copy link
Contributor

Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants