Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed reportTiltle in header showing only emails #2676

Merged
merged 1 commit into from
May 3, 2021
Merged

Fixed reportTiltle in header showing only emails #2676

merged 1 commit into from
May 3, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented May 3, 2021 •
edited
Loading

Please review @roryabraham

Details

Fixed Issues

Fixes #2668

Tests / QA Steps

  1. Open Any report on all supported platforms and see the Report Title in the Header. It should show the names of Users.
  2. There is one exception, for some users their Phone numbers or emails are used as titles but not for all reports.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web / Desktop

image

Mobile Web

image

iOS

Image by @roryabraham

image

Android

image

@parasharrajat parasharrajat requested a review from a team as a code owner May 3, 2021 17:37
@MelvinBot MelvinBot requested review from AndrewGable and removed request for a team May 3, 2021 17:38
@parasharrajat
Copy link
Member Author

@roryabraham Screens updated. Thanks.

@roryabraham
Copy link
Contributor

I confirmed that this works on iOS:

image

roryabraham
roryabraham approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@roryabraham roryabraham merged commit e87b9fb into Expensify:main May 3, 2021
@OSBotify
Copy link
Contributor

OSBotify commented May 3, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented May 4, 2021

🚀 Deployed to staging in version: 1.0.36-1🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

@AndrewGable AndrewGable Awaiting requested review from AndrewGable

Assignees

@parasharrajat parasharrajat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pay 5/10] Android / iOS - Conversation - Email addresses are displayed on header instead of the name
3 participants
@parasharrajat @roryabraham @OSBotify