Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitescreen when logging into a different account #3170

Merged
merged 1 commit into from
May 27, 2021

Conversation

alex-mechler
Copy link
Contributor

Details

This once call would cache the results of the report to drop into, regardless of what accounts should have access to it. When logging out and then back into a different account, this would cause a blank screen to load instead of your most recent chat.

See this slack thread for more info: https://expensify.slack.com/archives/C01GTK53T8Q/p1622059995292000

Fixed Issues

Fixes #2659

Tests

  1. Sign into an account
  2. Make note of which chat you are brought to
  3. Sign out
  4. Sign into a different account without refreshing the page.
  5. Verify you are brought to a different chat, and one that you have access to.

QA Steps

  1. Sign into an account
  2. Make note of which chat you are brought to
  3. Sign out
  4. Sign into a different account without refreshing the page.
  5. Verify you are brought to a different chat, and one that you have access to.

Tested On

Mobile platforms all drop into the LHN, so I tested to verify it did not crash, but did not test this PRs specific functionality

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

Mobile platforms all drop into the LHN, so I tested to verify it did not crash, but did not test this PRs specific functionality

Desktop

image

iOS

Mobile platforms all drop into the LHN, so I tested to verify it did not crash, but did not test this PRs specific functionality

Android

Mobile platforms all drop into the LHN, so I tested to verify it did not crash, but did not test this PRs specific functionality

@alex-mechler alex-mechler requested a review from a team May 27, 2021 00:01
@alex-mechler alex-mechler self-assigned this May 27, 2021
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team May 27, 2021 00:01
Copy link
Contributor

@TomatoToaster TomatoToaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find

@TomatoToaster TomatoToaster merged commit 8bc9f93 into main May 27, 2021
@TomatoToaster TomatoToaster deleted the amechler-login-wrong-report branch May 27, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log in - User is taken to a empty conversation without a participant
2 participants