Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-09-05 #26820

Closed
48 tasks done
OSBotify opened this issue Sep 5, 2023 · 19 comments
Closed
48 tasks done

Deploy Checklist: New Expensify 2023-09-05 #26820

OSBotify opened this issue Sep 5, 2023 · 19 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Sep 5, 2023

Release Version: 1.3.64-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mountiny mountiny added the Daily KSv2 label Sep 5, 2023
@mountiny mountiny self-assigned this Sep 5, 2023
@mountiny mountiny added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 5, 2023
@mountiny
Copy link
Contributor

mountiny commented Sep 5, 2023

Checking #26144 off, QAed

@mountiny
Copy link
Contributor

mountiny commented Sep 5, 2023

@mvtglobally I have checked off what was already deployed and QAed before but please double check

@kavimuru
Copy link

kavimuru commented Sep 5, 2023

@mountiny Why is this checked off #26739?

@OSBotify
Copy link
Contributor Author

OSBotify commented Sep 5, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.64-0 🚀

@mvtglobally
Copy link

mvtglobally commented Sep 6, 2023

@mountiny regression is 6% left. Will have update early in the morning

PR #26704 is failing #26827
PR #26708 is failing with the same issue. #26708 (comment)
Can you confirm #26739 is good to check off? You originally did check it, but it doesn't seem to be deployed before. Asked team to double check just on case

@mountiny
Copy link
Contributor

mountiny commented Sep 6, 2023

Can you confirm #26739 is good to check off? You originally did check it, but it doesn't seem to be deployed before. Asked team to double check just on case

Yep that is working fine

@mountiny
Copy link
Contributor

mountiny commented Sep 6, 2023

Checking #26708 off, the found issue is not related to this

@mountiny
Copy link
Contributor

mountiny commented Sep 6, 2023

checking #26739 off, this was validated internally

@mountiny
Copy link
Contributor

mountiny commented Sep 6, 2023

@mvtglobally actually can you just test this one again? #26739 we did confirm internally but does not hurt if you double check, its important flow

@mountiny
Copy link
Contributor

mountiny commented Sep 6, 2023

Checking #26704 off, the linked issue is closed

@mountiny
Copy link
Contributor

mountiny commented Sep 6, 2023

Added 2 CPs to validate.

@mountiny
Copy link
Contributor

mountiny commented Sep 6, 2023

No new crashes and graphs looking good too

@mountiny
Copy link
Contributor

mountiny commented Sep 6, 2023

Checking #26859 off, validated internally

demoting these two blockers as they are repro in production
#26869
#26872

@kavimuru
Copy link

kavimuru commented Sep 6, 2023

@mountiny #26844 is failing #26881

@mountiny
Copy link
Contributor

mountiny commented Sep 6, 2023

Thanks!

@mountiny
Copy link
Contributor

mountiny commented Sep 6, 2023

Everything clear, deploying!

@mountiny
Copy link
Contributor

mountiny commented Sep 6, 2023

:shipit:

@mountiny mountiny closed this as completed Sep 6, 2023
@mvtglobally
Copy link

@mountiny Regression is completed

@mountiny
Copy link
Contributor

mountiny commented Sep 7, 2023

@mvtglobally you probably meant the next checklist right? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants