Style changes to Scanning banner #26509

luacmartins · 2023-09-01T18:34:32Z

Details

Updates the styles of the scanning banner:

Left aligns badge + text
Reduces space between badge + text to 12px
Removes space above badge so that the space between header avatar and label is 12px

Fixed Issues

$ #26111

Tests

Make sure that the design looks correct

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-09-01T19:55:20Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2023-09-01T19:55:32Z

@shawnborton will you please review?

ntdiary · 2023-09-01T22:10:21Z

App/src/styles/styles.js

Line 3860 in 57603a0

maxWidth: 400,

@luacmartins, LGTM, I guess the image full width issue has been fixed by maxWidth? (The links for the last two images in the OP are from the Expensify repo, we can't access them, so not very sure)

Then can I start filling the reviewer checklist? Or should we wait for @shawnborton to take a look first?

ntdiary · 2023-09-02T01:27:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-09-02T01:28:34Z

@cead22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss · 2023-09-04T10:12:57Z

src/components/MoneyRequestHeaderStatusBar.js

-        <View
-            style={[
-                styles.dFlex,
-                styles.flexRow,
-                styles.alignItemsCenter,
-                styles.flexGrow1,
-                styles.justifyContentBetween,
-                styles.overflowHidden,
-                styles.ph5,
-                styles.pv3,
-                styles.borderBottom,
-                styles.w100,
-            ]}
-        >
+        <View style={[styles.dFlex, styles.flexRow, styles.alignItemsCenter, styles.flexGrow1, styles.overflowHidden, styles.ph5, styles.pb3, styles.borderBottom, styles.w100]}>


Not going to block on this, but why? The original is more readable IMO

This should just be the result of prettier, styles.justifyContentBetween is deleted. If we want to keep it readable, we can also use styles.justifyContentStart. 😂

mountiny

Looks like from the requested design

OSBotify · 2023-09-04T10:39:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

shawnborton · 2023-09-04T12:40:03Z

Wow, you guys are fast.

Can we please create a follow up issue to handle the shape/size of the Scanning badge?

The badge itself should only be 28px tall. It should have a border radius of 4px and horizontal padding of 8px.

mountiny · 2023-09-04T12:47:40Z

Like this @shawnborton ?

shawnborton · 2023-09-04T12:52:36Z

Perfect, thanks!

OSBotify · 2023-09-04T16:49:49Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-05T18:42:24Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.63-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-05T19:12:47Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.64-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-06T18:55:22Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.64-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

left align, adjust margin

40360ab

luacmartins self-assigned this Sep 1, 2023

luacmartins added 2 commits September 1, 2023 12:37

rm top padding

98a5839

fix style

326a117

luacmartins marked this pull request as ready for review September 1, 2023 19:55

luacmartins requested a review from a team as a code owner September 1, 2023 19:55

melvin-bot bot removed the request for review from a team September 1, 2023 19:55

melvin-bot bot requested a review from ntdiary September 1, 2023 19:55

luacmartins requested a review from shawnborton September 1, 2023 19:55

ntdiary approved these changes Sep 2, 2023

View reviewed changes

melvin-bot bot requested a review from cead22 September 2, 2023 01:28

mountiny mentioned this pull request Sep 4, 2023

[HOLD for payment 2023-09-12] [$1000] MEDIUM: Polish: Display Receipts in-Chat Design Edits #26111

Closed

Julesssss reviewed Sep 4, 2023

View reviewed changes

Julesssss approved these changes Sep 4, 2023

View reviewed changes

mountiny approved these changes Sep 4, 2023

View reviewed changes

mountiny merged commit d58bc2a into main Sep 4, 2023

mountiny deleted the cmartins-scanStyle branch September 4, 2023 10:33

mountiny mentioned this pull request Sep 4, 2023

Fix style of the scanning badge #26659

Merged

59 tasks

OSBotify mentioned this pull request Sep 4, 2023

Deploy Checklist: New Expensify 2023-09-04 #26686

Closed

35 tasks

OSBotify mentioned this pull request Sep 5, 2023

Deploy Checklist: New Expensify 2023-09-05 #26820

Closed

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Style changes to Scanning banner #26509

Style changes to Scanning banner #26509

luacmartins commented Sep 1, 2023 •

edited

Loading

melvin-bot bot commented Sep 1, 2023

luacmartins commented Sep 1, 2023

ntdiary commented Sep 1, 2023 •

edited

Loading

ntdiary commented Sep 2, 2023

melvin-bot bot commented Sep 2, 2023

Julesssss Sep 4, 2023 •

edited

Loading

ntdiary Sep 4, 2023

mountiny left a comment

OSBotify commented Sep 4, 2023

shawnborton commented Sep 4, 2023

mountiny commented Sep 4, 2023

shawnborton commented Sep 4, 2023

OSBotify commented Sep 4, 2023

OSBotify commented Sep 5, 2023

OSBotify commented Sep 5, 2023

OSBotify commented Sep 6, 2023

Style changes to Scanning banner #26509

Style changes to Scanning banner #26509

Conversation

luacmartins commented Sep 1, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 1, 2023

luacmartins commented Sep 1, 2023

ntdiary commented Sep 1, 2023 • edited Loading

ntdiary commented Sep 2, 2023

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Sep 2, 2023

Julesssss Sep 4, 2023 • edited Loading

Choose a reason for hiding this comment

ntdiary Sep 4, 2023

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 4, 2023

shawnborton commented Sep 4, 2023

mountiny commented Sep 4, 2023

shawnborton commented Sep 4, 2023

OSBotify commented Sep 4, 2023

OSBotify commented Sep 5, 2023

OSBotify commented Sep 5, 2023

OSBotify commented Sep 6, 2023

luacmartins commented Sep 1, 2023 •

edited

Loading

ntdiary commented Sep 1, 2023 •

edited

Loading

Julesssss Sep 4, 2023 •

edited

Loading