fix: 24261 user able to select 2 emoji at a time #24614

tienifr · 2023-08-16T06:26:00Z

Details

Fixed Issues

$ #24261
PROPOSAL: #24261 (comment)

Tests

Tap on a report
Tap on emoji picker in compose box
From smileys&emotion section, select any 2 emoji
The user should be able to select only one emoji at a time

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Tap on a report
Tap on emoji picker in compose box
From smileys&emotion section, select any 2 emoji
The user should be able to select only one emoji at a time

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-16.at.12.09.33.mov

Mobile Web - Chrome

original-527B526D-1C1D-4F4C-9F0F-43CCBAB3501B.mp4

Mobile Web - Safari

original-AAE70EF4-5107-4C03-915B-F30C7B8CB825.mp4

Desktop

Screen.Recording.2023-08-16.at.12.26.27.mov

iOS

Uploading Screen Recording 2023-08-16 at 15.20.10.mov…

Android

Screen.Recording.2023-08-16.at.13.52.28.mov

melvin-bot · 2023-08-16T08:24:45Z

@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2023-08-17T05:14:47Z

@robertKozik Can you help take a look at my PR?

tienifr · 2023-08-18T02:45:54Z

@robertKozik any updates?

robertKozik · 2023-08-18T07:07:22Z

Today, I'll review your PR. I apologize for any inconvenience; a few tasks have piled up on my end.

robertKozik · 2023-08-18T07:10:48Z

BTW @tienifr don't we want to wait for merge of your previous issue with useSingleExecution #24173? I believe the conflicts will come out for one of these two

tienifr · 2023-08-18T08:22:57Z

@robertKozik Got it, but useSingleExecution in 2 PRs are almost the same. So I think we can process this PR without caring that much about #24173. Otherwise we should put this PR on hold.

robertKozik · 2023-08-22T08:41:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android.-.web.mov

Mobile Web - Safari

ios.-.web.mov

Desktop

desktop.mov

iOS

ios.native.mov

Android

Screen.Recording.2023-08-22.at.12.36.54.mov

robertKozik

LGTM, let's push it forward 🚀

robertKozik · 2023-08-22T15:20:13Z

@marcochavezf @tienifr I think we should wait with merge for #24173 to be sure the ref solution inside useSingleExecution won't get overwritten

tienifr · 2023-08-26T18:30:40Z

#24173 has been merged and I think we're ready to push this forward @marcochavezf @robertKozik

bernhardoj · 2023-08-28T13:51:56Z

src/hooks/useSingleExecution.js

-                    setIsExecuting(false);
+
+                setIsExecuting(true);
+


@tienifr Hi, we are planning to use this hook in this issue and I'm expecting the isExecutingRef to be updated immediately on click instead of on each render. Is there any specific reason for that?

isExecutingRef is updated right after singleExecution is executed. Why do you think it's updated on each render?

Because the isExecutingRef.current is updated at line 13 which I guess will be updated when useSingleExecution function is invoked again on a re-render.

I expect it to look like this:

setIsExecuting(true); isExecutingRef.current = true;

CMIIW

@bernhardoj Thanks for your suggestion. I totally agree with your idea. Updated the PR

tienifr · 2023-08-30T02:37:59Z

@robertKozik Pls take a look at this PR when you have a chance. Thanks

robertKozik · 2023-08-30T21:57:47Z

@tienifr I'm okay with that change 👌🏼 The suggestion looks more inline with the intent of this hook. I've tested it briefly and I didn't find any regression after this change

robertKozik · 2023-08-30T21:59:38Z

@marcochavezf bumping as the PR introducing the useSingleExecution hook is already merged

marcochavezf · 2023-09-04T00:44:12Z

Thanks guys, LGTM

OSBotify · 2023-09-04T00:50:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-04T16:50:07Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-05T18:42:42Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.63-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-05T19:13:08Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.64-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-06T18:55:43Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.64-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jjcoffee · 2023-09-18T16:26:06Z

src/hooks/useSingleExecution.js

+
+                setIsExecuting(true);
+
+                const execution = action(params);


@tienifr Any reason why we're not spreading params here?

jjcoffee · 2023-10-05T08:11:32Z

Just noting that this PR caused a regression in the emoji picker due to not spreading the params here

App/src/hooks/useSingleExecution.js

Line 25 in d494433

const execution = action(params);

This caused the selected emoji to unexpectedly come through as an array. More details here.

tienifr added 4 commits August 16, 2023 12:00

fix: 24261 user able to select 2 emoji at a time

9906b56

fix: update hook

28c5a5d

fix: update use single execution hook

331c5a8

reset -podfile

d3b053f

tienifr marked this pull request as ready for review August 16, 2023 08:24

tienifr requested a review from a team as a code owner August 16, 2023 08:24

melvin-bot bot requested review from robertKozik and removed request for a team August 16, 2023 08:24

tienifr mentioned this pull request Aug 16, 2023

[HOLD for payment 2023-09-12] [$1000] Compose Box - User able to select 2 emoji at a time #24261

Closed

6 tasks

eVoloshchak mentioned this pull request Aug 22, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$2000] Unable to change the currency after double-clicking on the current currency #22497

Closed

6 tasks

robertKozik approved these changes Aug 22, 2023

View reviewed changes

melvin-bot bot requested a review from marcochavezf August 22, 2023 15:19

Merge branch 'main' into fix/24261

7d33ab7

bernhardoj reviewed Aug 28, 2023

View reviewed changes

fix: update use single execution logic

b8a58ae

marcochavezf approved these changes Sep 4, 2023

View reviewed changes

marcochavezf merged commit 4676492 into Expensify:main Sep 4, 2023

OSBotify mentioned this pull request Sep 4, 2023

Deploy Checklist: New Expensify 2023-09-04 #26686

Closed

35 tasks

lanitochka17 mentioned this pull request Sep 4, 2023

[HOLD for payment 2023-10-12] [$500] Chat - Space is not added after an emoji is selected #26709

Closed

6 tasks

OSBotify mentioned this pull request Sep 5, 2023

Deploy Checklist: New Expensify 2023-09-05 #26820

Closed

48 tasks

This was referenced Sep 7, 2023

[$500] User can unpin a report and mark it as unread/read simultaneously. #26917

Closed

[$500] Android - When you click on 'account' and 'amount' right after each other, the amount value gets cut off #27259

Closed

jjcoffee reviewed Sep 18, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 24261 user able to select 2 emoji at a time #24614

fix: 24261 user able to select 2 emoji at a time #24614

tienifr commented Aug 16, 2023 •

edited

Loading

melvin-bot bot commented Aug 16, 2023

tienifr commented Aug 17, 2023

tienifr commented Aug 18, 2023

robertKozik commented Aug 18, 2023

robertKozik commented Aug 18, 2023

tienifr commented Aug 18, 2023

robertKozik commented Aug 22, 2023 •

edited

Loading

robertKozik left a comment

robertKozik commented Aug 22, 2023 •

edited

Loading

tienifr commented Aug 26, 2023

bernhardoj Aug 28, 2023

tienifr Aug 29, 2023

bernhardoj Aug 29, 2023

tienifr Aug 29, 2023

tienifr commented Aug 30, 2023

robertKozik commented Aug 30, 2023

robertKozik commented Aug 30, 2023

marcochavezf commented Sep 4, 2023

OSBotify commented Sep 4, 2023

OSBotify commented Sep 4, 2023

OSBotify commented Sep 5, 2023

OSBotify commented Sep 5, 2023

OSBotify commented Sep 6, 2023

jjcoffee Sep 18, 2023

jjcoffee commented Oct 5, 2023

fix: 24261 user able to select 2 emoji at a time #24614

fix: 24261 user able to select 2 emoji at a time #24614

Conversation

tienifr commented Aug 16, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 16, 2023

tienifr commented Aug 17, 2023

tienifr commented Aug 18, 2023

robertKozik commented Aug 18, 2023

robertKozik commented Aug 18, 2023

tienifr commented Aug 18, 2023

robertKozik commented Aug 22, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

robertKozik left a comment

Choose a reason for hiding this comment

robertKozik commented Aug 22, 2023 • edited Loading

tienifr commented Aug 26, 2023

bernhardoj Aug 28, 2023

Choose a reason for hiding this comment

tienifr Aug 29, 2023

Choose a reason for hiding this comment

bernhardoj Aug 29, 2023

Choose a reason for hiding this comment

tienifr Aug 29, 2023

Choose a reason for hiding this comment

tienifr commented Aug 30, 2023

robertKozik commented Aug 30, 2023

robertKozik commented Aug 30, 2023

marcochavezf commented Sep 4, 2023

OSBotify commented Sep 4, 2023

OSBotify commented Sep 4, 2023

OSBotify commented Sep 5, 2023

OSBotify commented Sep 5, 2023

OSBotify commented Sep 6, 2023

jjcoffee Sep 18, 2023

Choose a reason for hiding this comment

jjcoffee commented Oct 5, 2023

tienifr commented Aug 16, 2023 •

edited

Loading

robertKozik commented Aug 22, 2023 •

edited

Loading

robertKozik commented Aug 22, 2023 •

edited

Loading