-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 24261 user able to select 2 emoji at a time #24614
Merged
marcochavezf
merged 6 commits into
Expensify:main
from
tienifr:fix/24261-user-able-to-select-2-emoji-at-a-time
Sep 4, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9906b56
fix: 24261 user able to select 2 emoji at a time
tienifr 28c5a5d
fix: update hook
tienifr 331c5a8
fix: update use single execution hook
tienifr d3b053f
reset -podfile
tienifr 7d33ab7
Merge branch 'main' into fix/24261
tienifr b8a58ae
fix: update use single execution logic
tienifr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
import {InteractionManager} from 'react-native'; | ||
import {useCallback, useState} from 'react'; | ||
import {useCallback, useState, useRef} from 'react'; | ||
|
||
/** | ||
* With any action passed in, it will only allow 1 such action to occur at a time. | ||
|
@@ -8,27 +8,32 @@ import {useCallback, useState} from 'react'; | |
*/ | ||
export default function useSingleExecution() { | ||
const [isExecuting, setIsExecuting] = useState(false); | ||
const isExecutingRef = useRef(); | ||
|
||
const singleExecution = useCallback( | ||
(action) => () => { | ||
if (isExecuting) { | ||
return; | ||
} | ||
|
||
setIsExecuting(true); | ||
isExecutingRef.current = isExecuting; | ||
|
||
const execution = action(); | ||
InteractionManager.runAfterInteractions(() => { | ||
if (!(execution instanceof Promise)) { | ||
setIsExecuting(false); | ||
const singleExecution = useCallback( | ||
(action) => | ||
(...params) => { | ||
if (isExecutingRef.current) { | ||
return; | ||
} | ||
execution.finally(() => { | ||
setIsExecuting(false); | ||
|
||
setIsExecuting(true); | ||
isExecutingRef.current = true; | ||
|
||
const execution = action(params); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @tienifr Any reason why we're not spreading |
||
InteractionManager.runAfterInteractions(() => { | ||
if (!(execution instanceof Promise)) { | ||
setIsExecuting(false); | ||
return; | ||
} | ||
execution.finally(() => { | ||
setIsExecuting(false); | ||
}); | ||
}); | ||
}); | ||
}, | ||
[isExecuting], | ||
}, | ||
[], | ||
); | ||
|
||
return {isExecuting, singleExecution}; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tienifr Hi, we are planning to use this hook in this issue and I'm expecting the
isExecutingRef
to be updated immediately on click instead of on each render. Is there any specific reason for that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isExecutingRef
is updated right aftersingleExecution
is executed. Why do you think it's updated on each render?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the
isExecutingRef.current
is updated at line 13 which I guess will be updated whenuseSingleExecution
function is invoked again on a re-render.I expect it to look like this:
CMIIW
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bernhardoj Thanks for your suggestion. I totally agree with your idea. Updated the PR