[HOLD for payment 2023-11-01] [$500] The error message does not close in one click if the address dropdown is open.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1,3,80,0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696764596197229

Action Performed:

1. Go to the staging environment.
2. Open the FAB icon and select the "Request Money" option.
3. Navigate to the distance tab and click on "Start."
4. Trigger an error message by selecting "use current location" and denying access.
5. Open the dropdown by clicking on the address input and entering a few characters.
6. Attempt to close the error message by clicking the close button on the error.
7. Observe that the dropdown is closed, but the error message remains open.

Expected Result:

The error message should be removed with a single click just like in native devices

Actual Result:

Attempting to close the error results in the dropdown closing, but the error message persists.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

bug.mp4

iOS: Native

iOS: mWeb Safari

Screen.Recording.2023-10-08.at.4.58.24.PM.mov

MacOS: Chrome / Safari

Recording.4914.mp4

bug.mp4

MacOS: Desktop

Screen.Recording.2023-10-08.at.4.48.49.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019bb896d532ae6056
• Upwork Job ID: 1712446430446161920
• Last Price Increase: 2023-10-12
• Automatic offers:
• ntdiary | Reviewer | 27266011
• bernhardoj | Contributor | 27266013
• aman-atg | Reporter | 27266014

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019bb896d532ae6056

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[Samueljh1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error message does not close in one click if the address dropdown is open.

What is the root cause of that problem?

The dropdown menu is preventing click/touch events from bubbling down to other components.

What changes do you think we should make in order to solve the problem?

Modify code in the dropdown menu to ensure click events are passed down to other components.

What alternative solutions did you explore? (Optional)

N/A

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error message does not close in one click if the address dropdown is open.

What is the root cause of that problem?

in react-native-google-places-autocomplete plugin when input box blur triggered time flat list is hidden so at the time next event is not triggering
https://github.com/FaridSafi/react-native-google-places-autocomplete/blob/ef107387c6846924423b832a242eee83cb07eed4/GooglePlacesAutocomplete.js#L721

What changes do you think we should make in order to solve the problem?

https://github.com/FaridSafi/react-native-google-places-autocomplete/blob/ef107387c6846924423b832a242eee83cb07eed4/GooglePlacesAutocomplete.js#L725
here we need to set into set timeout

Result

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

While the address suggestion is showing, pressing the location error close button will close the suggestion but not clear the error.

What is the root cause of that problem?

This is the same issue as #12715. When we touch down the close button, it will immediately blur the address input closing the suggestion list and shifting the location error message & button position up, so the press callback is not fired.

What changes do you think we should make in order to solve the problem?

We can use the same solution as #12715 by preventing the blur when touching the close button using preventDefault here.

App/src/components/LocationErrorMessage/BaseLocationErrorMessage.js

Lines 60 to 67 in f942acd

	<PressableWithoutFeedback
	onPress={onClose}
	style={[styles.touchableButtonImage]}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}
	accessibilityLabel={translate('common.close')}
	>
	<Icon src={Expensicons.Close} />
	</PressableWithoutFeedback>

onMouseDown={e => e.preventDefault()}

or just do nothing

[melvin-bot]

@JmillsExpensify, @ntdiary Whoops! This issue is 2 days overdue. Let's get this updated quick!

[JmillsExpensify]

@ntdiary Thoughts on the proposals so far?

[ntdiary]

@bernhardoj's proposal looks good to me, it's straightforward for these layout shift issues. Additionally, I'm not exactly sure if we are interested in implementing this on generic components(e.g. GenericPressable), and then add a prop (e.g. shouldPreventFocus) to control whether to enable it.

Btw, @Samueljh1, @pradeepmdk, please use your own words in the Please re-state the problem... section in the future (do not copy the issue title). : )

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @ntdiary 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @aman-atg 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @ntdiary

[melvin-bot]

🎯 ⚡️ Woah @ntdiary / @bernhardoj, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @bernhardoj got assigned: 2023-10-18 20:06:22 Z
• when the PR got merged: 2023-10-23 17:50:54 UTC

On to the next one 🚀

[JmillsExpensify]

PR merged. Waiting for it to hit production and start the regression hold.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.90-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix can't close location error message while address suggestion dropdown is open #29932

If no regressions arise, payment will be issued on 2023-11-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ntdiary requires payment offer (Reviewer)
• @bernhardoj requires payment offer (Contributor)
• @aman-atg requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ntdiary] Determine if we should create a regression test for this bug.
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[JmillsExpensify]

@ntdiary Mind kicking off the BZ checklist?

[JmillsExpensify]

In the meantime, payment summary:

• Issue reporter: @aman-atg $50
• Contributor: @bernhardoj $750 (incl. urgency bonus)
• Contributor+: @ntdiary $500 (incl. urgency bonus)

[ntdiary]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: Allow user to get current location #25990
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/25990/files#r1372692571
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• [@ntdiary] Determine if we should create a regression test for this bug. No need
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. No need
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Just a minor feature polish, no need to add regression test.
Hey, @JmillsExpensify, very happy to work on issues with you again. I still remember the previous comment, so here it's fine to just pay me $500. 😄

[tylerkaraszewski]

Doesn't need to be overdue.

[melvin-bot]

@tylerkaraszewski, @JmillsExpensify, @ntdiary, @bernhardoj Whoops! This issue is 2 days overdue. Let's get this updated quick!

[JmillsExpensify]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: Allow user to get current location #25990
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/25990/files#r1372692571
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• [@ntdiary] Determine if we should create a regression test for this bug. No need
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. No need
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Just a minor feature polish, no need to add regression test. Hey, @JmillsExpensify, very happy to work on issues with you again. I still remember the previous comment, so here it's fine to just pay me $500. 😄

Thanks!

[JmillsExpensify]

Everyone paid out based on summary above. Closing.