Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to get current location #25990
Allow user to get current location #25990
Changes from all commits
fc04db7
5fec130
7465ef1
5f11209
8ab688f
ffb3138
31658da
d73335a
312cff2
d7bd1ea
a12968e
9bf0236
f371f95
14494b9
6403a08
348fc5c
0fd62fc
c582e75
24dfaf7
90e5866
2633ae3
3b9fe10
ca04daf
3bd4faf
ee60ec3
72fc797
86b61b7
3856f7f
4dea2d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure that you need this - it will be undefined by default itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, I think it's not needed. Removed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I added it back, the lint was failing (we need to add to satisfy the linter)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming from #29433.
If the address input is focused, pressing the mouse on this button will trigger
blur
and hide the autocomplete component, causing this button to move up (layout shift), thus causing the click event to fail to be triggered on this button.We add
onMouseDown={e => e.preventDefault()}
to preventblur
event.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can start using hooks instead of HOCs - just add in function const {translate} = useLocalize();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replied here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use useLocalize hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually since
UserCurrentLocationButton
is nested inside theForm
component here, it was giving hooks error (react rules of hook realted). I made an assumption here that theUserCurrentLocationButton
might be used in other places and maybe inside Form too, so didn't use the localize hook.