[HOLD for payment 2023-11-30] [$125] Deeplink access of user notify me page and back opens wrong page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.81.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697014098088459

Action Performed:

1. Open the app
2. Open any user report
3. Click on header and click on notify me
4. Copy the URL and paste in any report
5. (For devices without access to URL like native app, we will need to perform step 1 to 4 in device with URL access) Click on the URL
6. Click on back and observe that instead of opening user details page, it opens room settings and displays user as room

Expected Result:

App should navigate back to user profile on back from notification preference page

Actual Result:

App navigates back to room settings instead of user profile on back from notification preference page when accessed by deep link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Screen_Recording_20231011_140427_New.Expensify.1.mp4

Android: mWeb Chrome

android.chrome.click.on.URL.and.back.wrong.page.mp4

iOS: Native

RPReplay_Final1697047170.1.MP4

iOS: mWeb Safari

ios.safari.click.on.URL.and.back.wrong.page.mov

MacOS: Chrome / Safari

windows.chrome.back.from.notification.preference.not.working.mp4

double.slashes.not.handled.in.URL.mp4

MacOS: Desktop

mac.desktop.back.is.wrong.notify.me.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0169068d72e6fa963b
• Upwork Job ID: 1719332158598991872
• Last Price Increase: 2023-11-07
• Automatic offers:
• ishpaul777 | Contributor | 27600164
• dhanashree-sawant | Reporter | 27600166

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0169068d72e6fa963b

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[melvin-bot]

Upwork job price has been updated to $125

[ishpaul777]

Proposal

Problem

Deeplink access of user notify me page and back opens wrong page

Root Cause

This happens because in Notification pref. page, when back button is clicked we navigate user to report settings page not user profile page

Solution

Instead of linking to a report details we should check if the report is 1:1 DM and in that case navigate user to user details.

what we can do is use the utility isOneOnOneChat from your PR and create a new utility goBackToDetailsPage and use the same in notification page when user select a option or click the back icon.

/**
 * Goback to the details page of a given report
 *
 * @param {Object} report
 */
function goBackToDetailsPage(report){
    if (isOneOnOneChat(report)) {
        Navigation.goBack(ROUTES.PROFILE.getRoute(report.participantAccountIDs[0]));
    } else if (report.reportID) {
        Navigation.goBack(ROUTES.REPORT_SETTINGS.getRoute(report.reportID))
    }
};

[bernhardoj]

After this PR is merged, we can just use ReportUtils.navigateToDetailsPage

[melvin-bot]

@adelekennedy, @robertKozik Whoops! This issue is 2 days overdue. Let's get this updated quick!

[robertKozik]

@bernhardoj Do you want to write the proposal for it?

[bernhardoj]

Oh, that's actually a suggestion for @ishpaul777 proposal so we don't end up creating a redundant function.

[ishpaul777]

@bernhardoj Please correct me if i am wrong but i think navigateToDetailsPage will navigate to the details page while we want is to goBack in navigation. Right?

Screen.Recording.2023-11-04.at.4.51.59.PM.mov

what we can do is use the utility isOneOnOneChat from your PR and create a new utility goBackToDetailsPage and use the same in notification page when user select a option or click the back icon.

[bernhardoj]

Oh, you're right, my bad.

[robertKozik]

isOneOnOneChat function seems more future-proof and robust for me. @ishpaul777 could you update tour original proposal with suggestions you form in later comment? After that I think the proposal will be ready to go 🚀

[ishpaul777]

done! 🚀

PROPOSAL UPDATED

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[adelekennedy]

@ishpaul777 proposal has been updated - @robertKozik will review

[robertKozik]

Thank you @ishpaul777! Your proposal is ready to go.

🎀 👀 🎀 C+ reviewed

[marcaaron]

Ok so the navigation code does handle it. And we just provided the wrong "fallback". Got it. Thanks guys!

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[marcaaron]

@robertKozik @ishpaul777 I am going OOO this next week. If we need a new reviewer please ask in Slack! Otherwise I will look at this as soon as I return. 🤙

[robertKozik]

@ishpaul777 how is the PR going?

[ishpaul777]

Will raise a pr today! Sorry for delay

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fixes wrong fallback for goback in notification preference page #31287

If no regressions arise, payment will be issued on 2023-11-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @robertKozik does not require payment (Contractor)
• @ishpaul777 requires payment offer (Contributor)
• @dhanashree-sawant requires payment offer (Reporter)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[adelekennedy]

Payouts due:

Issue Reporter: $50 @dhanashree-sawant ( reporting bonus stopped on the 24th but this was reported on the 11th)
Contributor: $125 @ishpaul777

Upwork job is here.

[adelekennedy]

@robertKozik any steps needed for the BZ checklist or can we close?

[robertKozik]

Sorry for delay on my end @adelekennedy 🙇🏼 I don't think we need regression test here

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: It's not a regression rather the not handled properly navigation case
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@robertKozik] Determine if we should create a regression test for this bug. I don't think it's needed here
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A