-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pressing the task report (with assignee) header opens the assignee profile page #30452
Fix pressing the task report (with assignee) header opens the assignee profile page #30452
Conversation
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bernhardoj There seems to be some problem with isOneOnOneChat
function. Can you check any one-one chat and fix this?
@shubham1206agra thanks for catching that. I totally missed testing the 1:1 chat itself. In Lines 3161 to 3163 in 5b5d465
but this value actually doesn't exist on a report, but comes from Line 505 in 5b5d465
This works fine because we pass the result from That's why in the status emoji PR, they have a problem where Line 3162 in 5b5d465
Line 358 in 5b5d465
I have fixed and tested on both 1:1 and task chat and it works fine now. |
@bernhardoj Can you check that the status functionality works fine now? |
@shubham1206agra yes, it only shows on 1:1 chat |
Can you please put a short video? |
here you go. You can see that when the |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2023-10-31.at.4.49.51.PM.movAndroid: mWeb ChromeScreen.Recording.2023-10-31.at.11.31.00.AM.moviOS: NativeScreen.Recording.2023-10-31.at.3.52.06.PM.moviOS: mWeb SafariScreen.Recording.2023-10-31.at.3.31.50.PM.movMacOS: Chrome / SafariScreen.Recording.2023-10-31.at.11.20.19.AM.movMacOS: DesktopScreen.Recording.2023-10-31.at.3.36.36.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code looks good to me 👍
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.94-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.94-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀
|
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.95-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀
|
Details
Pressing the task report (with assignee) header opens the assignee profile page instead of the report details page.
Fixed Issues
$ #30182
PROPOSAL: #30182 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2023-10-27.at.00.07.22.mov
Android: mWeb Chrome
Screen.Recording.2023-10-27.at.00.00.06.mov
iOS: Native
Screen.Recording.2023-10-26.at.23.58.55.mov
iOS: mWeb Safari
Screen.Recording.2023-10-26.at.23.59.40.mov
MacOS: Chrome / Safari
Screen.Recording.2023-10-26.at.23.55.02.mov
MacOS: Desktop
Screen.Recording.2023-10-26.at.23.56.56.mov