[HOLD for payment 2023-11-30] [CRITICAL] Migrate the BaseAutoCompleteSuggestions to Flashlist

[mountiny]

Part of #28902

Let's migrate BaseAutoCompleteSuggestions to use Flashlist component instead of FlatList

Callstack is working on the migration right now.

Lets use this issue for daily updates on this migration

Issue Owner

Current Issue Owner: @adhorodyski

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[adhorodyski]

Hi, I'm Adam from Callstack. I'd like to work on this :)

[roryabraham]

I will await a PR. Do you expect to make daily progress on this issue?

[adhorodyski]

Not really, imo this could be set to weekly. Linking an android issue that I'd have to work around for reference (with nesting gesture scopes): software-mansion/react-native-gesture-handler#2582

[mountiny]

@adhorodyski if there is anything you need to help with the gesture handler, we can bring it up in slack and hook in SWM people to work on the issue

[adhorodyski]

Oh sure, let me open up a PR which works I think everywhere except for Android.

[adhorodyski]

@mountiny I'm not really familiar with the way a FlashList should be wrapped using react-native-gesture-handler primitives - I think we can save a lot of time to get SWM into this. Could you please help with that?

Other than that I think this component's migration is pretty straightforward and we can shortly close it :)

I linked my branch with the base migration done under #31057

[mountiny]

thread is here https://expensify.slack.com/archives/C05LX9D6E07/p1699460749625439

[adhorodyski]

Now awaiting a C+ review in #31057 :)

[Christinadobrzyn]

I'm going ooo until Monday Nov 27th so going to assign another BZ teammate to monitor this until I'm back. Thanks!

Status: reviewing PR

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• refactor(28902): migrate BaseAutoCompleteSuggestions from flatlist to flashlist #31057

If no regressions arise, payment will be issued on 2023-11-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @adhorodyski does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@roryabraham] The PR that introduced the bug has been identified. Link to the PR:
• [@roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@adhorodyski] Determine if we should create a regression test for this bug.
• [@adhorodyski] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Current assignees @jliexpensify and @Christinadobrzyn are eligible for the NewFeature assigner, not assigning anyone new.

[roryabraham]

New feature, not a bug

[roryabraham]

@robertKozik was C+ so will invoice us separately. Same for @adhorodyski

So we can close this