chore: memoed renderItem on emoji and mention suggestion lists #31703

adhorodyski · 2023-11-22T14:10:05Z

Details

This is a followup PR to the Flashlist migration on BaseAutoCompleteSuggestions under #31057 - it ensures renderItem functions are wrapped with useCallback for MentionSuggestions and EmojiSuggestions lists.

Fixed Issues

$ #30912
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

To be added.

Android: Native

android.mp4

Android: mWeb Chrome

android_mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios_mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2023-11-23T12:13:01Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

alitoshmatov · 2023-11-24T10:05:08Z

Reviewing

roryabraham · 2023-11-26T14:23:22Z

src/components/EmojiSuggestions.tsx

+                </View>
+            );
+        },
+        [styles, prefix, preferredSkinToneIndex],


The styles object is quite large. Do you think that matters when including it in a dependency array? Would it be better to include all the used styles in the dependency array separately?

It depends on the reference stability - we recreate this object each time the theme changes, so each separate style will also change. In this case it's cheaper to run fewer equality checks (the whole styles there).

adhorodyski · 2023-11-28T10:45:27Z

Hey there @alitoshmatov 👋 Is there any way I can help you with the review in here? Let me know!

alitoshmatov · 2023-11-28T10:48:51Z

Sorry, all good, missed this one. I will review this today.

alitoshmatov · 2023-11-28T17:09:48Z

I am facing this issue where mention suggestion is not closing even after choosing an email, also it is only happening in few selected emails. I couldn't reproduce this in main, staging and prod.

@adhorodyski Can you retest it. I couldn't find exact root cause here

Screen.Recording.2023-11-28.at.22.05.40.mov

adhorodyski · 2023-11-29T12:04:22Z

@alitoshmatov I'm able to reproduce this on main, also only on the very same email you've tried. Tracking the regression now.

adhorodyski · 2023-11-30T14:40:59Z

@alitoshmatov could you please give it another try? I've retested this multiple time for your & my emails (only these 2 were reproducible on both this branch and main yesterday) and looks like the problem is now gone. Doesn't look related to this PR then :)

adhorodyski · 2023-11-30T14:42:25Z

#32214 seems related

alitoshmatov · 2023-11-30T16:24:49Z

Thank you, reviewing

alitoshmatov · 2023-11-30T17:05:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/59907218/7b9af8ab-dc81-4d47-b90c-7a4462d4a12c

Android: mWeb Chrome

menu-android.mov

iOS: Native

menu-ios.mp4

iOS: mWeb Safari

menu-safari.mp4

MacOS: Chrome / Safari

menu-web.mov

MacOS: Desktop

menu-desktop.mov

alitoshmatov

LGTM!

roryabraham · 2023-11-30T19:41:31Z

Looks like we have merge conflicts here

adhorodyski · 2023-12-01T10:59:05Z

Yeah, on it!

…uggestions

adhorodyski · 2023-12-01T11:05:31Z

@roryabraham I've rebased & retested the proposed solution :)

OSBotify · 2023-12-01T21:46:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

alitoshmatov · 2023-12-02T07:21:33Z

@roryabraham Can you assign me to corresponding issue so that we can handle payment after regression period is over

OSBotify · 2023-12-05T02:56:02Z

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-12-05T13:41:07Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.8-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

roryabraham · 2023-12-05T15:14:28Z

@alitoshmatov can you post in Contributor+ about this and tag me? I'm going to be AFK most of today and I want to make sure this doesn't slip through the cracks. We probably need to create a separate issue for your payment

OSBotify · 2023-12-06T20:31:12Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T20:40:44Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

adhorodyski mentioned this pull request Nov 22, 2023

refactor(28902): migrate BaseAutoCompleteSuggestions from flatlist to flashlist #31057

Merged

58 tasks

adhorodyski marked this pull request as ready for review November 23, 2023 12:12

adhorodyski requested a review from a team as a code owner November 23, 2023 12:12

melvin-bot bot requested review from alitoshmatov and removed request for a team November 23, 2023 12:12

roryabraham reviewed Nov 26, 2023

View reviewed changes

adhorodyski force-pushed the adhorodyski/refactor/flashlist-migration-bacs branch from aefa6c4 to c5c3fb6 Compare November 30, 2023 14:39

alitoshmatov approved these changes Nov 30, 2023

View reviewed changes

melvin-bot bot requested a review from roryabraham November 30, 2023 17:06

chore: ensure stable references on renderItem for emoji and mention s…

9070a4e

…uggestions

adhorodyski force-pushed the adhorodyski/refactor/flashlist-migration-bacs branch from c5c3fb6 to 9070a4e Compare December 1, 2023 11:02

roryabraham approved these changes Dec 1, 2023

View reviewed changes

roryabraham merged commit 414c08c into Expensify:main Dec 1, 2023
15 checks passed

adhorodyski deleted the adhorodyski/refactor/flashlist-migration-bacs branch December 1, 2023 23:06

github-actions bot mentioned this pull request Dec 5, 2023

Deploy Checklist: New Expensify 2023-12-05 #32463

Closed

66 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: memoed renderItem on emoji and mention suggestion lists #31703

chore: memoed renderItem on emoji and mention suggestion lists #31703

adhorodyski commented Nov 22, 2023 •

edited

Loading

melvin-bot bot commented Nov 23, 2023

alitoshmatov commented Nov 24, 2023

roryabraham Nov 26, 2023

adhorodyski Nov 27, 2023

adhorodyski commented Nov 28, 2023

alitoshmatov commented Nov 28, 2023

alitoshmatov commented Nov 28, 2023

adhorodyski commented Nov 29, 2023

adhorodyski commented Nov 30, 2023

adhorodyski commented Nov 30, 2023

alitoshmatov commented Nov 30, 2023

alitoshmatov commented Nov 30, 2023

alitoshmatov left a comment

roryabraham commented Nov 30, 2023

adhorodyski commented Dec 1, 2023

adhorodyski commented Dec 1, 2023

OSBotify commented Dec 1, 2023

alitoshmatov commented Dec 2, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 5, 2023

roryabraham commented Dec 5, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

chore: memoed renderItem on emoji and mention suggestion lists #31703

chore: memoed renderItem on emoji and mention suggestion lists #31703

Conversation

adhorodyski commented Nov 22, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 23, 2023

alitoshmatov commented Nov 24, 2023

roryabraham Nov 26, 2023

Choose a reason for hiding this comment

adhorodyski Nov 27, 2023

Choose a reason for hiding this comment

adhorodyski commented Nov 28, 2023

alitoshmatov commented Nov 28, 2023

alitoshmatov commented Nov 28, 2023

adhorodyski commented Nov 29, 2023

adhorodyski commented Nov 30, 2023

adhorodyski commented Nov 30, 2023

alitoshmatov commented Nov 30, 2023

alitoshmatov commented Nov 30, 2023

Reviewer Checklist

Screenshots/Videos

alitoshmatov left a comment

Choose a reason for hiding this comment

roryabraham commented Nov 30, 2023

adhorodyski commented Dec 1, 2023

adhorodyski commented Dec 1, 2023

OSBotify commented Dec 1, 2023

alitoshmatov commented Dec 2, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 5, 2023

roryabraham commented Dec 5, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

adhorodyski commented Nov 22, 2023 •

edited

Loading