Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-20] [$500] Copy to Clipboard- Email displayed inconsistently in mweb and Android #30985

Closed
2 of 6 tasks
izarutskaya opened this issue Nov 7, 2023 · 50 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@izarutskaya
Copy link

izarutskaya commented Nov 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.96-9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

  1. Launch app
  2. Tap on a report
  3. Send the mail applausetester+06075lsn@applause.expensifail.com
  4. Long press the message sent and note the email displayed in copy to clipboard section
  5. Go to https://staging.new.expensify.com/
  6. Repeat step 2 -- step 4

Expected Result:

In Copy to clipboard section, in both mweb and Android, email should be displayed in the same format in a consistent manner.

Actual Result:

Copy to clipboard section in(.com) shows till "c" in one line (applausetester+06075lsn@

applause.expensifail.c
om) in mweb and shows(.com) in second line (applausetester+06075lsn@

applause.expensifail
.com) in Android.

The displayed email format differs and it is inconsistent in mweb and Android.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6267016_1699346542274.mail.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0123a768f29d8cc1b6
  • Upwork Job ID: 1721861002279923712
  • Last Price Increase: 2023-11-07
Issue OwnerCurrent Issue Owner: @kevinksullivan
@izarutskaya izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 7, 2023
@melvin-bot melvin-bot bot changed the title Copy to Clipboard- Email displayed inconsistently in mweb and Android [$500] Copy to Clipboard- Email displayed inconsistently in mweb and Android Nov 7, 2023
Copy link

melvin-bot bot commented Nov 7, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0123a768f29d8cc1b6

Copy link

melvin-bot bot commented Nov 7, 2023

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 7, 2023
Copy link

melvin-bot bot commented Nov 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 7, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@artus9033
Copy link
Contributor

Hi, I'm Artur from Callstack - expert contributor group - and I would like to work on this issue.

Copy link

melvin-bot bot commented Nov 8, 2023

📣 @artus9033! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Copy link

melvin-bot bot commented Nov 8, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@mananjadhav
Copy link
Collaborator

Thanks for the interest @artus9033. Can you post a small proposal with what changes so that we're aligned.

🎀 👀 🎀 C+ reviewed.

Copy link

melvin-bot bot commented Nov 8, 2023

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Julesssss
Copy link
Contributor

Getting Callstack involved sounds good to me

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 8, 2023
Copy link

melvin-bot bot commented Nov 8, 2023

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($500)

Copy link

melvin-bot bot commented Nov 8, 2023

The BZ member will need to manually hire artus9033 for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

@artus9033
Copy link
Contributor

artus9033 commented Nov 8, 2023

@Julesssss thanks, however from mail notifications it seems like something strange happened and somebody assigned their Upwork details as mine through melvinbot? It definitely wasn't me. Could you take a look at this and unassign if that's what happened?

@Julesssss
Copy link
Contributor

Julesssss commented Nov 8, 2023

however from mail notifications it seems like something strange happened and somebody assigned their Upwork details as mine through melvinbot?

Can you forward the email to me please (jules@expensify.com), I'm not sure exactly what you mean but can take a look

@artus9033
Copy link
Contributor

Sure thing

@Julesssss
Copy link
Contributor

Yeah, somebody seems to have added their details in place of Artur's. Investigating...

@artus9033
Copy link
Contributor

Daily update: issue identifed, solution found; working on a proposal

@melvin-bot melvin-bot bot added the Overdue label Nov 13, 2023
@artus9033
Copy link
Contributor

Update: I'll be ooo until Wednesday, when I am planning to submit the proposal

@melvin-bot melvin-bot bot removed the Overdue label Nov 13, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 13, 2023
Copy link

melvin-bot bot commented Dec 13, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 13, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @mananjadhav requires payment through NewDot Manual Requests
  • @artus9033 requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Dec 13, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
  • [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@mananjadhav] Determine if we should create a regression test for this bug.
  • [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@kevinksullivan
Copy link
Contributor

Hey @mananjadhav please fill out the checklist above when you get a chance. Thanks!

@mananjadhav
Copy link
Collaborator

I don't think we have any offending PR for this one. We changed the behavior of word-break styling. I am on the fence for this one regarding regression test. It's a small feature and I don't think we need one. @Julesssss what are your thoughts?

@Julesssss
Copy link
Contributor

I agree

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 19, 2023
@Julesssss
Copy link
Contributor

Ready for payment

@melvin-bot melvin-bot bot removed the Overdue label Dec 21, 2023
@mananjadhav
Copy link
Collaborator

@kevinksullivan can you please post the payout summary for this one?

@kevinksullivan
Copy link
Contributor

Summary

@kevinksullivan
Copy link
Contributor

Hi @artus9033 can you apply to the job and let me know when you've done so?

https://www.upwork.com/jobs/~0123a768f29d8cc1b6

@mananjadhav
Copy link
Collaborator

Thanks for summary @kevinksullivan. The payout is only for me here for C+ review. @artus9033 is from Callstack (mentioned here).

@artus9033
Copy link
Contributor

That's right, thanks for the explanation @mananjadhav

@melvin-bot melvin-bot bot added the Overdue label Dec 25, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

@mananjadhav, @artus9033, @Julesssss, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@JmillsExpensify
Copy link

$500 payment approved for @mananjadhav based on summary above.

Copy link

melvin-bot bot commented Dec 28, 2023

@mananjadhav, @artus9033, @Julesssss, @kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Jan 1, 2024

@mananjadhav, @artus9033, @Julesssss, @kevinksullivan Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Copy link

melvin-bot bot commented Jan 1, 2024

@mananjadhav, @artus9033, @Julesssss, @kevinksullivan 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Jan 3, 2024

@mananjadhav, @artus9033, @Julesssss, @kevinksullivan 10 days overdue. Is anyone even seeing these? Hello?

@Julesssss
Copy link
Contributor

Hey @mananjadhav has the payment been accepted?

@mananjadhav
Copy link
Collaborator

Yes @Julesssss Payment is done. We can close this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

6 participants