[$500] Workspace - If user log in and immediately go offline, distance rate always appears as 0

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when executing PR: #32773

Version Number: 1.4.12-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Log out and kill the app.
2. Open New Expensify app again and log in.
3. Immediately after login, disable the internet connection.
4. Go to Settings > Workspaces > Select any workspace > Reimbursement > Distance rate.

Expected Result:

Distance rate should appear as if it were loading or waiting for internet connection.

Actual Result:

Distance rate appears as 0.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6312331_1702509207886.Hbyk7885_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0181b95ca0d40733e5
• Upwork Job ID: 1735233897587527680
• Last Price Increase: 2023-12-14

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0181b95ca0d40733e5

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rate appears as 0.

What is the root cause of that problem?

We show the rate unit even when it's currentUnit is undefined (that means it's loading)

App/src/pages/workspace/reimburse/WorkspaceReimburseView.js

Line 146 in 5c0f3e4

title={currentRatePerUnit}

What changes do you think we should make in order to solve the problem?

We can show the loading indicator if distanceCustomUnit or distanceCustomRate is undefined

{!distanceCustomUnit || !distanceCustomRate? (<View style={[styles.flex1, styles.alignItemsCenter, styles.justifyContentCenter]}>
                <ActivityIndicator
                    color={theme.spinner}
                    size="large"
                />
            </View>) :(<OfflineWithFeedback
                    pendingAction={lodashGet(distanceCustomUnit, 'pendingAction') || lodashGet(distanceCustomRate, 'pendingAction')}
...
}

We can add the style (margin/padding) to make it more align

What alternative solutions did you explore? (Optional)

NA

We can consider to show the text like We need to wait for internet connection to use this feature instead of loading indicator

Result

Screen.Recording.2023-12-14.at.17.33.29.mov

[puneetlath]

Assigned to Wave 8. cc @zanyrenney as we'll need to figure out what the ideal behavior is here.

[melvin-bot]

@alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alitoshmatov]

Assigned to Wave 8. cc @zanyrenney as we'll need to figure out what the ideal behavior is here.

@puneetlath Should I proceed with reviewing proposal or are we waiting for confirmation?

[puneetlath]

We'll need to wait until someone from the wave8 team confirms what the ideal behavior should be.

[puneetlath]

I've removed the help wanted label for now. We can re-add it once the behavior has been clarified.

[melvin-bot]

@alitoshmatov Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@alitoshmatov Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@alitoshmatov 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@alitoshmatov 12 days overdue now... This issue's end is nigh!

[alitoshmatov]

Waiting for confirmation on expected behavior here.

[melvin-bot]

Current assignee @alitoshmatov is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

@alitoshmatov 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@alitoshmatov 12 days overdue now... This issue's end is nigh!

[melvin-bot]

This issue has not been updated in over 14 days. @alitoshmatov eroding to Weekly issue.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[iwiznia]

@joekaufmanexpensify @puneetlath why is this internal? Seems like we paused reviewing proposals here but never unpaused them. Did you figure out what the correct behavior is? And why would it not be to show the loading indicator?

(removing internal for now, since this can be worked on externally)

[joekaufmanexpensify]

I was just assigned today, but will take a look at the historical proposals on Monday!

[joekaufmanexpensify]

Going to take a closer look at this one today.

[joekaufmanexpensify]

Posted discussion on expected behavior

[joekaufmanexpensify]

We discussed in the above thread and decided to close this bug report. We are working on refactoring this part of the product, and this issue will be addressed then.