-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD #33315][VIP-VSP][$500] Chat - Unpinned deleted tasks assigned by another user are shown above other pinned messages #33477
Comments
Current assignee @Christinadobrzyn is eligible for the Bug assigner, not assigning anyone new. |
Bug0 Triage Checklist (Main S/O)
|
Related to #30798 |
ProposalPlease re-state the problem that we are trying to solve in this issue.After canceling the task the GRB still displays on LHN What is the root cause of that problem?After canceling the task the GRB still displays on LHN, The pusher return taskReport.isDeletedParentAction === true . But we don't add this field in this function Line 232 in 7f7cfb3
What changes do you think we should make in order to solve the problem?in this function Line 232 in 7f7cfb3
we should return
We also need to do the same thing in the chat report selector here
should add
What alternative solutions did you explore? (Optional)NA Resultsol.mp4 |
I think this should get fixed, I think it can be part of the VIP-VSB - asking for a review. https://expensify.slack.com/archives/C066HJM2CAZ/p1703269373036479 |
Added this to VIP-VSP. We can accept proposals for this! |
Job added to Upwork: https://www.upwork.com/jobs/~01df61cddd3904c57f |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif ( |
@Christinadobrzyn, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Can't reproduce it. Neither do I see the GRB nor see the deleted task above pinned chats after logging in Account B. |
@Christinadobrzyn, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this? |
I still can reproduce on the latest main, @FitseTLT Could you attach your video ? |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Looks like this issue and #33315 might have the same root cause. I suggest we hold this issue in favor of #33315 (comment). |
@Christinadobrzyn, @aimane-chnaif Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
@Christinadobrzyn, @aimane-chnaif 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it! |
adding a HOLD to this in favour of #33477 (comment) |
Issue not reproducible during KI retests. (First week) |
monitoring |
I'm going to be ooo for a week so adding a buddy to monitor this while I'm gone. Status - this is on hold for #33477 (comment) & KI retests aren't showing this (so we might be able to just close this). |
Triggered auto assignment to @garrettmknight ( |
This comment was marked as off-topic.
This comment was marked as off-topic.
Still holding |
Still holding! |
Couldn't reproduce! Closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.95-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Note: If you don't see it above the pinned messages, click on the [Deleted task] message again and eventually it displays above the pinned chats
Expected Result:
The deleted task report should not appear between GRB reports
Actual Result:
The task report still appears between GRB reports and GRB appear in the deleted task report
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
bug.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: