Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #33315][VIP-VSP][$500] Chat - Unpinned deleted tasks assigned by another user are shown above other pinned messages #33477

Closed
4 of 6 tasks
Christinadobrzyn opened this issue Dec 22, 2023 · 25 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Dec 22, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.95-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Login with Account A on new Expensify and assign a task to Account B (example: Tester login credential: gatantm+82@gmail.com gatantm+112@gmail.com)
  2. Click on the checkbox of the Task > deselect > Click the three dots
  3. Cancel the task
  4. Login with Account B > find the Deleted task in the LHN
  5. You shouldn't see the GBR and deleted task

Note: If you don't see it above the pinned messages, click on the [Deleted task] message again and eventually it displays above the pinned chats

Expected Result:
The deleted task report should not appear between GRB reports

Actual Result:
The task report still appears between GRB reports and GRB appear in the deleted task report

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01df61cddd3904c57f
  • Upwork Job ID: 1738278949092667392
  • Last Price Increase: 2023-12-29
@Christinadobrzyn Christinadobrzyn added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 22, 2023
@Christinadobrzyn Christinadobrzyn self-assigned this Dec 22, 2023
Copy link

melvin-bot bot commented Dec 22, 2023

Current assignee @Christinadobrzyn is eligible for the Bug assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Dec 22, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Christinadobrzyn
Copy link
Contributor Author

Related to #30798

@DylanDylann
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

After canceling the task the GRB still displays on LHN

What is the root cause of that problem?

After canceling the task the GRB still displays on LHN, The pusher return taskReport.isDeletedParentAction === true . But we don't add this field in this function

function getOptionData(

What changes do you think we should make in order to solve the problem?

in this function

function getOptionData(

we should return isDeletedParentAction

    result.isDeletedParentAction = report.isDeletedParentAction;

We also need to do the same thing in the chat report selector here

parentReportID: report.parentReportID,

should add

        isDeletedParentAction: report.isDeletedParentAction

What alternative solutions did you explore? (Optional)

NA

Result

sol.mp4

@Christinadobrzyn
Copy link
Contributor Author

Christinadobrzyn commented Dec 22, 2023

I think this should get fixed, I think it can be part of the VIP-VSB - asking for a review.

https://expensify.slack.com/archives/C066HJM2CAZ/p1703269373036479

@Christinadobrzyn Christinadobrzyn changed the title [$500] Chat - Unpinned deleted tasks assigned by another user are shown above other pinned messages [VIP-VSP][$500] Chat - Unpinned deleted tasks assigned by another user are shown above other pinned messages Dec 22, 2023
@Christinadobrzyn
Copy link
Contributor Author

Added this to VIP-VSP. We can accept proposals for this!

@Christinadobrzyn Christinadobrzyn added the External Added to denote the issue can be worked on by a contributor label Dec 22, 2023
Copy link

melvin-bot bot commented Dec 22, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01df61cddd3904c57f

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 22, 2023
Copy link

melvin-bot bot commented Dec 22, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

@melvin-bot melvin-bot bot added the Overdue label Dec 25, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

@Christinadobrzyn, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

@FitseTLT
Copy link
Contributor

Can't reproduce it. Neither do I see the GRB nor see the deleted task above pinned chats after logging in Account B.

Copy link

melvin-bot bot commented Dec 28, 2023

@Christinadobrzyn, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

@DylanDylann
Copy link
Contributor

I still can reproduce on the latest main, @FitseTLT Could you attach your video ?

Copy link

melvin-bot bot commented Dec 29, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@alitoshmatov
Copy link
Contributor

Looks like this issue and #33315 might have the same root cause. I suggest we hold this issue in favor of #33315 (comment).

Copy link

melvin-bot bot commented Jan 1, 2024

@Christinadobrzyn, @aimane-chnaif Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Copy link

melvin-bot bot commented Jan 1, 2024

@Christinadobrzyn, @aimane-chnaif 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@Christinadobrzyn
Copy link
Contributor Author

adding a HOLD to this in favour of #33477 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Jan 3, 2024
@Christinadobrzyn Christinadobrzyn changed the title [VIP-VSP][$500] Chat - Unpinned deleted tasks assigned by another user are shown above other pinned messages [HOLD #33315][VIP-VSP][$500] Chat - Unpinned deleted tasks assigned by another user are shown above other pinned messages Jan 3, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@Christinadobrzyn
Copy link
Contributor Author

monitoring

@Christinadobrzyn
Copy link
Contributor Author

Christinadobrzyn commented Jan 8, 2024

I'm going to be ooo for a week so adding a buddy to monitor this while I'm gone.

Status - this is on hold for #33477 (comment) & KI retests aren't showing this (so we might be able to just close this).

@Christinadobrzyn Christinadobrzyn added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jan 8, 2024
Copy link

melvin-bot bot commented Jan 8, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

This comment was marked as off-topic.

@garrettmknight
Copy link
Contributor

Still holding

@melvin-bot melvin-bot bot added the Overdue label Jan 12, 2024
@garrettmknight
Copy link
Contributor

Still holding!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 12, 2024
@garrettmknight
Copy link
Contributor

Couldn't reproduce! Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Status: CRITICAL
Development

No branches or pull requests

7 participants