[HOLD #30668] [$500] Chat - Unpinned deleted tasks assigned by another user are shown above other pinned messages

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.95-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Login with Account A on new Expensify and assign a task to Account B
2. Cancel the task
3. Login with Account B > find the Deleted task in the LHN
   Tester login credential: gatantm+82@gmail.com gatantm+112@gmail.com
4. If you don't see it above the pinned messages, click on the [Deleted task] message again and eventually it displays above the pinned chats

Expected Result:

Unpinned messages appear under pinned chats on LHN

Actual Result:

In the new build the Assigned tasks from another account that were canceled appear above or between pinned messages when they were never pinned

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2023-11-02_16-42-06.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f5bd596fa8bc9e1a
• Upwork Job ID: 1721590933982339072
• Last Price Increase: 2023-11-06
• Automatic offers:
• s77rt | Reviewer | 27545058

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

@Christinadobrzyn Can you create a task and assign it to user B using the 'share somewhere' option?

[Christinadobrzyn]

I can reproduce with the steps in the OP. @kbecciv Should I also test the share somewhere option for this?

[AndrewGable]

I don't think that PR is merged or deployed yet 🤔

[AndrewGable]

I cannot reproduce 🤔

For me the deleted task never shows up in the LHN.

Example (on staging web):

1. andrew@expensify.com sends a task to andrew+empty@expensifail.com
2. andrew+empty@expensifail.com gets the task
3. andrew+empty@expensifail.com has a pinned chat
4. andrew@expensify.com cancels task
5. andrew+empty@expensifail.com no longer sees task in LHN or chat

[AndrewGable]

When clicking on the deleted task/thread, I see it ordered correctly:

[AndrewGable]

Asking for a retest: https://expensify.slack.com/archives/C9YU7BX5M/p1699031208685439

[kbecciv]

The issue is consistently reproducible.
Here are the reproducible steps:

1. Sign in with Account A
2. Create Task and assign User B
3. Cancel the task from Account A
4. Log in with Account B and check LHN
   Note: User B must open the task to make it read

20231104_030433.mp4

[AndrewGable]

Talking with @puneetlath to see if this PR is related #30655

[puneetlath]

@waterim would you be able to look into this one? I think it's related to our GBR changes.

[AndrewGable]

I pushed a revert branch named andrew-revert-gbr and @puneetlath thinks it fixed the issue, so I do agree it seems related to the PR linked above. @waterim can you let us know what you find out?

I discussed with @puneetlath and @JmillsExpensify and we decided not to block the deploy on this as Tasks is a relatively small feature in general.

[s77rt]

@Christinadobrzyn This is still hold on #30668. Not accepting further proposals since @waterim is already assigned to take care of this (in case the other linked issue didn't fix it).

cc @DylanDylann

[Christinadobrzyn]

oh thanks, @s77rt! I removed the Help wanted label since @waterim is assigned for this!

[s77rt]

Still on hold

[Christinadobrzyn]

I think I'm going to move this to weekly as we're still waiting on this PR that hasn't been deployed yet. @s77rt let me know if you'd prefer this is still daily

[s77rt]

Weekly sounds good to me as well 👍

[Christinadobrzyn]

monitoring #32140

[DylanDylann]

@Christinadobrzyn @s77rt This PR is merged. Let's remove hold

[DylanDylann]

After re-check on the latest main, I see that after canceling the task the GRB still displays

bug.mp4

From my viewpoint, I think the GRB should disappear immediately after canceling the task

So that I post this proposal to fix this bug

Proposal

Please re-state the problem that we are trying to solve in this issue.

After canceling the task the GRB still displays on LHN

What is the root cause of that problem?

After canceling the task the GRB still displays on LHN, The pusher return taskReport.isDeletedParentAction === true . But we don't add this field in this function

App/src/libs/SidebarUtils.ts

Line 232 in 7f7cfb3

function getOptionData(

What changes do you think we should make in order to solve the problem?

in this function

App/src/libs/SidebarUtils.ts

Line 232 in 7f7cfb3

function getOptionData(

we should return isDeletedParentAction

    result.isDeletedParentAction = report.isDeletedParentAction;

We also need to do the same thing in the chat report selector here

App/src/pages/home/sidebar/SidebarLinksData.js

Line 170 in 7f7cfb3

parentReportID: report.parentReportID,

should add

        isDeletedParentAction: report.isDeletedParentAction

What alternative solutions did you explore? (Optional)

NA

Result

sol.mp4

[s77rt]

@DylanDylann This issue does not have Help Wanted label. @waterim is already assigned to work on this issue

[s77rt]

@Christinadobrzyn Please lift the hold since #32140 is merged now

[s77rt]

@waterim Please check this issue once you get a chance

[waterim]

@s77rt I can see that the issue here is "Unpinned deleted tasks assigned by another user are shown above other pinned messages", but this one was fixed and as I understand we want to fix GBR for deleted task as well here, right?

[DylanDylann]

@s77rt @Christinadobrzyn Should we create a new issue for the bug that is mentioned here ? I think It also be a critical bug

[waterim]

@s77rt After my check I agree with @DylanDylann solution, we are just not setting in time the data regarding "isDeletedParentAction" when pusher sends it to us. I can create a PR for that

[s77rt]

Since this is another bug I think it would be fair to create another issue for it.

[s77rt]

For this one I think we can just close it.

[DylanDylann]

@Christinadobrzyn @lanitochka17 Could you help to create a new issue for this one. It is so similar this issue and it is critical bug

Action Performed:
Same as this issue

Expected Result:
The deleted task report should not appear between GRB reports

Actual Result:
The task report still appears between GRB reports and GRB appear in the deleted task report

Video

bug.mp4

cc @s77rt

[Christinadobrzyn]

So sorry for the delay @DylanDylann I created the new issue here- #33477

should we close this one or work on them together?

[s77rt]

@Christinadobrzyn This can be closed